Status Update
Comments
ma...@wnco.com <ma...@wnco.com> #3
Thanks for the report!
re...@gmail.com <re...@gmail.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
do...@gmail.com <do...@gmail.com> #5
se...@google.com <se...@google.com>
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
se...@google.com <se...@google.com> #7
The dialog now updates icons based on content color luminance. Additionally, bottomsheet properties let you customize this value yourself.
pr...@google.com <pr...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha03
androidx.compose.material3:material3-android:1.4.0-alpha03
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha03
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha03
do...@gmail.com <do...@gmail.com> #9
The new options to adjust the status/navigation icons color don't work properly for me.
ModalBottomSheetProperties(
isAppearanceLightStatusBars = false,
isAppearanceLightNavigationBars = true,
)
The settings above make both status and navigation icons black.
On the other hand, the settings below make both icons white.
ModalBottomSheetProperties(
isAppearanceLightStatusBars = true,
isAppearanceLightNavigationBars = false,
)
The color of the status and navigation bar icons should be different in both cases.
Could you please take a look at it?
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <
Link:
[M3][BottomSheets] Fix status bar typo assigning flag incorrectly
Expand for full commit details
[M3][BottomSheets] Fix status bar typo assigning flag incorrectly
Bug: 362539765
Test: Manual
RelNote: "Correctly route status and navigation bar flags for windows properties"
Change-Id: Ie674d4f080aafa8a41aeb3732797916169a07198
Files:
- M
compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
Hash: b33d952af7bf32544535b9404fc9865322b87f75
Date: Fri Nov 08 14:05:04 2024
se...@google.com <se...@google.com> #11
Thank you for catching this bug, the flags were incorrectly assigned in the constructor.
Description
Jetpack Compose version: 2024.08.00 BOM
Material Library Version: "androidx.compose.material3:material3:1.3.0-rc01
Material Compose component used: ModalBottomSheet
Android Studio Build: 2024.1.1 Patch 2
Kotlin version: 1.9.0
Steps to Reproduce or Code Sample to Reproduce:
Expected behavior:
ModalBottomSheet should not change status bar icon color unless it is expanded into the status bar. Or there should be an option to override it.