ModalBottomSheet making status icons invisible in dark status bar [362539765]

Verified

Bug

Status Update

No update yet.

Description

ma...@wnco.com

created issue #1

Aug 27, 2024 10:30PM

Jetpack Compose version: 2024.08.00 BOM

Material Library Version: "androidx.compose.material3:material3:1.3.0-rc01

Material Compose component used: ModalBottomSheet

Android Studio Build: 2024.1.1 Patch 2

Kotlin version: 1.9.0

Steps to Reproduce or Code Sample to Reproduce:

Set app theme status bar to always have dark background and light icons (regardless of dark/light theme)
Set device theme to light mode
Draw a half screen modal bottom sheet
Observe Status bar icons are darkened and barely visible behind scrim on dark background

Expected behavior:

ModalBottomSheet should not change status bar icon color unless it is expanded into the status bar. Or there should be an option to override it.

Comments

ma...@wnco.com <ma...@wnco.com> #2Aug 27, 2024 10:32PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ma...@wnco.com <ma...@wnco.com> #3Aug 28, 2024 02:47PM

Thanks for the report!

Message last modified on Aug 28, 2024 02:47PM

re...@gmail.com <re...@gmail.com> #4Sep 10, 2024 06:00AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Message last modified on Sep 10, 2024 06:01AM

do...@gmail.com <do...@gmail.com> #5Sep 10, 2024 06:07AM

deleted

se...@google.com <se...@google.com> Sep 30, 2024 06:45PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> Oct 2, 2024 07:18PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #6Oct 16, 2024 05:29PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

se...@google.com <se...@google.com> #7Oct 16, 2024 05:31PM

Marked as fixed.

The dialog now updates icons based on content color luminance. Additionally, bottomsheet properties let you customize this value yourself.

pr...@google.com <pr...@google.com> #8Oct 30, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha03
androidx.compose.material3:material3-android:1.4.0-alpha03
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha03
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha03

do...@gmail.com <do...@gmail.com> #9Nov 6, 2024 09:54PM

The new options to adjust the status/navigation icons color don't work properly for me.

ModalBottomSheetProperties(
    isAppearanceLightStatusBars = false,
    isAppearanceLightNavigationBars = true,
)

The settings above make both status and navigation icons black.

On the other hand, the settings below make both icons white.

ModalBottomSheetProperties(
    isAppearanceLightStatusBars = true,
    isAppearanceLightNavigationBars = false,
)

The color of the status and navigation bar icons should be different in both cases.

Could you please take a look at it?

se...@google.com <se...@google.com> Nov 8, 2024 07:00PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #10Nov 11, 2024 04:56PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3341778

[M3][BottomSheets] Fix status bar typo assigning flag incorrectly

Expand for full commit details

[M3][BottomSheets] Fix status bar typo assigning flag incorrectly 
 
Bug: 362539765 
Test: Manual 
RelNote: "Correctly route status and navigation bar flags for windows properties" 
Change-Id: Ie674d4f080aafa8a41aeb3732797916169a07198

Files:

M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt

Hash: b33d952af7bf32544535b9404fc9865322b87f75
Date: Fri Nov 08 14:05:04 2024

se...@google.com <se...@google.com> #11Nov 11, 2024 05:06PM

Verified by se...@google.com.

Thank you for catching this bug, the flags were incorrectly assigned in the constructor.