Status Update
Comments
ma...@wnco.com <ma...@wnco.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
ma...@wnco.com <ma...@wnco.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
re...@gmail.com <re...@gmail.com> #4
Workaround: put this code inside the sheet's content block
Had a similar issue and a slightly different work-around which worked before Material3 1.3.0. Now my work-around doesn't work anymore, but thankfully yours does. It's quite frustrating that every new version of Compose APIs seems to break our code. Some functions/properties/parameters are completely getting removed and replaced with incompatible ones which are still marked "experimental" even in stable versions. Then, next time, these APIs get changed again and, again, we have to update our code.
do...@gmail.com <do...@gmail.com> #5
I can't agree more. There should definitely be a parameter to control this (also for the nav bar icons). It was already requested two months ago here:
Why would the device theme dictate which status/nav bar icon color to use? It doesn't make sense. Please, add an easy way to control this.
se...@google.com <se...@google.com>
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <
Link:
[M3][BottomSheet] Provide bottomsheet properties for users to manually adjust status and navigation bar colors.
Expand for full commit details
[M3][BottomSheet] Provide bottomsheet properties for users to manually adjust status and navigation bar colors.
Bug: 362539765
Test: Manual
RelNote: "Additional ModalBottomSheetProperties allow for customization of status and navigation bar colors. By default, these update based on content color instead of system dark theme status."
Change-Id: Ib874e2b06477ef077534e5af31c1c7be97a4e134
Files:
- M
compose/material3/material3/api/current.txt
- M
compose/material3/material3/api/restricted_current.txt
- M
compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
- M
compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/ModalBottomSheet.commonStubs.kt
Hash: c4cab4797ba69f7c2f6426518fa9992124fab38a
Date: Wed Oct 02 14:04:43 2024
se...@google.com <se...@google.com> #7
The dialog now updates icons based on content color luminance. Additionally, bottomsheet properties let you customize this value yourself.
pr...@google.com <pr...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha03
androidx.compose.material3:material3-android:1.4.0-alpha03
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha03
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha03
do...@gmail.com <do...@gmail.com> #9
The new options to adjust the status/navigation icons color don't work properly for me.
ModalBottomSheetProperties(
isAppearanceLightStatusBars = false,
isAppearanceLightNavigationBars = true,
)
The settings above make both status and navigation icons black.
On the other hand, the settings below make both icons white.
ModalBottomSheetProperties(
isAppearanceLightStatusBars = true,
isAppearanceLightNavigationBars = false,
)
The color of the status and navigation bar icons should be different in both cases.
Could you please take a look at it?
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <
Link:
[M3][BottomSheets] Fix status bar typo assigning flag incorrectly
Expand for full commit details
[M3][BottomSheets] Fix status bar typo assigning flag incorrectly
Bug: 362539765
Test: Manual
RelNote: "Correctly route status and navigation bar flags for windows properties"
Change-Id: Ie674d4f080aafa8a41aeb3732797916169a07198
Files:
- M
compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
Hash: b33d952af7bf32544535b9404fc9865322b87f75
Date: Fri Nov 08 14:05:04 2024
se...@google.com <se...@google.com> #11
Thank you for catching this bug, the flags were incorrectly assigned in the constructor.
Description
Jetpack Compose version: 2024.08.00 BOM
Material Library Version: "androidx.compose.material3:material3:1.3.0-rc01
Material Compose component used: ModalBottomSheet
Android Studio Build: 2024.1.1 Patch 2
Kotlin version: 1.9.0
Steps to Reproduce or Code Sample to Reproduce:
Expected behavior:
ModalBottomSheet should not change status bar icon color unless it is expanded into the status bar. Or there should be an option to override it.