navigation-fragment-compose: Safe Args plugin cannot escape composable destination name [362791955]

Fixed

Bug

androidx-navigation-2.9.0-alpha06

androidx-navigation-2.8.7

Status Update

No update yet.

Description

je...@pinkfroot.com

created issue #1

Aug 29, 2024 07:39AM

Component used: Navigation (androidx.navigation:navigation-fragment-compose)

Version used: 2.8.0-rc01

Devices/Android versions reproduced on: N/A (build issue)

As soon as I add an action to a composable destination like so:

<composable
  android:id="@+id/home_screen"
  android:name="com.example.HomeScreenKt\$HomeScreen" >
  <action
    android:id="@+id/action_home_screen_to_other_fragment"
    app:destination="@id/other_fragment" />
</composable>

My project build fails on the :app:generateSafeArgs task with the following error:

Can't escape identifier `HomeScreenKt\$HomeScreenDirections` because it contains illegal characters: \

Comments

cl...@couchbits.com <cl...@couchbits.com> #2Sep 25, 2024 07:58AM

It could easy to reproduce when turning on "Don't keep activities".

362791955.log

19 KB

View

Download

we...@gmail.com <we...@gmail.com> #3Oct 15, 2024 10:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ba0c19707915ff87d9cac2089fcd166bb5cca17d
Author: Ian Lake <ilake@google.com>
Date: Wed Nov 14 16:20:28 2018

Set the correct FragmentManager on active Fragments

All active Fragments should have the correct
FragmentManager set instead of always using the
Activity's FragmentManager.

While added Fragments have their FragmentManager
set correctly in moveToState(), active Fragments
weren't being set correctly, causing issues when
attempting to save the state of the FragmentManager.

Test: new FragmentLifecycleTest
BUG: 119256498
Change-Id: I830f729d93f00859509a0844fae19752342e6ccc

M fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.java
M fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java
M fragment/src/main/java/androidx/fragment/app/FragmentState.java

https://android-review.googlesource.com/826954

https://goto.google.com/android-sha1/ba0c19707915ff87d9cac2089fcd166bb5cca17d

se...@gmail.com <se...@gmail.com> #4Nov 21, 2024 09:55PM

Thanks Ian! Looking forward to a new alpha release ASAP rather than monthly release.😅

jb...@google.com <jb...@google.com> Jan 14, 2025 08:02PM

Assigned to il...@google.com.

pr...@google.com <pr...@google.com> Jan 22, 2025 05:37PM

Reassigned to jb...@google.com.

aa...@gmail.com <aa...@gmail.com> #5Jan 27, 2025 06:35AM

Thanks for fixing this!

ap...@google.com <ap...@google.com> #6Feb 5, 2025 08:51PM

Wondering is there any release plan?

jb...@google.com <jb...@google.com> #7Feb 5, 2025 09:01PM

Marked as fixed.

Fragments 1.1.0-alpha02 is out now with this fix.

pr...@google.com <pr...@google.com> #8Feb 12, 2025 06:40PM

Does Preferences also depend on Fragments? In which case when will that be updated to 1.1.0-alpha02? Or is the recommended practice to specify both Preferences and Fragments in build.gradle so that we can force Fragments 1.1.0-alpha02?