navigation-fragment-compose: Safe Args plugin cannot escape composable destination name [362791955]

Fixed

Bug

androidx-navigation-2.9.0-alpha06

androidx-navigation-2.8.7

Status Update

No update yet.

Description

je...@pinkfroot.com

created issue #1

Aug 29, 2024 07:39AM

Component used: Navigation (androidx.navigation:navigation-fragment-compose)

Version used: 2.8.0-rc01

Devices/Android versions reproduced on: N/A (build issue)

As soon as I add an action to a composable destination like so:

<composable
  android:id="@+id/home_screen"
  android:name="com.example.HomeScreenKt\$HomeScreen" >
  <action
    android:id="@+id/action_home_screen_to_other_fragment"
    app:destination="@id/other_fragment" />
</composable>

My project build fails on the :app:generateSafeArgs task with the following error:

Can't escape identifier `HomeScreenKt\$HomeScreenDirections` because it contains illegal characters: \

Comments

cl...@couchbits.com <cl...@couchbits.com> #2Sep 25, 2024 07:58AM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

362791955.log

19 KB

View

Download

we...@gmail.com <we...@gmail.com> #3Oct 15, 2024 10:14PM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

se...@gmail.com <se...@gmail.com> #4Nov 21, 2024 09:55PM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

jb...@google.com <jb...@google.com> Jan 14, 2025 08:02PM

Assigned to il...@google.com.

pr...@google.com <pr...@google.com> Jan 22, 2025 05:37PM

Reassigned to jb...@google.com.

aa...@gmail.com <aa...@gmail.com> #5Jan 27, 2025 06:35AM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

ap...@google.com <ap...@google.com> #6Feb 5, 2025 08:51PM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

jb...@google.com <jb...@google.com> #7Feb 5, 2025 09:01PM

Marked as fixed.

Added a patch for androidx-master-dev that demos a horizontal ViewPager2 inside a vertical RecyclerView.

Verified that it works correctly on a:
- Nexus 4 emulator with API 17
- Nexus 5X emulator with API 28
- Pixel 2 device with API 29

To reproduce:
- Check out the Android Jetpack source (at commit 256899f482ff85cddfb050f37550be7b5ec927ef) (see steps in [1])
- Apply the patch (`git apply 0001-Add-sample-where-a-horizontal-ViewPager2-is-nested-i.patch`)
- Build and install viewpager2's integration-tests app: `./gradlew viewpager2:integration-tests:testapp:installDebug`
- Run it

Closing the issue for now, but please reopen if you have a minimal reproduction app

[1]

https://android.googlesource.com/platform/frameworks/support/+/256899f482ff85cddfb050f37550be7b5ec927ef

pr...@google.com <pr...@google.com> #8Feb 12, 2025 06:40PM

Re-opening as requested by a few users. Narrowed down the focus to nested scrolling elements with the same scroll direction.