Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
I liked Aurimas' idea to move this to a separate root level plugin. That also gives us the option to incorporate the new disableJit and resetDevice scripts recently added, but not exported as gradle tasks.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 9657621344d1a5916dc2679a3f015bf6e9e1e8da
Author: Marcello Albano <maralb@google.com>
Date: Tue Sep 10 13:00:50 2024
Moved lockClocks and unlockClocks to project tasks
Bug: 363325823
Test: existing
Relnote: "Moved tasks lockClocks and unlockClocks
to be on benchmark projects, instead of
available at the top level. Unfortunately
there's no way to register these as top level
actions without breaking project isolation."
Change-Id: I02b8fdfdf2f67127534f349a9e64aaa9a78b66e5
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
https://android-review.googlesource.com/3260497
Branch: androidx-main
commit 9657621344d1a5916dc2679a3f015bf6e9e1e8da
Author: Marcello Albano <maralb@google.com>
Date: Tue Sep 10 13:00:50 2024
Moved lockClocks and unlockClocks to project tasks
Bug: 363325823
Test: existing
Relnote: "Moved tasks lockClocks and unlockClocks
to be on benchmark projects, instead of
available at the top level. Unfortunately
there's no way to register these as top level
actions without breaking project isolation."
Change-Id: I02b8fdfdf2f67127534f349a9e64aaa9a78b66e5
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
ma...@google.com <ma...@google.com>
au...@google.com <au...@google.com> #4
Have we shipped a fixed version of this plugin? Is 1.4.0-alpha01 supposed to have the fix?
cc...@google.com <cc...@google.com> #5
We have not released it yet, should go out in the 1.4.0-alpha02 release today.
pr...@google.com <pr...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-gradle-plugin:1.4.0-alpha02
Description
Benchmark gradle plugin is not Gradle project isolation safe as it accesses root project to create and tasks which requires root project to be configured before the project applying the benchmark plugin.
lockClocks
unlockClocks