Benchmark gradle plugin is not Gradle project isolation safe [363325823]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Aug 30, 2024 09:32PM

Benchmark gradle plugin is not Gradle project isolation safe as it accesses root project to create lockClocks and unlockClocks tasks which requires root project to be configured before the project applying the benchmark plugin.

Comments

cc...@google.com <cc...@google.com> #2Aug 30, 2024 09:37PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 782378852514e76eac3dfd115f7aca6c6ac6eec2
Author: Marcello Albano <maralb@google.com>
Date: Fri May 17 10:53:04 2024

Added enabling aot compilation prop in benchmark plugin

Test: ./gradlew benchmark:benchmark-gradle-plugin:test
Bug: 325512900
Change-Id: Ie049719ecb7e17ae46abf7c858120f03a35d9222

M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
M benchmark/gradle-plugin/src/test/kotlin/androidx/benchmark/gradle/BenchmarkPluginTest.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt

https://android-review.googlesource.com/3094561

ap...@google.com <ap...@google.com> #3Sep 16, 2024 05:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5ba0e94ed48d43e30c51c999b247497e1ad675b0
Author: Marcello Albano <maralb@google.com>
Date: Sat May 18 11:58:28 2024

Added compilation mode into benchmark context

Bug: 325512900
Change-Id: If5612552a718b459e95cd96dc721e92a88e3fa8a
Test: ShellTest
Relnote: Added compilation mode to benchmark context

M benchmark/benchmark-common/src/androidTest/assets/macro-legacy-trivialscrollbench.json
M benchmark/benchmark-common/src/androidTest/assets/micro-legacy-trivialbench.json
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ResultWriterTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellTest.kt
A benchmark/benchmark-common/src/main/java/androidx/benchmark/PackageInfo.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/json/BenchmarkData.kt
M benchmark/integration-tests/macrobenchmark/src/main/java/androidx/benchmark/integration/macrobenchmark/CompilationModeTest.kt

https://android-review.googlesource.com/3094294

ma...@google.com <ma...@google.com> Sep 18, 2024 06:04PM

Marked as fixed.

au...@google.com <au...@google.com> #4Oct 2, 2024 08:02AM

Closing this one - remaining things to do will be in benchmark 1.4. Follow up on b/343983464

cc...@google.com <cc...@google.com> #5Oct 2, 2024 04:44PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.3.0-beta01
androidx.benchmark:benchmark-gradle-plugin:1.3.0-beta01

pr...@google.com <pr...@google.com> #6Oct 2, 2024 05:37PM