Enabling strict mode shows diskreadviolations in room for kmp [363985585]

Fixed

Bug

Status Update

No update yet.

Description

m....@gmail.com

created issue #1

Sep 2, 2024 09:44PM

Following the steps outlined in the official KMP Room docs (https://developer.android.com/kotlin/multiplatform/room) , I see 5 strict mode violations in my code.

They dont seem to cause any noticable lag but i was wondering if this violation is expected?

        val policy = StrictMode.ThreadPolicy.Builder()
            .detectDiskReads()
            .detectDiskWrites()
            .detectNetwork()
            .penaltyLog() 
            .build()
        StrictMode.setThreadPolicy(policy)
    }```

Also the  other four reports are similar more or less to the attached screenshot

Tue Sep 03 2024 01:42:31 GMT+0400 (Gulf Standard Time).png

341 KB

View

Download

Comments

da...@google.com <da...@google.com> #2Sep 3, 2024 05:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

m....@gmail.com <m....@gmail.com> #3Sep 3, 2024 05:25PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

da...@google.com <da...@google.com> #4Sep 3, 2024 05:29PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

m....@gmail.com <m....@gmail.com> #5Sep 3, 2024 05:31PM

Great ! .acknowledged. Ty

da...@google.com <da...@google.com> Jan 17, 2025 07:09PM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> Jan 22, 2025 12:17AM

Accepted by da...@google.com.

ap...@google.com <ap...@google.com> #6Jan 23, 2025 08:13PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3461119

Lazily load SQLite's native library when a connection is opened.

Expand for full commit details

Lazily load SQLite's native library when a connection is opened. 
 
Moving the load call into an inner object effectively makes it so that the library is loaded lazily when the object's class is loaded, i.e. when instantiated and accessed during the open call. 
 
Bug: 363985585 
Test: BundledSQLiteDriverTest.kt 
Change-Id: I72fa01618169cb3225ea9d5d5e9f9ae59c6d4b09

Files:

M sqlite/integration-tests/driver-conformance-test/src/androidInstrumentedTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/sqlite-bundled/src/jvmAndroidMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.jvmAndroid.kt

Hash: 4f69d19088dae47b6a7bcf454ea22f7e2da78e92
Date: Tue Jan 21 17:51:32 2025

da...@google.com <da...@google.com> Jan 23, 2025 08:18PM

Marked as fixed.

na...@google.com <na...@google.com> #7Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.sqlite:sqlite-bundled:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-android:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-iosarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha13