Enabling strict mode shows diskreadviolations in room for kmp [363985585]

Fixed

Bug

Status Update

No update yet.

Description

m....@gmail.com

created issue #1

Sep 2, 2024 09:44PM

Following the steps outlined in the official KMP Room docs (https://developer.android.com/kotlin/multiplatform/room) , I see 5 strict mode violations in my code.

They dont seem to cause any noticable lag but i was wondering if this violation is expected?

        val policy = StrictMode.ThreadPolicy.Builder()
            .detectDiskReads()
            .detectDiskWrites()
            .detectNetwork()
            .penaltyLog() 
            .build()
        StrictMode.setThreadPolicy(policy)
    }```

Also the  other four reports are similar more or less to the attached screenshot

Tue Sep 03 2024 01:42:31 GMT+0400 (Gulf Standard Time).png

341 KB

View

Download

Comments

da...@google.com <da...@google.com> #2Sep 3, 2024 05:08PM

since these are in public API (:/) we need to do this in 1.2

m....@gmail.com <m....@gmail.com> #3Sep 3, 2024 05:25PM

since it is already marked as deprecated, we can probably do it by now.

da...@google.com <da...@google.com> #4Sep 3, 2024 05:29PM

Opening diff shortly

m....@gmail.com <m....@gmail.com> #5Sep 3, 2024 05:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

da...@google.com <da...@google.com> Jan 17, 2025 07:09PM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> Jan 22, 2025 12:17AM

Accepted by da...@google.com.

ap...@google.com <ap...@google.com> #6Jan 23, 2025 08:13PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3461119

Lazily load SQLite's native library when a connection is opened.

Expand for full commit details

Lazily load SQLite's native library when a connection is opened. 
 
Moving the load call into an inner object effectively makes it so that the library is loaded lazily when the object's class is loaded, i.e. when instantiated and accessed during the open call. 
 
Bug: 363985585 
Test: BundledSQLiteDriverTest.kt 
Change-Id: I72fa01618169cb3225ea9d5d5e9f9ae59c6d4b09

Files:

M sqlite/integration-tests/driver-conformance-test/src/androidInstrumentedTest/kotlin/androidx/sqlite/driver/test/BundledSQLiteDriverTest.kt
M sqlite/sqlite-bundled/src/jvmAndroidMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.jvmAndroid.kt

Hash: 4f69d19088dae47b6a7bcf454ea22f7e2da78e92
Date: Tue Jan 21 17:51:32 2025

da...@google.com <da...@google.com> Jan 23, 2025 08:18PM

Marked as fixed.

na...@google.com <na...@google.com> #7Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.sqlite:sqlite-bundled:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-android:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-iosarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha13
androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha13