Enabling strict mode shows diskreadviolations in room for kmp [363985585]

Fixed

Bug

Status Update

No update yet.

Description

m....@gmail.com

created issue #1

Sep 2, 2024 09:44PM

Following the steps outlined in the official KMP Room docs (https://developer.android.com/kotlin/multiplatform/room) , I see 5 strict mode violations in my code.

They dont seem to cause any noticable lag but i was wondering if this violation is expected?

        val policy = StrictMode.ThreadPolicy.Builder()
            .detectDiskReads()
            .detectDiskWrites()
            .detectNetwork()
            .penaltyLog() 
            .build()
        StrictMode.setThreadPolicy(policy)
    }```

Also the  other four reports are similar more or less to the attached screenshot

Tue Sep 03 2024 01:42:31 GMT+0400 (Gulf Standard Time).png

341 KB

View

Download

Comments

da...@google.com <da...@google.com> #2Sep 3, 2024 05:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit e81f3bda1116a1734ec397f54dd40f8472203294
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Aug 08 12:22:30 2022

Converting `sqlite` related files in `sqlite` from Java to Kotlin (Part 1/3).

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I7bc3574feaacb12bd4aa1c006579ddc52607a3a5

M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/test/java/androidx/room/RoomSQLiteQueryTest.java
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteProgram.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteCompat.kt
M sqlite/sqlite/src/test/java/androidx/sqlite/db/SimpleSQLiteQueryTest.kt
M sqlite/sqlite/api/current.txt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SimpleSQLiteQuery.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQuery.kt
M room/room-compiler/build.gradle
M room/room-runtime/src/main/java/androidx/room/RoomSQLiteQuery.kt
M sqlite/sqlite-framework/build.gradle
M sqlite/sqlite/api/public_plus_experimental_current.txt
M sqlite/sqlite/build.gradle
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteStatement.kt
M room/room-runtime/api/restricted_current.ignore
M sqlite/sqlite/api/restricted_current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt

https://android-review.googlesource.com/2177713

m....@gmail.com <m....@gmail.com> #3Sep 3, 2024 05:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit 659c2cdeeb8a045b413da4763d1431497592e5cf
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Aug 08 11:07:43 2022

Renaming `sqlite` related files in `sqlite` from Java to Kotlin (Part 1/3).

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I60b041d58430c70c028b91ef8c86a0d64f89fc3a

M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQuery.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteStatement.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteProgram.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteCompat.kt
M sqlite/sqlite/src/test/java/androidx/sqlite/db/SimpleSQLiteQueryTest.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SimpleSQLiteQuery.kt

https://android-review.googlesource.com/2177712

da...@google.com <da...@google.com> #4Sep 3, 2024 05:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit a55634970cd065189bf9055c9ec5cbbdeeb789fc
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 10 16:44:43 2022

Converting `sqlite-framework` related files in `sqlite-framework` from Java to Kotlin.

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite-framework` related files in `sqlite-framework` from Java to Kotlin.
Change-Id: Iaa63a678596118d4d40da7b12a30839166d0bc11

D sqlite/sqlite-framework/src/main/java/androidx/sqlite/util/SneakyThrow.java
M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperTest.kt
M sqlite/sqlite-framework/api/current.txt
M sqlite/sqlite-framework/src/androidTest/java/androidx/sqlite/db/framework/OpenHelperRecoveryTest.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteProgram.kt
M sqlite/sqlite-framework/api/public_plus_experimental_current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/InternalsTest.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/util/ProcessLock.kt
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteStatement.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelperFactory.kt
M sqlite/sqlite-framework/api/restricted_current.txt

https://android-review.googlesource.com/2182324

m....@gmail.com <m....@gmail.com> #5Sep 3, 2024 05:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit d6fc345225a1546cdb00a8a2728dfb5adcddb762
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 10 12:55:32 2022

Initial code check-in for renaming `sqlite-framework` related files in `sqlite` from *.java to *.kt.

Test: N/A
Bug: 240707042
Relnote: Initial code check-in for renaming `sqlite-framework` related files in `sqlite` from *.java to *.kt.
Change-Id: I2ecd06a8122751ae46765a8a354a6c1e191e2149

M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/util/ProcessLock.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteProgram.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteStatement.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelperFactory.kt

https://android-review.googlesource.com/2182323

da...@google.com <da...@google.com> Jan 17, 2025 07:09PM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> Jan 22, 2025 12:17AM

Accepted by da...@google.com.

ap...@google.com <ap...@google.com> #6Jan 23, 2025 08:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5e2fab48d7c66ec49ae8c1fff52bd0999c94fe05
Author: elifbilgin <elifbilgin@google.com>
Date: Thu Aug 18 10:27:53 2022

Converting `sqlite` related files in `sqlite` from Java to Kotlin (Part 2/3).

Test: Existing tests
Bug: 240707042
Relnote: Converting `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I1d635ae1b6e7ef76de9c626b2088266a6a094a4d

M work/work-runtime/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendingQueryTest.kt
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQueryBuilder.kt
M work/work-gcm/build.gradle
M sqlite/sqlite/api/current.txt
M work/work-testing/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/ForceStopRunnableTest.java
M room/room-runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.kt
M sqlite/sqlite/api/public_plus_experimental_current.txt
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteOpenHelper.kt
M work/work-multiprocess/build.gradle
M sqlite/sqlite/api/restricted_current.txt
M work/work-benchmark/build.gradle
M work/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/2189939

da...@google.com <da...@google.com> Jan 23, 2025 08:18PM

Marked as fixed.

na...@google.com <na...@google.com> #7Jan 29, 2025 06:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 751e9ba511b3263cab58bd877afe2dd7dc77b891
Author: elifbilgin <elifbilgin@google.com>
Date: Wed Aug 17 16:31:25 2022

Renaming `sqlite` related files in `sqlite` from Java to Kotlin (Part 2/3).

Test: Existing tests
Bug: 240707042
Relnote: Renaming `sqlite` related files in `sqlite` from Java to Kotlin.
Change-Id: I0c0558046191bd05621ae39988b4b7cd5b9459c5

M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteQueryBuilder.kt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteOpenHelper.kt

https://android-review.googlesource.com/2189938