"False positive" WrongConstant when using PackageManager.ResolveInfoFlags.of with Kotlin [364261817]

Fixed

Bug

Status Update

No update yet.

Description

ce...@gmail.com

created issue #1

Sep 3, 2024 04:00PM

packageManager.queryIntentActivities(
  intent,
  PackageManager.ResolveInfoFlags.of(PackageManager.MATCH_DEFAULT_ONLY.toLong()),
)

This piece of code generates a WrongConstant Lint error saying:

Must be one or more of: PackageManager.GET_META_DATA, PackageManager.GET_RESOLVED_FILTER, PackageManager.GET_SHARED_LIBRARY_FILES, PackageManager.MATCH_ALL, PackageManager.MATCH_DISABLED_COMPONENTS, PackageManager.MATCH_DISABLED_UNTIL_USED_COMPONENTS, PackageManager.MATCH_DEFAULT_ONLY, PackageManager.MATCH_DIRECT_BOOT_AUTO, PackageManager.MATCH_DIRECT_BOOT_AWARE, PackageManager.MATCH_DIRECT_BOOT_UNAWARE, PackageManager.MATCH_SYSTEM_ONLY, PackageManager.MATCH_UNINSTALLED_PACKAGES, PackageManager.GET_DISABLED_COMPONENTS, PackageManager.GET_DISABLED_UNTIL_USED_COMPONENTS, PackageManager.GET_UNINSTALLED_PACKAGES

I'm actually passing PackageManager.MATCH_DEFAULT_ONLY, but I can't pass exactly that value in Kotlin, as the PackageManager.ResolveInfoFlags.of expects a long, so I need to convert it, while in Java the int is implicitly cast to long.

Version of Gradle Plugin: 8.6.0

Version of Gradle: 8.10.0

Version of Java: 17

Comments

ra...@google.com <ra...@google.com> Sep 4, 2024 01:08AM

Assigned to an...@google.com.

rv...@mozilla.com <rv...@mozilla.com> #2Sep 6, 2024 02:18PM

Maybe a dup of b/368420773?

js...@google.com <js...@google.com> #3Sep 6, 2024 04:58PM

Reassigned to js...@google.com.

Android Gradle Plugin: 8.7.1

Could you try the latest canary, AGP 8.8.0-alpha09?

js...@google.com <js...@google.com> Sep 7, 2024 08:35AM

Accepted by js...@google.com.

js...@google.com <js...@google.com> Sep 9, 2024 04:49PM

Marked as fixed.

rv...@mozilla.com <rv...@mozilla.com> #4Sep 11, 2024 12:48PM

I just updated to Android Gradle Plugin: 8.7.2 and the bug is fixed.

js...@google.com <js...@google.com> #5Sep 11, 2024 05:12PM

I spoke too soon. The bug appears gone when I use a different computer, but that is only because the lint check is disabled on it. The computer with the false positive is a new cloning of my github project which apparently has the lint check enabled. The AGP 8.8.0-alpha09 plugin will not work on ladybug, and I'm too busy to switch to a canary build of android studio just to fix a false positive lint check, sorry.

js...@google.com <js...@google.com> #6Sep 12, 2024 02:55AM

I just tried running lint on two more of my computers, one which also has a fresh clone of the github project, and one which has an "ancient" (but up to date) clone of the project -- the two computers have very different Settings -> Editor -> Inspections choices. The old clones do not have this lint check anywhere in their choices, whereas new clones do. Very odd indeed. (I have .idea/ in my .gitignore BTW).

rv...@mozilla.com <rv...@mozilla.com> #7Sep 12, 2024 03:02AM

I understand that it's not trivial to change AGP version; sorry for suggesting that first.

Actually, there is a better way to test: android.experimental.lint.version=8.8.0-alpha09 which will just change the Lint version.

an...@google.com <an...@google.com> #8Sep 12, 2024 06:57PM

I decided it was easier to download Android Studio Ladybug Feature Drop | 2024.2.2 Canary 9 than to figure out how to use a different version of lint (a search of stackoverflow suggests this is impossible for what that is worth). Using AGP 8.8.0-alpha09 and gradle-8.10.2-bin.zip on Canary the same error occurs. It looks like it is caused by the K2 compiler mode, because the Inspections options for this lint check does not appear until you enble K2 mode (nor does the false positive error).

an...@google.com <an...@google.com> #9Sep 23, 2024 04:42PM

Thank you for trying the latest canary version of Studio and AGP, I really appreciate that.

I rather confirmed that, with that canary (AGP 8.8.0-alpha09), b/368420773 is really fixed, with the attached reproduction project there. (Note that that issue is also related to K2 mode.)

I also tried altering problematic produceState call with conditional assignment to value, which also works fine. I tried a similar code pattern on compose runtime ProduceStateDetector and its tests, but no luck.

Then... my next guess is whether it is from an old compose runtime, assuming this might be a dup of b/349411310. May I ask which version(s) of Compose runtime (and related libraries) you're using?