"False positive" WrongConstant when using PackageManager.ResolveInfoFlags.of with Kotlin [364261817]

Fixed

Bug

Status Update

No update yet.

Description

ce...@gmail.com

created issue #1

Sep 3, 2024 04:00PM

packageManager.queryIntentActivities(
  intent,
  PackageManager.ResolveInfoFlags.of(PackageManager.MATCH_DEFAULT_ONLY.toLong()),
)

This piece of code generates a WrongConstant Lint error saying:

Must be one or more of: PackageManager.GET_META_DATA, PackageManager.GET_RESOLVED_FILTER, PackageManager.GET_SHARED_LIBRARY_FILES, PackageManager.MATCH_ALL, PackageManager.MATCH_DISABLED_COMPONENTS, PackageManager.MATCH_DISABLED_UNTIL_USED_COMPONENTS, PackageManager.MATCH_DEFAULT_ONLY, PackageManager.MATCH_DIRECT_BOOT_AUTO, PackageManager.MATCH_DIRECT_BOOT_AWARE, PackageManager.MATCH_DIRECT_BOOT_UNAWARE, PackageManager.MATCH_SYSTEM_ONLY, PackageManager.MATCH_UNINSTALLED_PACKAGES, PackageManager.GET_DISABLED_COMPONENTS, PackageManager.GET_DISABLED_UNTIL_USED_COMPONENTS, PackageManager.GET_UNINSTALLED_PACKAGES

I'm actually passing PackageManager.MATCH_DEFAULT_ONLY, but I can't pass exactly that value in Kotlin, as the PackageManager.ResolveInfoFlags.of expects a long, so I need to convert it, while in Java the int is implicitly cast to long.

Version of Gradle Plugin: 8.6.0

Version of Gradle: 8.10.0

Version of Java: 17

Comments

ra...@google.com <ra...@google.com> Sep 4, 2024 01:08AM

Assigned to an...@google.com.

rv...@mozilla.com <rv...@mozilla.com> #2Sep 6, 2024 02:18PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 3
Android Gradle Plugin 8.8.0-alpha03

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

js...@google.com <js...@google.com> #3Sep 6, 2024 04:58PM

Reassigned to js...@google.com.

The initial report (comment#1) seems like a dup of b/352609562 (internal link), and fixed at https://cs.android.com/android-studio/platform/tools/base/+/f88d11033727f891bcc2a7a1cbbeb109c7d5dd0f I believe it's available in AGP 8.7.0-alpha02+

However, comment#2 indicates that there are more kinds of conversions we may miss... Let me double-check that.

js...@google.com <js...@google.com> Sep 7, 2024 08:35AM

Accepted by js...@google.com.

js...@google.com <js...@google.com> Sep 9, 2024 04:49PM

Marked as fixed.

rv...@mozilla.com <rv...@mozilla.com> #4Sep 11, 2024 12:48PM

Thanks for fixing! What release should we be able to verify the fix in? And is there any chance of a backport for 8.6.1?

js...@google.com <js...@google.com> #5Sep 11, 2024 05:12PM

The caveat is that the fix for comment#1 is in 8.7.0-alpha02 and the fix for comment#2 will be in 8.8.0-alpha02. I'm asking internally how we can handle this case.

js...@google.com <js...@google.com> #6Sep 12, 2024 02:55AM

the fix for comment#2 will be in 8.8.0-alpha02

It is cherry-picked to 8.7

the fix for comment#1 is in 8.7.0-alpha02

This one and the above one are cherry-picked to 8.6.1

rv...@mozilla.com <rv...@mozilla.com> #7Sep 12, 2024 03:02AM

Thanks for the update!

an...@google.com <an...@google.com> #8Sep 12, 2024 06:57PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 2
Android Gradle Plugin 8.8.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #9Sep 23, 2024 04:42PM

The fixes for this issue are now also available in:

Android Studio Ladybug | 2024.2.1 RC 1
Android Gradle Plugin 8.7.0-rc01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Issue 364261817

Description

Issue summary

Comments

ra...@google.com <ra...@google.com> Sep 4, 2024 01:08AM

rv...@mozilla.com <rv...@mozilla.com> #2Sep 6, 2024 02:18PM

js...@google.com <js...@google.com> #3Sep 6, 2024 04:58PM

js...@google.com <js...@google.com> Sep 7, 2024 08:35AM

js...@google.com <js...@google.com> Sep 9, 2024 04:49PM

rv...@mozilla.com <rv...@mozilla.com> #4Sep 11, 2024 12:48PM

js...@google.com <js...@google.com> #5Sep 11, 2024 05:12PM

js...@google.com <js...@google.com> #6Sep 12, 2024 02:55AM

rv...@mozilla.com <rv...@mozilla.com> #7Sep 12, 2024 03:02AM

an...@google.com <an...@google.com> #8Sep 12, 2024 06:57PM

an...@google.com <an...@google.com> #9Sep 23, 2024 04:42PM

Add comment

Issue metadata