IssueTracker

Jetpack Compose version: 2024.04.01

Jetpack Compose component(s) used: Fragment-Compose

Android Studio Build: Koala Feature Drop | 2024.1.2

Kotlin version: 1.9.0

Steps to Reproduce or Code Sample to Reproduce:

1. Newly introduced API to use Fragments in Compose via AndroidFragment doesn't support DialogFragments.
2. As is, AndroidFragment composable always adds the specified fragment to the FragmentContainerView (even a dialog fragment). If the original intent wasn't to support DialogFragment, please document and/or throw an exception.

DisposableEffect(fragmentManager, clazz, fragmentState) {
        val fragment = fragmentManager.findFragmentById(container.id)
            ?: fragmentManager.fragmentFactory.instantiate(
                context.classLoader, clazz.name
            ).apply {
                setInitialSavedState(fragmentState.state.value)
                setArguments(arguments)
                fragmentManager.beginTransaction()
                    .setReorderingAllowed(true)
                    .add(container, this, "$hashKey")
                    .commitNow()
            }
        fragmentManager.onContainerAvailable(container)
        @Suppress("UNCHECKED_CAST")
        updateCallback.value(fragment as T)
        onDispose {
            val state = fragmentManager.saveFragmentInstanceState(fragment)
            fragmentState.state.value = state
            if (!fragmentManager.isStateSaved) {
                // If the state isn't saved, that means that some state change
                // has removed this Composable from the hierarchy
                fragmentManager.commitNow {
                    remove(fragment)
                }
            }
        }
    }