aosp/3202247 breaks Dialog dismissOnClickOutside [364508685]

Fixed

Bug

Status Update

No update yet.

Description

ky...@gmail.com

created issue #1

Sep 4, 2024 02:08PM

Jetpack Compose version: ToT

Steps to Reproduce or Code Sample to Reproduce: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/DialogSample.kt;l=33;drc=4d53400eca9f3ac90c3a3f6cffcbc5bf492ec536

Click outside and the dialog won't dismiss.

Comments

ti...@google.com <ti...@google.com> #2Sep 4, 2024 10:15PM

Reassigned to mo...@google.com.

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

mo...@google.com <mo...@google.com> #3Sep 5, 2024 06:00PM

Status: Won't Fix (Obsolete)

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ky...@gmail.com <ky...@gmail.com> #4Sep 5, 2024 06:47PM

deleted

Message last modified on Sep 5, 2024 07:07PM

mo...@google.com <mo...@google.com> #5Sep 5, 2024 09:08PM

Status: Assigned (reopened)

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

Message last modified on Sep 5, 2024 09:12PM

mo...@google.com <mo...@google.com> #6Sep 5, 2024 09:14PM

OK, user error. I was pointing to the wrong library when I was testing. The targetSdk = 35 was the answer. Thanks!

ap...@google.com <ap...@google.com> #7Sep 6, 2024 11:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 39a3db5b65c127043043cd67a773657c931c4188
Author: George Mount <mount@google.com>
Date: Thu Sep 05 14:21:28 2024

Properly support Dialog.dismissOnClickOutside

Fixes: 364508685

The dialog should support dismissing when clicking outside.
This fixes the support when decorFitsSystemWindows = false.

Test: manual testing, new tests
Change-Id: If49301c4fbe826dceaa5680a523c05fc1e95c816

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/window/DialogTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt

https://android-review.googlesource.com/3257338

na...@google.com <na...@google.com> #8Sep 18, 2024 05:37PM