aosp/3202247 breaks Dialog dismissOnClickOutside [364508685]

Fixed

Bug

Status Update

No update yet.

Description

ky...@gmail.com

created issue #1

Sep 4, 2024 02:08PM

Jetpack Compose version: ToT

Steps to Reproduce or Code Sample to Reproduce: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/DialogSample.kt;l=33;drc=4d53400eca9f3ac90c3a3f6cffcbc5bf492ec536

Click outside and the dialog won't dismiss.

Comments

ti...@google.com <ti...@google.com> #2Sep 4, 2024 10:15PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

mo...@google.com <mo...@google.com> #3Sep 5, 2024 06:00PM

Status: Won't Fix (Obsolete)

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ky...@gmail.com <ky...@gmail.com> #4Sep 5, 2024 06:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Message last modified on Sep 5, 2024 07:07PM

mo...@google.com <mo...@google.com> #5Sep 5, 2024 09:08PM

Status: Assigned (reopened)

I still can't reproduce the problem, even when I change targetSdk = 35. I've tried on both Pixel 2 XL (API 30) and Pixel 9 (API 35) and have the same result. I can click outside the dialog region. I'm using the provided content in my test app:

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        enableEdgeToEdge()
        setContent {
            val openDialog = remember { mutableStateOf(true) }
            val dialogWidth = 200.dp
            val dialogHeight = 50.dp

            if (openDialog.value) {
                Dialog(onDismissRequest = { openDialog.value = false }) {
                    // Draw a rectangle shape with rounded corners inside the dialog
                    Box(Modifier.size(dialogWidth, dialogHeight).background(Color.White))
                }
            }
            Button(onClick = {openDialog.value = true}, Modifier.safeContentPadding()) { Text("open") }
        }
    }

Message last modified on Sep 5, 2024 09:12PM

mo...@google.com <mo...@google.com> #6Sep 5, 2024 09:14PM

OK, user error. I was pointing to the wrong library when I was testing. The targetSdk = 35 was the answer. Thanks!

ap...@google.com <ap...@google.com> #7Sep 6, 2024 11:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 39a3db5b65c127043043cd67a773657c931c4188
Author: George Mount <mount@google.com>
Date: Thu Sep 05 14:21:28 2024

Properly support Dialog.dismissOnClickOutside

Fixes: 364508685

The dialog should support dismissing when clicking outside.
This fixes the support when decorFitsSystemWindows = false.

Test: manual testing, new tests
Change-Id: If49301c4fbe826dceaa5680a523c05fc1e95c816

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/window/DialogTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt

https://android-review.googlesource.com/3257338

na...@google.com <na...@google.com> #8Sep 18, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.8.0-alpha02
androidx.compose.ui:ui-android:1.8.0-alpha02
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha02