Status Update
Comments
ti...@google.com <ti...@google.com> #2
Geroge, I see the CL linked in
mo...@google.com <mo...@google.com> #3
I'm seeing it dismiss when clicking outside. I don't think I made any change to fix this problem, so maybe the test case is bad?
ky...@gmail.com <ky...@gmail.com> #4
I can still reproduce it with snapshot 12325744 .
Some context: mWindow.shouldCloseOnTouch(mContext, event)
false
.
Edit: I think I found the reason. That CL changed dialog theme from R.style.DialogWindowTheme
to R.style.FloatingDialogWindowTheme
on targetSdk = 35
.
mo...@google.com <mo...@google.com> #5
I still can't reproduce the problem, even when I change targetSdk = 35
. I've tried on both Pixel 2 XL (API 30) and Pixel 9 (API 35) and have the same result. I can click outside the dialog region. I'm using the provided content in my test app:
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
enableEdgeToEdge()
setContent {
val openDialog = remember { mutableStateOf(true) }
val dialogWidth = 200.dp
val dialogHeight = 50.dp
if (openDialog.value) {
Dialog(onDismissRequest = { openDialog.value = false }) {
// Draw a rectangle shape with rounded corners inside the dialog
Box(Modifier.size(dialogWidth, dialogHeight).background(Color.White))
}
}
Button(onClick = {openDialog.value = true}, Modifier.safeContentPadding()) { Text("open") }
}
}
mo...@google.com <mo...@google.com> #6
OK, user error. I was pointing to the wrong library when I was testing. The targetSdk = 35
was the answer. Thanks!
ap...@google.com <ap...@google.com> #7
Branch: androidx-main
commit 39a3db5b65c127043043cd67a773657c931c4188
Author: George Mount <mount@google.com>
Date: Thu Sep 05 14:21:28 2024
Properly support Dialog.dismissOnClickOutside
Fixes: 364508685
The dialog should support dismissing when clicking outside.
This fixes the support when decorFitsSystemWindows = false.
Test: manual testing, new tests
Change-Id: If49301c4fbe826dceaa5680a523c05fc1e95c816
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/window/DialogTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.android.kt
na...@google.com <na...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.8.0-alpha02
androidx.compose.ui:ui-android:1.8.0-alpha02
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha02
Description
Jetpack Compose version: ToT
Related CL:https://android-review.googlesource.com/3202247
Steps to Reproduce or Code Sample to Reproduce:https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/DialogSample.kt;l=33;drc=4d53400eca9f3ac90c3a3f6cffcbc5bf492ec536
Click outside and the dialog won't dismiss.