"Enable compose formatting for modifiers" option formats too much [364549431]

Fixed

Bug

Status Update

No update yet.

Description

l....@gmail.com

created issue #1

Sep 4, 2024 04:34PM

For example this:

BasicText(
    modifier = Modifier
        .clickable {
            input = TestInput(
                key = UUID.randomUUID().toString(),
                obj = SomeClass(),
            )
        }
        .padding(16.dp),
    text = "Update",
)

seems properly formatted. With Enable compose formatting for modifiers this is rewritten to:

BasicText(
    modifier = Modifier
        .clickable {
            input = TestInput(
                key = UUID
                    .randomUUID()
                    .toString(),
                obj = SomeClass(),
            )
        }
        .padding(16.dp),
    text = "Update",
)

I can only assume the intention of the option is to chop down modifiers, not any chain of function calls happening in modifier expression? Otherwise the option is hardly useful, I'd expect non-modifier functions to be kept as-is, not chopped down

Android Studio Ladybug | 2024.2.1 Canary 9
Build #AI-242.20224.300.2421.12293307, built on August 29, 2024
Runtime version: 21.0.3+13-b509.11 amd64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.awt.X11.XToolkit
Linux 6.9.3-76060903-generic
GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation
Memory: 8192M
Cores: 32
Registry:
  ide.allow.split.and.reorder.in.tool.window=false
  debugger.new.tool.window.layout=true
  vcs.non.modal.post.commit.checks=false
  keymap.windows.as.meta=true
  ide.experimental.ui=true
  ide.open.in.split.with.chooser.enabled=true
  ide.images.show.chessboard=true
Non-Bundled Plugins:
  com.intellij.lang.jsgraphql (242.20224.155)
  de.ehmkah.projects.imgdiff (1.11.0)
  String Manipulation (9.14.1)
  com.tabnine.TabNine (1.126.0)
  com.intellij.plugins.macoskeymap (241.13688.16)
  com.github.camork.fileExpander (2.5)
  kotest-plugin-intellij (1.3.13-IC-2024.1.1)
  dev.turingcomplete.intellijdevelopertoolsplugins (5.0.0)
  com.developerphil.adbidea (1.6.18)
  mobi.hsz.idea.gitignore (4.5.3)
Current Desktop: pop:GNOME

Comments

sp...@google.com <sp...@google.com> Sep 5, 2024 01:15AM

Assigned to an...@google.com.

an...@google.com <an...@google.com> #2Sep 6, 2024 07:25PM

Reassigned to an...@google.com.

We don't support cross-process invalidations yet.

an...@google.com <an...@google.com> Sep 9, 2024 03:52PM

Accepted by an...@google.com.

an...@google.com <an...@google.com> #3Sep 10, 2024 06:05PM

Marked as fixed.

At least , add a "refresh all observables" function to alpha4 ? i am trying to implement it by myself with your InvalidationTracker class

an...@google.com <an...@google.com> #4Sep 12, 2024 06:57PM

Okey, I made it and created a method to invalidate all observables below;

private void refreshAllLiveData() {
AppDataBase YOUR_DATABASE_WHICH_YOU_BUILD = .....
SupportSQLiteDatabase writableDatabase = YOUR_DATABASE_WHICH_YOU_BUILD.getOpenHelper().getWritableDatabase();
//get the database count;
Cursor cursor = writableDatabase.query("SELECT count(*) FROM sqlite_master WHERE type = 'table' AND name != 'android_metadata' AND name != 'room_master_table';");
int tableCount = 0;
while(cursor.moveToNext()) {
tableCount = cursor.getInt(0);
}

for (int i = 0; i < tableCount; i++) {
//update version table with the incremented count because room modification log stores tables with ids instead of names
writableDatabase.execSQL("INSERT OR REPLACE INTO room_table_modification_log VALUES(null, "+(i)+")");
}
YOUR_DATABASE_WHICH_YOU_BUILD.getInvalidationTracker().refreshVersionsAsync();
}

-----

This is a workaroud for refreshing all live datas, I still prefer to use a proper API you implemented.

Thanx

Issue 364549431