Error: cannot access KSerializer [364634035]

Fixed

Bug

Status Update

No update yet.

Description

em...@gmail.com

created issue #1

Sep 5, 2024 03:27AM

Component used: Navigation
Version used: 2.8.0
Devices/Android versions reproduced on: Android 11
Previous working version: 2.7.7

Using Navigation 2.7.7 all works fine but when updating to 2.8.0 I get "error: cannot access KSerializer" ("class file for kotlinx.serialization.KSerializer not found") at this line:
- navGraph.(HERE IS THE MARKED POINT)setStartDestination(R.id.nav_permissions)
during "Task :app:compileDebugJavaWithJavac".

This piece of code placed in a MainActivity.onCreate() method:
- NavGraph navGraph = navController.getGraph();
- navGraph.setStartDestination(R.id.nav_permissions)

Those are my TOML libraries versions used in this project:
annotation = "1.8.2"
appcompat = "1.7.0"
constraintlayout = "2.1.4"
flexbox = "3.0.0"
gradle_plugin = "8.6.0"
kotlin = "1.9.24"
livedata = "2.8.5"
material = "1.12.0"
navigation = "2.8.0" (<-- returning to 2.7.7 solves this issue)
preference = "1.2.1"
sdk_compile = "34"
sdk_target = "33"
volley = "1.2.1"

Unfortunately the project is very big and I'm unable to cleanup to create a simple sample project for replicate this error.
I hope it would be enough those info.....

Comments

em...@gmail.com <em...@gmail.com> #2Sep 5, 2024 03:30AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Link: https://android-review.googlesource.com/3350651

Add ability to encode/decode Java and Android types supported by Bundle

Expand for full commit details

Add ability to encode/decode Java and Android types supported by Bundle 
 
Here's a list of types added: 
 
Classes/type aliases: 
 
* SavedState 
* android.util.Size 
* android.util.SizeF 
 
Interfaces: 
 
* CharSequence 
* java.io.Serializable 
* android.os.Parcelable 
* android.os.IBinder 
 
Collections: 
 
* Array<out CharSequence> 
* Array<out android.os.Parcelable> 
* ArrayList<out CharSequence> 
* ArrayList<out android.os.Parcelable> 
* android.util.SparseArray<out android.os.Parcelable> 
 
`SavedState` is supported on all platforms while the other types are supported on Android only. 
 
Bug: 376026712 
Relnote: Add ability to encode/decode Java and Android types supported by Bundle 
Test: SavedStateCodecTest.kt, SavedStateCodecAndroidTest.android.kt 
Change-Id: I8c10fdae09e9e10f7699838439d3f3145af32b36

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/SerializationTest.kt
M savedstate/savedstate-samples/src/main/java/androidx/savedstate/SavedStateCodecSamples.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.android.kt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.android.kt
A savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/serialization/serializers/BuiltInSerializer.android.kt
M savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/SavedStateCodecAndroidTest.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/CodecUtils.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
A savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/serializers/BuiltInSerializer.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTest.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.nonAndroid.kt
A savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.nonAndroid.kt

Hash: 10cfc6b09126010659675d9e887143142458c3ac
Date: Fri Nov 15 16:46:49 2024

jb...@google.com <jb...@google.com> #3Sep 5, 2024 04:52PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Link: https://android-review.googlesource.com/3375273

Open built-in serializers for Interface types

Expand for full commit details

Open built-in serializers for Interface types 
 
Make `CharSequenceSerializer`, `JavaSerializableSerializer`, and `ParcelableSerializer` open generic classes instead of singleton objects so that users can inherit and define serializers for their own subtypes. This can be used to prevent `SERIALIZER_TYPE_INCOMPATIBLE` lint warning. For example, instead of suppressing the warning like this: 
 
``` 
@Serializable 
data class CharSequenceContainer( 
    @Suppress("SERIALIZER_TYPE_INCOMPATIBLE") 
    @Serializable(with = CharSequenceSerializer::class) 
    val value: String 
) 
``` 
 
Users can do: 
 
``` 
class StringAsCharSequenceSerializer : CharSequenceSerializer<String>() 
 
@Serializable 
data class CharSequenceContainer( 
    @Serializable(with = StringAsCharSequenceSerializer::class) 
    val value: String 
) 
``` 
 
The serializers can also be used directly with subclasses. For example, users can now write: 
 
``` 
encodeToSavedState(serializer = CharSequenceSerializer(), value = "foo") 
``` 
 
Since CharSequenceSerializer is now generic, it works with value `foo` even though it has a static type of String. 
 
We also made some changes to all the built-in serializers: 
 
- Changeed all built-in serializers from singleton objects to classes so that they're consistent with `CharSequenceSerializer`, `JavaSerializableSerializer`, and `ParcelableSerializer`. 
 
- Moved the actual `getXXX()`/`putXXX()` from `platformSpecificEncodeSerializableValue`/`platformSpecificDecodeSerializableValue` to `serialize()`/`deserialize()` functions of these serializers. This way we don't require special logic in `SavedStateEncoder.encodeSerializableValue()`/`SavedStateDecoder.decodeSerializableValue()`. 
 
Relnote: Open built-in serializers for Interface types 
Bug: 376026712 
Test: SavedStateCodecAndroidTest 
Change-Id: I28caf279b53cb69311c861e415390da7efd90c40

Files:

M savedstate/savedstate-samples/src/main/java/androidx/savedstate/SavedStateCodecSamples.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
D savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.android.kt
D savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.android.kt
M savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/serialization/serializers/BuiltInSerializer.android.kt
M savedstate/savedstate/src/androidUnitTest/kotlin/androidx/savedstate/SavedStateCodecAndroidTest.android.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/serializers/BuiltInSerializer.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTest.kt
D savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.nonAndroid.kt
D savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.nonAndroid.kt

Hash: dc358bcbe19b08a8358916297a549f0583ccd790
Date: Tue Nov 26 13:09:44 2024

em...@gmail.com <em...@gmail.com> #4Sep 5, 2024 05:17PM

Thx for the tip but I'm using Java not Kotlin so Named Arguments/Parameters are not available.

jb...@google.com <jb...@google.com> #5Sep 9, 2024 03:52AM

Please provide a minimal sample project that reproduces this issue.

si...@gmail.com <si...@gmail.com> #6Sep 23, 2024 07:33AM

We have the same issue, the previously (2.7.7) working code does not compile with the update to 2.8.1

NavGraph navGraph = navigationController.getNavInflater().inflate(R.navigation.nav_graph);
navGraph.setStartDestination(R.id.alternative_start_destination);
navigationController.setGraph(navGraph);

jb...@google.com <jb...@google.com> #7Sep 23, 2024 02:32PM

Do you have a sample project so we can reproduce the issue?

me...@gmail.com <me...@gmail.com> #8Sep 26, 2024 06:33AM

Same issue.

I am using Android Studio Koala Feature Drop | 2024.1.2 Patch 1, com.android.tools.build:gradle:8.6.1

I agreed the code provided in #6 are the key to the reproduce the case.

em...@gmail.com <em...@gmail.com> #9Sep 26, 2024 06:39AM

I suppose they're looking for a complete Android Studio project/solution to reploduce this issue.
Unfortunately my project is very big and it would take days of work to clean up to get an "empty and dumb container".

The code at #6 works in a new project created from scratch, so the issue should be elsewhere.

da...@gmail.com <da...@gmail.com> #10Sep 29, 2024 08:37PM

I managed to resolve this by adding the following to my apps build.gradle:

implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3'

il...@google.com <il...@google.com> #11Sep 29, 2024 11:31PM

Re comment#10 - please include a sample project that reproduces the issue!

si...@gmail.com <si...@gmail.com> #12Oct 28, 2024 07:15AM

Adding implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3' also fixes the build for me

sa...@gmail.com <sa...@gmail.com> #13Nov 25, 2024 08:45AM

comment#11

Hi, I added a sample project.
I also confirm that by manually importing
kotlinx-serialization-json (version 1.7.3 as an example), the compilation ends successfully.

in this project i am using 2.8.4, but it still reproduces.
The problem is definitely on the overload of the setStartDestination method which uses the generic T method, instead of the specific int

Message last modified on Nov 25, 2024 09:01AM

Kserialize-sample.zip

123 KB

Download

jb...@google.com <jb...@google.com> Nov 25, 2024 04:31PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #14Nov 29, 2024 12:28AM

Accepted by cl...@google.com.

Yup java is pulling in the wrong overload

ap...@google.com <ap...@google.com> #15Dec 2, 2024 08:55PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3383388

Fix wrong setStartDestination overload in Java

Expand for full commit details

Fix wrong setStartDestination overload in Java 
 
Java compiler links to the wrong NavGraph.setStartDestination overload which takes a `startDestination: T` instead of the correct `startDestination: Int`. 
 
The overload that takes `T` is part of the Navigation SafeArgs features for kotlin users, so we hide this overload from Java sources with @JvmSynthetic. 
This annotation is binary compatible. https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.jvm/-jvm-synthetic/ 
 
Test: manual testing 
Bug: 364634035 
Relnote: "The kotlin-specific NavGraph.setStartDestination overload for type safety is hidden from Java sources." 
Change-Id: Ic640c37f3cef5578022866529a8e576eba8d745d

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt

Hash: ca3ba4e8cad00096390024507b7db28bbe6e2ed5
Date: Thu Nov 28 16:38:58 2024

cl...@google.com <cl...@google.com> #16Dec 2, 2024 09:42PM

Marked as fixed.

Fixed and available in navigation-2.9.0-alpha04

Message last modified on Dec 2, 2024 10:29PM

da...@gmail.com <da...@gmail.com> #17Dec 2, 2024 10:19PM

I have tried this fix by using navigation-2.9.0-alpha03 and removed the temp fix of implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3' however the same error has returned during build:

"class file for kotlinx.serialization.KSerializer not found"

The build is successful when retaining implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3'

Is this expected, or is there perhaps something else I'm not doing?

cl...@google.com <cl...@google.com> #18Dec 2, 2024 10:30PM

Typo - it is available in navigation-2.9.0-alpha04.

te...@gmail.com <te...@gmail.com> #19Dec 6, 2024 06:15AM

Adding implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3' also fixes the build for me

pr...@google.com <pr...@google.com> #20Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.9.0-alpha04

da...@gmail.com <da...@gmail.com> #21Dec 17, 2024 10:00PM

I've tested with the proposed fix and can confirm this is resolved for me.

Issue 364634035

Description

Issue summary

Comments

em...@gmail.com <em...@gmail.com> #2Sep 5, 2024 03:30AM

jb...@google.com <jb...@google.com> #3Sep 5, 2024 04:52PM

em...@gmail.com <em...@gmail.com> #4Sep 5, 2024 05:17PM

jb...@google.com <jb...@google.com> #5Sep 9, 2024 03:52AM

si...@gmail.com <si...@gmail.com> #6Sep 23, 2024 07:33AM

jb...@google.com <jb...@google.com> #7Sep 23, 2024 02:32PM

me...@gmail.com <me...@gmail.com> #8Sep 26, 2024 06:33AM

em...@gmail.com <em...@gmail.com> #9Sep 26, 2024 06:39AM

da...@gmail.com <da...@gmail.com> #10Sep 29, 2024 08:37PM

il...@google.com <il...@google.com> #11Sep 29, 2024 11:31PM

si...@gmail.com <si...@gmail.com> #12Oct 28, 2024 07:15AM

sa...@gmail.com <sa...@gmail.com> #13Nov 25, 2024 08:45AM

jb...@google.com <jb...@google.com> Nov 25, 2024 04:31PM

cl...@google.com <cl...@google.com> #14Nov 29, 2024 12:28AM

ap...@google.com <ap...@google.com> #15Dec 2, 2024 08:55PM

cl...@google.com <cl...@google.com> #16Dec 2, 2024 09:42PM

da...@gmail.com <da...@gmail.com> #17Dec 2, 2024 10:19PM

cl...@google.com <cl...@google.com> #18Dec 2, 2024 10:30PM

te...@gmail.com <te...@gmail.com> #19Dec 6, 2024 06:15AM

pr...@google.com <pr...@google.com> #20Dec 11, 2024 06:27PM

da...@gmail.com <da...@gmail.com> #21Dec 17, 2024 10:00PM

Add comment

Issue metadata