Error: cannot access KSerializer [364634035]

Fixed

Bug

Status Update

No update yet.

Description

em...@gmail.com

created issue #1

Sep 5, 2024 03:27AM

Component used: Navigation
Version used: 2.8.0
Devices/Android versions reproduced on: Android 11
Previous working version: 2.7.7

Using Navigation 2.7.7 all works fine but when updating to 2.8.0 I get "error: cannot access KSerializer" ("class file for kotlinx.serialization.KSerializer not found") at this line:
- navGraph.(HERE IS THE MARKED POINT)setStartDestination(R.id.nav_permissions)
during "Task :app:compileDebugJavaWithJavac".

This piece of code placed in a MainActivity.onCreate() method:
- NavGraph navGraph = navController.getGraph();
- navGraph.setStartDestination(R.id.nav_permissions)

Those are my TOML libraries versions used in this project:
annotation = "1.8.2"
appcompat = "1.7.0"
constraintlayout = "2.1.4"
flexbox = "3.0.0"
gradle_plugin = "8.6.0"
kotlin = "1.9.24"
livedata = "2.8.5"
material = "1.12.0"
navigation = "2.8.0" (<-- returning to 2.7.7 solves this issue)
preference = "1.2.1"
sdk_compile = "34"
sdk_target = "33"
volley = "1.2.1"

Unfortunately the project is very big and I'm unable to cleanup to create a simple sample project for replicate this error.
I hope it would be enough those info.....

Comments

em...@gmail.com <em...@gmail.com> #2Sep 5, 2024 03:30AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> #3Sep 5, 2024 04:52PM

It seems like the code is conflicting with the new type safe navigation APIs. It should resolve if you use named parameters to ensure the proper setStartDestination function is being used.

em...@gmail.com <em...@gmail.com> #4Sep 5, 2024 05:17PM

Thx for the tip but I'm using Java not Kotlin so Named Arguments/Parameters are not available.

jb...@google.com <jb...@google.com> #5Sep 9, 2024 03:52AM

Please provide a minimal sample project that reproduces this issue.

si...@gmail.com <si...@gmail.com> #6Sep 23, 2024 07:33AM

We have the same issue, the previously (2.7.7) working code does not compile with the update to 2.8.1

NavGraph navGraph = navigationController.getNavInflater().inflate(R.navigation.nav_graph);
navGraph.setStartDestination(R.id.alternative_start_destination);
navigationController.setGraph(navGraph);

jb...@google.com <jb...@google.com> #7Sep 23, 2024 02:32PM

Do you have a sample project so we can reproduce the issue?

me...@gmail.com <me...@gmail.com> #8Sep 26, 2024 06:33AM

Same issue.

I am using Android Studio Koala Feature Drop | 2024.1.2 Patch 1, com.android.tools.build:gradle:8.6.1

I agreed the code provided in #6 are the key to the reproduce the case.

em...@gmail.com <em...@gmail.com> #9Sep 26, 2024 06:39AM

I suppose they're looking for a complete Android Studio project/solution to reploduce this issue.
Unfortunately my project is very big and it would take days of work to clean up to get an "empty and dumb container".

The code at #6 works in a new project created from scratch, so the issue should be elsewhere.

da...@gmail.com <da...@gmail.com> #10Sep 29, 2024 08:37PM

I managed to resolve this by adding the following to my apps build.gradle:

implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3'

il...@google.com <il...@google.com> #11Sep 29, 2024 11:31PM

Re comment#10 - please include a sample project that reproduces the issue!

si...@gmail.com <si...@gmail.com> #12Oct 28, 2024 07:15AM

Adding implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3' also fixes the build for me

sa...@gmail.com <sa...@gmail.com> #13Nov 25, 2024 08:45AM

comment#11

Hi, I added a sample project.
I also confirm that by manually importing
kotlinx-serialization-json (version 1.7.3 as an example), the compilation ends successfully.

in this project i am using 2.8.4, but it still reproduces.
The problem is definitely on the overload of the setStartDestination method which uses the generic T method, instead of the specific int

Message last modified on Nov 25, 2024 09:01AM

Kserialize-sample.zip

123 KB

Download

jb...@google.com <jb...@google.com> Nov 25, 2024 04:31PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #14Nov 29, 2024 12:28AM

Accepted by cl...@google.com.

Yup java is pulling in the wrong overload

ap...@google.com <ap...@google.com> #15Dec 2, 2024 08:55PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3383388

Fix wrong setStartDestination overload in Java

Expand for full commit details

Fix wrong setStartDestination overload in Java 
 
Java compiler links to the wrong NavGraph.setStartDestination overload which takes a `startDestination: T` instead of the correct `startDestination: Int`. 
 
The overload that takes `T` is part of the Navigation SafeArgs features for kotlin users, so we hide this overload from Java sources with @JvmSynthetic. 
This annotation is binary compatible. https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.jvm/-jvm-synthetic/ 
 
Test: manual testing 
Bug: 364634035 
Relnote: "The kotlin-specific NavGraph.setStartDestination overload for type safety is hidden from Java sources." 
Change-Id: Ic640c37f3cef5578022866529a8e576eba8d745d

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt

Hash: ca3ba4e8cad00096390024507b7db28bbe6e2ed5
Date: Thu Nov 28 16:38:58 2024

cl...@google.com <cl...@google.com> #16Dec 2, 2024 09:42PM

Marked as fixed.

Fixed and available in navigation-2.9.0-alpha04

Message last modified on Dec 2, 2024 10:29PM

da...@gmail.com <da...@gmail.com> #17Dec 2, 2024 10:19PM

I have tried this fix by using navigation-2.9.0-alpha03 and removed the temp fix of implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3' however the same error has returned during build:

"class file for kotlinx.serialization.KSerializer not found"

The build is successful when retaining implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3'

Is this expected, or is there perhaps something else I'm not doing?

cl...@google.com <cl...@google.com> #18Dec 2, 2024 10:30PM

Typo - it is available in navigation-2.9.0-alpha04.

te...@gmail.com <te...@gmail.com> #19Dec 6, 2024 06:15AM