Status Update
No update yet.
Comments
em...@gmail.com
jb...@google.com
since it is already marked as deprecated, we can probably do it by now.
em...@gmail.com
jb...@google.com
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
si...@gmail.com
NavGraph navGraph = navigationController.getNavInflater().inflate(R.navigation.nav_graph);
navGraph.setStartDestination(R.id.alternative_start_destination);
navigationController.setGraph(navGraph);
jb...@google.com
Do you have a sample project so we can reproduce the issue?
me...@gmail.com
Same issue.
I am using Android Studio Koala Feature Drop | 2024.1.2 Patch 1, com.android.tools.build:gradle:8.6.1
I agreed the code provided in #6 are the key to the reproduce the case.
em...@gmail.com
Unfortunately my project is very big and it would take days of work to clean up to get an "empty and dumb container".
The code at #6 works in a new project created from scratch, so the issue should be elsewhere.
da...@gmail.com
implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3'
il...@google.com
Re
si...@gmail.com
sa...@gmail.com
Hi, I added a sample project.
I also confirm that by manually importing
kotlinx-serialization-json (version 1.7.3 as an example), the compilation ends successfully.
in this project i am using 2.8.4, but it still reproduces.
The problem is definitely on the overload of the setStartDestination method which uses the generic T method, instead of the specific int
jb...@google.com
cl...@google.com
Yup java is pulling in the
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Fix wrong setStartDestination overload in Java
Expand for full commit details
Fix wrong setStartDestination overload in Java
Java compiler links to the wrong NavGraph.setStartDestination overload which takes a `startDestination: T` instead of the correct `startDestination: Int`.
The overload that takes `T` is part of the Navigation SafeArgs features for kotlin users, so we hide this overload from Java sources with @JvmSynthetic.
This annotation is binary compatible. https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.jvm/-jvm-synthetic/
Test: manual testing
Bug: 364634035
Relnote: "The kotlin-specific NavGraph.setStartDestination overload for type safety is hidden from Java sources."
Change-Id: Ic640c37f3cef5578022866529a8e576eba8d745d
Files:
- M
navigation/navigation-common/api/current.txt - M
navigation/navigation-common/api/restricted_current.txt - M
navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
Hash: ca3ba4e8cad00096390024507b7db28bbe6e2ed5
Date: Thu Nov 28 16:38:58 2024
cl...@google.com
Fixed and available in navigation-2.9.0-alpha04
da...@gmail.com
I have tried this fix by using navigation-2.9.0-alpha03 and removed the temp fix of implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3' however the same error has returned during build:
"class file for kotlinx.serialization.KSerializer not found"
The build is successful when retaining implementation 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3'
Is this expected, or is there perhaps something else I'm not doing?
cl...@google.com
Typo - it is available in navigation-2.9.0-alpha04.
te...@gmail.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.9.0-alpha04
da...@gmail.com
I've tested with the proposed fix and can confirm this is resolved for me.
Description
Version used: 2.8.0
Devices/Android versions reproduced on: Android 11
Previous working version: 2.7.7
Using Navigation 2.7.7 all works fine but when updating to 2.8.0 I get "error: cannot access KSerializer" ("class file for kotlinx.serialization.KSerializer not found") at this line:
- navGraph.(HERE IS THE MARKED POINT)setStartDestination(R.id.nav_permissions)
during "Task :app:compileDebugJavaWithJavac".
This piece of code placed in a MainActivity.onCreate() method:
- NavGraph navGraph = navController.getGraph();
- navGraph.setStartDestination(R.id.nav_permissions)
Those are my TOML libraries versions used in this project:
annotation = "1.8.2"
appcompat = "1.7.0"
constraintlayout = "2.1.4"
flexbox = "3.0.0"
gradle_plugin = "8.6.0"
kotlin = "1.9.24"
livedata = "2.8.5"
material = "1.12.0"
navigation = "2.8.0" (<-- returning to 2.7.7 solves this issue)
preference = "1.2.1"
sdk_compile = "34"
sdk_target = "33"
volley = "1.2.1"
Unfortunately the project is very big and I'm unable to cleanup to create a simple sample project for replicate this error.
I hope it would be enough those info.....