Fixed
Status Update
No update yet.
Comments
al...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
au...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
au...@google.com
annotation 1.9.0-beta01 should ship tomorrow that has this new target. This will allow us to ship other libraries that add this target.
ga...@gmail.com
Thank you for starting to add the target so quickly
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Enable watchosDeviceArm64 by default for watchos
Expand for full commit details
Enable watchosDeviceArm64 by default for watchos
Relnote: Adds support for watchosDeviceArm64 KMP target and target kotlin 1.9
Test: None
Bug: 364652024
Change-Id: Icf15d056ce2380ca3c733fb1a93fd502f60b40e4
Files:
- M
annotation/annotation/build.gradle - M
buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt - M
collection/collection/build.gradle - M
datastore/datastore-core-okio/bcv/native/current.txt - M
datastore/datastore-core/bcv/native/current.txt - M
datastore/datastore-core/build.gradle - M
datastore/datastore-preferences-core/bcv/native/current.txt - M
datastore/datastore-preferences/bcv/native/current.txt - M
datastore/datastore/bcv/native/current.txt - M
datastore/datastore/build.gradle - M
graphics/graphics-core/build.gradle - M
graphics/graphics-core/samples/build.gradle - M
graphics/graphics-shapes/bcv/native/current.txt - M
graphics/graphics-shapes/build.gradle - M
kruth/kruth/build.gradle - M
paging/paging-common/bcv/native/current.txt - M
paging/paging-common/build.gradle - M
paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt - M
paging/paging-common/src/nativeMain/kotlin/androidx/paging/internal/Atomics.native.kt - M
paging/paging-compose/build.gradle - M
paging/paging-compose/samples/build.gradle - M
paging/paging-guava/build.gradle - M
paging/paging-runtime/build.gradle - M
paging/paging-rxjava2-ktx/build.gradle - M
paging/paging-rxjava2/build.gradle - M
paging/paging-rxjava3/build.gradle - M
paging/paging-testing/bcv/native/current.txt - M
paging/paging-testing/build.gradle - M
performance/performance-annotation/build.gradle - M
window/window-core/build.gradle - M
window/window-java/build.gradle - M
window/window-rxjava2/build.gradle - M
window/window-rxjava3/build.gradle - M
window/window-testing/build.gradle - M
window/window/build.gradle - M
window/window/samples/build.gradle
Hash: 73b142a6314f2b249433355700473f3c459184d7
Date: Fri Nov 01 11:16:28 2024
au...@google.com
Fixed at head, we now just need to wait for these library to do the next release.
ga...@gmail.com
Thanks again for addressing this
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.5.0-beta01androidx.collection:collection-iosarm64:1.5.0-beta01androidx.collection:collection-iossimulatorarm64:1.5.0-beta01androidx.collection:collection-iosx64:1.5.0-beta01androidx.collection:collection-js:1.5.0-beta01androidx.collection:collection-jvm:1.5.0-beta01androidx.collection:collection-linuxarm64:1.5.0-beta01androidx.collection:collection-linuxx64:1.5.0-beta01androidx.collection:collection-macosarm64:1.5.0-beta01androidx.collection:collection-macosx64:1.5.0-beta01androidx.collection:collection-mingwx64:1.5.0-beta01androidx.collection:collection-tvosarm64:1.5.0-beta01androidx.collection:collection-tvossimulatorarm64:1.5.0-beta01androidx.collection:collection-tvosx64:1.5.0-beta01androidx.collection:collection-wasm-js:1.5.0-beta01androidx.collection:collection-watchosarm32:1.5.0-beta01androidx.collection:collection-watchosarm64:1.5.0-beta01androidx.collection:collection-watchosdevicearm64:1.5.0-beta01androidx.collection:collection-watchossimulatorarm64:1.5.0-beta01androidx.collection:collection-watchosx64:1.5.0-beta01androidx.graphics:graphics-shapes:1.1.0-alpha01androidx.graphics:graphics-shapes-android:1.1.0-alpha01androidx.graphics:graphics-shapes-desktop:1.1.0-alpha01androidx.graphics:graphics-shapes-iosarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-iossimulatorarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-iosx64:1.1.0-alpha01androidx.graphics:graphics-shapes-linuxarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-linuxx64:1.1.0-alpha01androidx.graphics:graphics-shapes-macosarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-macosx64:1.1.0-alpha01androidx.graphics:graphics-shapes-tvosarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-tvossimulatorarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-tvosx64:1.1.0-alpha01androidx.graphics:graphics-shapes-watchosarm32:1.1.0-alpha01androidx.graphics:graphics-shapes-watchosarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-watchossimulatorarm64:1.1.0-alpha01androidx.graphics:graphics-shapes-watchosx64:1.1.0-alpha01
th...@gmail.com
Can you please release a new version of datastore? The last release was more than half a year ago so it does not contain the fix.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.window:window:1.4.0-beta01androidx.window:window-core:1.4.0-beta01androidx.window:window-core-android:1.4.0-beta01androidx.window:window-core-iosarm64:1.4.0-beta01androidx.window:window-core-iossimulatorarm64:1.4.0-beta01androidx.window:window-core-iosx64:1.4.0-beta01androidx.window:window-core-jvm:1.4.0-beta01androidx.window:window-core-linuxarm64:1.4.0-beta01androidx.window:window-core-linuxx64:1.4.0-beta01androidx.window:window-core-macosarm64:1.4.0-beta01androidx.window:window-core-macosx64:1.4.0-beta01androidx.window:window-core-tvosarm64:1.4.0-beta01androidx.window:window-core-tvossimulatorarm64:1.4.0-beta01androidx.window:window-core-tvosx64:1.4.0-beta01androidx.window:window-core-watchosarm32:1.4.0-beta01androidx.window:window-core-watchosarm64:1.4.0-beta01androidx.window:window-core-watchossimulatorarm64:1.4.0-beta01androidx.window:window-core-watchosx64:1.4.0-beta01androidx.window:window-java:1.4.0-beta01androidx.window:window-rxjava2:1.4.0-beta01androidx.window:window-rxjava3:1.4.0-beta01androidx.window:window-testing:1.4.0-beta01
Description
Currently the androidx multiplatform libraries that support watchOS have
watchosSimulatorArm64,watchosX64,watchosArm32,watchosArm64as targets. However there is one more target available,watchosDeviceArm64. This target usesarm64as architecture opposed toarm64_32which is provided bywatchosArm64.