Fixed
Status Update
No update yet.
Comments
di...@google.com
The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.
ap...@google.com
The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.
Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.
na...@google.com
Hi Nona,
Can you please schedule a release after you merge the fix?
Description
The
computeWindowSizeClassmethods currently take integer values, but it would be better if they took floating point values.Window sizes are often non-integer values, so by accepting integers, it requires the user of the API to correctly perform rounding on their own before calling this method.