Status Update
Comments
di...@google.com <di...@google.com> #2
Attached reproducing video of an app using calculateWindowSizeClass
and LocalConfiguration
:
On the second time resizing to be 50%/50% from smaller, the displayed configuration is incorrect.
ap...@google.com <ap...@google.com> #3
When resizing the activity in multi-window mode under those conditions, there are cases where:
the Activity is not recreated Activity.onConfigurationChanged is not called View.onConfigurationChanged is not called
Is this just for 33 / is there a framework bug filed? The amount of broken things in configuration land we already had to workaround in Compose is a bit untenable. It seems like we are missing a lot of test coverage in the platform to avoid these issues hitting us in the future
na...@google.com <na...@google.com> #4
In any case this seems like more ammunition for us to push more strongly on 'pure-compose apps should always opt out of configuration changes'
Description
The current computation of
BREAKPOINTS_V1
means thatBREAKPOINTS_V1
is equivalent to:When directly used with
Set<WindowSizeClass>.computeWindowSizeClass
, this will result in never computing a window size class ofWindowSizeClass(0, 480)
,WindowSizeClass(0, 900)
,WindowSizeClass(600, 0)
orWindowSizeClass(840, 0)
.The full computed set should be:
if we leave out
WindowSizeClass(0, 0)
as the special case.