Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 81c4622e99c7b3571140339fab87c92273abe92a
Author: Diego Vela <diegovela@google.com>
Date: Wed Sep 04 20:41:19 2024
Fix bugs for window library.
Update deprecation message for compute and add ReplaceWith block.
Add overload for comuting WindowSizeClass using floats.
Add missing breakpoints from BREAKPOINTS_V1.
Relnote: Add overload to computeWindowSizeClass using floats.
Bug: 364677934
Bug: 364677802
Bug: 364680886
Test: ./gradlew window:window-core:test
Change-Id: I3dcb254105a286b2edaa38f7be453be024a0a7e4
M window/window-core/api/current.txt
M window/window-core/api/restricted_current.txt
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClass.kt
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClassSelectors.kt
M window/window-core/src/commonTest/kotlin/androidx/window/core/layout/WindowSizeClassSelectorsTest.kt
M window/window-core/src/commonTest/kotlin/androidx/window/core/layout/WindowSizeClassTest.kt
https://android-review.googlesource.com/3255560
Branch: androidx-main
commit 81c4622e99c7b3571140339fab87c92273abe92a
Author: Diego Vela <diegovela@google.com>
Date: Wed Sep 04 20:41:19 2024
Fix bugs for window library.
Update deprecation message for compute and add ReplaceWith block.
Add overload for comuting WindowSizeClass using floats.
Add missing breakpoints from BREAKPOINTS_V1.
Relnote: Add overload to computeWindowSizeClass using floats.
Bug: 364677934
Bug: 364677802
Bug: 364680886
Test: ./gradlew window:window-core:test
Change-Id: I3dcb254105a286b2edaa38f7be453be024a0a7e4
M window/window-core/api/current.txt
M window/window-core/api/restricted_current.txt
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClass.kt
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClassSelectors.kt
M window/window-core/src/commonTest/kotlin/androidx/window/core/layout/WindowSizeClassSelectorsTest.kt
M window/window-core/src/commonTest/kotlin/androidx/window/core/layout/WindowSizeClassTest.kt
na...@google.com <na...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.window:window-core:1.4.0-alpha03
androidx.window:window-core-android:1.4.0-alpha03
androidx.window:window-core-iosarm64:1.4.0-alpha03
androidx.window:window-core-iossimulatorarm64:1.4.0-alpha03
androidx.window:window-core-iosx64:1.4.0-alpha03
androidx.window:window-core-jvm:1.4.0-alpha03
androidx.window:window-core-linuxarm64:1.4.0-alpha03
androidx.window:window-core-linuxx64:1.4.0-alpha03
androidx.window:window-core-macosarm64:1.4.0-alpha03
androidx.window:window-core-macosx64:1.4.0-alpha03
androidx.window:window-core-tvosarm64:1.4.0-alpha03
androidx.window:window-core-tvossimulatorarm64:1.4.0-alpha03
androidx.window:window-core-tvosx64:1.4.0-alpha03
androidx.window:window-core-watchosarm32:1.4.0-alpha03
androidx.window:window-core-watchosarm64:1.4.0-alpha03
androidx.window:window-core-watchossimulatorarm64:1.4.0-alpha03
androidx.window:window-core-watchosx64:1.4.0-alpha03
Description
The current computation of
BREAKPOINTS_V1
means thatBREAKPOINTS_V1
is equivalent to:When directly used with
Set<WindowSizeClass>.computeWindowSizeClass
, this will result in never computing a window size class ofWindowSizeClass(0, 480)
,WindowSizeClass(0, 900)
,WindowSizeClass(600, 0)
orWindowSizeClass(840, 0)
.The full computed set should be:
if we leave out
WindowSizeClass(0, 0)
as the special case.