Fixed
Status Update
Comments
di...@google.com <di...@google.com> #2
The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.
ap...@google.com <ap...@google.com> #3
The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.
Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.
na...@google.com <na...@google.com> #4
Hi Nona,
Can you please schedule a release after you merge the fix?
Description
The current computation of
BREAKPOINTS_V1
means thatBREAKPOINTS_V1
is equivalent to:When directly used with
Set<WindowSizeClass>.computeWindowSizeClass
, this will result in never computing a window size class ofWindowSizeClass(0, 480)
,WindowSizeClass(0, 900)
,WindowSizeClass(600, 0)
orWindowSizeClass(840, 0)
.The full computed set should be:
if we leave out
WindowSizeClass(0, 0)
as the special case.