Multiple back button presses (popBackStack in quick succession) cause crash "IllegalStateException: setCurrentPlayTimeMillis() called after animation has been started" [364804225]

Fixed

Bug

Status Update

No update yet.

Description

kr...@gmail.com

created issue #1

Sep 5, 2024 02:53PM

Component used: Fragment

Version used:

activity = "1.9.2"
fragment = "1.8.3"
transition = "1.5.1"

Devices/Android versions reproduced on:

Android 14 / Pixel 8

(this was already marked as fixed in https://issuetracker.google.com/issues/338624457, but the crash still exists in the latest library versions)

You can find a minimal sample repo here: https://github.com/kroegerama/android-fragment-crash-sample

Setup in fragment:

[...]
import androidx.transition.Fade
[...]

override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    enterTransition = Fade().setDuration(600)
    exitTransition = Fade().setDuration(600)
}

I'm getting this crash, when I navigate forward multiple times (navigate(FragFooDirections.actionFooBar())) and then repeatedly in quick succession use the back gesture or back button (popBackStack()).

java.lang.IllegalStateException: setCurrentPlayTimeMillis() called after animation has been started
	at androidx.transition.Transition$SeekController.setCurrentPlayTimeMillis(Transition.java:2789)
	at androidx.transition.FragmentTransitionSupport.setCurrentPlayTime(FragmentTransitionSupport.java:265)
	at androidx.fragment.app.DefaultSpecialEffectsController$TransitionEffect.onProgress(DefaultSpecialEffectsController.kt:817)
	at androidx.fragment.app.SpecialEffectsController.processProgress(SpecialEffectsController.kt:442)
	at androidx.fragment.app.FragmentManager$1.handleOnBackProgressed(FragmentManager.java:554)
	at androidx.activity.OnBackPressedDispatcher.onBackProgressed(OnBackPressedDispatcher.kt:258)
	at androidx.activity.OnBackPressedDispatcher.access$onBackProgressed(OnBackPressedDispatcher.kt:63)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:129)
	at androidx.activity.OnBackPressedDispatcher$2.invoke(OnBackPressedDispatcher.kt:127)
	at androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1.onBackProgressed(OnBackPressedDispatcher.kt:391)
	at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper$$ExternalSyntheticLambda4.onProgressUpdate(D8$$SyntheticClass:0)
	at android.window.BackProgressAnimator.updateProgressValue(BackProgressAnimator.java:167)
	at android.window.BackProgressAnimator.-$$Nest$mupdateProgressValue(Unknown Source:0)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:70)
	at android.window.BackProgressAnimator$1.setValue(BackProgressAnimator.java:66)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.setPropertyValue(DynamicAnimation.java:731)
	at com.android.internal.dynamicanimation.animation.DynamicAnimation.doAnimationFrame(DynamicAnimation.java:687)
	at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:344)
	at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0)
	at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:87)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1404)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1415)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1015)
	at android.view.Choreographer.doFrame(Choreographer.java:941)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1389)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8592)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

Comments

kr...@gmail.com <kr...@gmail.com> #2Sep 6, 2024 08:20AM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ap...@google.com <ap...@google.com> #3Sep 13, 2024 11:03PM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

jb...@google.com <jb...@google.com> #4Sep 16, 2024 04:23PM

Marked as fixed, reassigned to jb...@google.com.

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

pr...@google.com <pr...@google.com> #5Oct 2, 2024 05:37PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

kr...@gmail.com <kr...@gmail.com> #6Oct 2, 2024 07:08PM

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.

pr...@google.com <pr...@google.com> #7Dec 11, 2024 06:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 567b7459329d1ec8d27a8c6fe1c4a86442065d7d
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 26 20:06:54 2023

Add additional logging for transitions

Adding more debug logging in transitions to track the entering and
exiting transitions as well as the final merged transition and its
targets.

Test: added logging
Bug: 300157785
Change-Id: I0d9ad72b865422493c6c895ddb6115abf85eed16

M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt

https://android-review.googlesource.com/2763868

Issue 364804225