IssueTracker

Thinking through options.

Here's my assumptions:

1. We need to find one way or another to upgrade AGP because waiting a few release cycles for the libraries with lint checks is not really viable.
2. We can't enable the bytecode verifier without breaking loading the AIDL lexer
3. We can't update the published lint checks to use the new analysis API immediately because the checks will start breaking in previous AGP versions.
4. We can update our internal non-published lint checks to the new API.

Could we potentially update all our internal lint checks, manually disable the problematic published checks in AndroidX plugin, and temporarily duplicate them to internal checks with the new API so we can continue running those checks until we are able to update them?

We can't enable the bytecode verifier without breaking loading the AIDL lexer

Our AIDL lexer? If so, I'm open to the argument that implementing the Stable AIDL linter and hacking together the lexer was a bad idea and I never should have done it.

manually disable the problematic published checks in AndroidX plugin

The Stable AIDL linter isn't published, fortunately. What are the other problematic checks?

We can't update the published lint checks to use the new analysis API immediately because the checks will start breaking in previous AGP versions.

AGP / Lint team needs to tell us how to handle this cleanly.

Our AIDL lexer? If so, I'm open to the argument that implementing the Stable AIDL linter and hacking together the lexer was a bad idea and I never should have done it.

Yep ours. Or more specifically I'm assuming we can't re-enable the bytecode validator. If we can that's the easiest thing to do. I was under the impression we needed it disabled was for AIDL lexer.

What are the other problematic checks?

The checks that will break when we update if we don't either update them or enable the bytecode verifier are:

LambdaStructuralEquality
UnnecessaryLambdaCreation
AutoboxingStateCreation
MutableCollectionMutableState
ModifierFactoryExtensionFunction
ModifierFactoryReturnType
ModifierFactoryUnreferencedReceiver
ReturnFromAwaitPointerEventScope
SuspiciousModifierThen
NullSafeMutableLiveData

I was under the impression we needed it disabled was for AIDL lexer.

Yeah, that's accurate. It references all sorts of stuff that it probably shouldn't be referencing.

I'm okay with disabling the Stable AIDL lint check if it's a blocker.

I went to look for the Stable AIDL lint check and found that we removed it about a year ago. Are we still pulling in the AIDL lexer somewhere?