[CHIPS] Add API to configure CHIPS [364904765]

Fixed

Task

Status Update

No update yet.

Description

be...@chromium.org

created issue #1

Sep 6, 2024 08:49AM

We should add an API to allow Android developers to configure CHIPS globally. We are going to do this with ProcessGlobalConfig.

Design: go/chips-android-apis-webview

Comments

ap...@google.com <ap...@google.com> #2Sep 12, 2024 04:20PM

Thank you for your feedback. Team may reach out for more feedback in reproducing or triaging this issue.

av...@google.com <av...@google.com> Nov 8, 2024 07:15PM

Accepted by av...@google.com.

av...@google.com <av...@google.com> #3Nov 13, 2024 05:34PM

Dev notes:

* Add a <variable> to a data binding XML file (e.g. activity_main.xml)
* Build project, generating code, e.g. ActivityMainBinding
* Code completion in Kotlin finds the generated code first (fine so far)
* Add a second <variable> to the data binding XML file
* Do NOT build the project
* Code completion in Kotlin refers to the stale generated code file

av...@google.com <av...@google.com> #4Nov 18, 2024 09:18PM

Hey Roar, the fix for this should land in Canary 11.

ap...@google.com <ap...@google.com> #5Nov 21, 2024 05:44PM

Thanx! Love u!

RG

ap...@google.com <ap...@google.com> #6Dec 17, 2024 11:27PM

Anything for you, Roar! Have a nice day :)

ap...@google.com <ap...@google.com> #7Dec 20, 2024 07:55PM

eagerly waiting for canary 11.

ap...@google.com <ap...@google.com> #8Jan 6, 2025 10:42AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <avvall@google.com>
Link: https://android-review.googlesource.com/3428979

[WebView] Expose Enable CHIPS API

Expand for full commit details

[WebView] Expose Enable CHIPS API 
 
aosp/3318854 introduced the enable CHIPS API hidden until it was 
deemed ready for release. This exposes the API for use in apps. 
 
Relnote: "Add setPartitionedCookiesEnabled API. This will allow 
developers to enable and disable partitioned cookies in WebView. The 
feature is available in WebView starting in M130." 
Bug: 364904765 
Test: ./webkit/run_instrumentation_tests.sh 
Change-Id: Ic506a23471946d31b797397e2f71aef0f3ae481a

Files:

M webkit/webkit/api/current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

Hash: 512bc1b685e6c5bbb563c33948b1c3b6b0ec9197
Date: Fri Dec 20 18:03:50 2024

av...@google.com <av...@google.com> Jan 6, 2025 05:55PM

Marked as fixed.

ap...@google.com <ap...@google.com> #9Jan 14, 2025 05:08PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <avvall@google.com>
Link: https://android-review.googlesource.com/3420019

Reformat affected classes from aosp/3406800.

Expand for full commit details

Reformat affected classes from aosp/3406800. 
 
aosp/3406800 refactored some common classes that were not formatted 
properly. 
 
Bug: 364904765 
Test: ./webkit/run_instrumentation_tests.sh 
Change-Id: I328af103b753e575c25a383dd709e355a973b98f

Files:

M webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/PollingCheck.java
M webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/TestWebMessageListener.java
M webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebViewOnUiThread.java
M webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebkitUtils.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/AsyncStartUpTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/MultiProfileTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/PostMessageTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ProxyControllerTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ServiceWorkerClientCompatTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ServiceWorkerWebSettingsCompatTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/TracingControllerTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatDarkModeTestBase.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatUserAgentMetadataTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebStorageTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewClientCompatTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewCompatTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewDocumentStartJavaScriptTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewRenderProcessClientTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewRenderProcessTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewWebMessageCompatTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewWebMessageListenerTest.java
M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/internal/AssetHelperTest.java

Hash: 818530aa0c71b1b6e1cba00a39494794b45ed6c8
Date: Wed Dec 18 00:18:27 2024

pr...@google.com <pr...@google.com> #10Jan 15, 2025 06:30PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.webkit:webkit:1.13.0-alpha03

ap...@google.com <ap...@google.com> #11Jan 29, 2025 07:46PM

Project: chromium/src
Branch: main
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6171228

[WV] Fix adding switch to stale command line reference.

Expand for full commit details

[WV] Fix adding switch to stale command line reference. 
 
Currently, the disable-partitioned-cookies, aka 
kDisablePartitionedCookiesSwitch, is used to control CHIPS in WebView. 
However, it is currently broken because it uses a stale reference to the 
command line object. This is because it is called after the point in 
WebView's startup where the native library is loaded and passes off its 
command line switches in Java to the native equivalent. This causes 
changes that make the old reference stale. It results in an incongruence 
between Java and native command line switches, causing undefined and 
unintended behavior with CHIPS in WebView. 
 
This fixes this by using the getInstance method to get a fresh reference 
to a valid instance of the command line. Another change limits the scope 
of the object that caused the issue by adding a block around the code 
that references it. Note: The default behavior will be set to on for 
now, postponing the decision to change it at a later point. 
 
testing for the glue layer later. 
 
Low-Coverage-Reason: HARD_TO_TEST Though we are looking into adding 
Bug: 364904765, 389121692 
Test: See bug 389121692 for test instructions. 
Change-Id: Icd9a04bbdc3a82197bf27bec428e60f05cd62243 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171228 
Auto-Submit: Adam Walls <avvall@chromium.org> 
Reviewed-by: Richard (Torne) Coles <torne@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1413072}

Files:

M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Hash: fda51784ebf6743fdd47c1e6fc441fdb05d13945
Date: Wed Jan 29 11:42:08 2025

ap...@google.com <ap...@google.com> #12Feb 27, 2025 08:02PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <avvall@google.com>
Link: https://android-review.googlesource.com/3509994

[WV] Correct CHIPS explainer and correct ranges for when CHIPS is enabled

Expand for full commit details

[WV] Correct CHIPS explainer and correct ranges for when CHIPS is enabled 
 
This CL fixes the link for the CHIPS explainer and updates the 
conditions for when CHIPS is enabled by default. 
 
Bug: 364904765 
Test: N/A Trivial documentation change 
Change-Id: Idd383550d874e4f58cf2481a83d11069b894604c

Files:

M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java

Hash: f166899dfebf7d49cbf9133bf28dccd0a9b75b1f
Date: Wed Feb 26 18:19:34 2025

IssueTracker

This issue is a part of the Chromium tracker.