AGP 8.6.1: Regression - WrongConstant lint failure when using [Int].toLong() inside a @LongDef in Kotlin [367752734]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Sep 18, 2024 01:24PM

The following code fails with WrongConstant when running ./gradlew lint under AGP 8.6.1. It passes with AGP 8.6.0.

Likely regression from https://issuetracker.google.com/issues/364261817

Error: Must be one or more of: AndroidPackageManager.GET_ACTIVITIES.toLong(), GET_SIGNING_CERTIFICATES.toLong() [WrongConstant]
      val one = PackageInfoFlagsCompat.of(GET_SIGNING_CERTIFICATES.toLong())
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: Must be one or more of: AndroidPackageManager.GET_ACTIVITIES.toLong(), GET_SIGNING_CERTIFICATES.toLong() [WrongConstant]
      val two = PackageInfoFlagsCompat.of(PackageManager.GET_ACTIVITIES.toLong())
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Minimal Reproducible Example

package io.github.davidallison.myapplication

import android.content.pm.PackageManager
import androidx.annotation.LongDef
import android.content.pm.PackageManager as AndroidPackageManager

fun wrongConstantError() {
    // usage: ./gradlew lint
    // fails with WrongConstant on 8.6.1, passes on 8.6.0
    val one = PackageInfoFlagsCompat.of(GET_SIGNING_CERTIFICATES.toLong())
    val two = PackageInfoFlagsCompat.of(PackageManager.GET_ACTIVITIES.toLong())
}

class PackageInfoFlagsCompat private constructor(@PackageInfoFlagsBits value: Long) {
    companion object {
        fun of(@PackageInfoFlagsBits value: Long): PackageInfoFlagsCompat = PackageInfoFlagsCompat(value)
    }
}
const val GET_SIGNING_CERTIFICATES = 0x08000000 // API 28

@LongDef(
    flag = true,
    value = [
        AndroidPackageManager.GET_ACTIVITIES.toLong(),
        GET_SIGNING_CERTIFICATES.toLong(),
    ]
)
@Retention(AnnotationRetention.SOURCE)
annotation class PackageInfoFlagsBits

    lint {
        disable += "GradleDependency"
        disable += "AndroidGradlePluginVersion"
        enable += "WrongConstant"
    }

STEPS TO REPRODUCE:

Download & extract MyApplication2.zip
./gradlew lint - fails
libs.versions.toml: change AGP to 8.6.0
./gradlew lint - passes

Likely Cause

364261817: "False positive" WrongConstant when using PackageManager.ResolveInfoFlags.of with Kotlin

Studio Build: Android Studio Koala Feature Drop | 2024.1.2
Version of Gradle Plugin: 8.6.1
Version of Gradle: 8.7
Version of Java: 17.0.101
OS: macOS 14.6.1

Android Studio Koala Feature Drop | 2024.1.2
Build #AI-241.18034.62.2412.12266719, built on August 22, 2024
Runtime version: 17.0.11+0-17.0.11b1207.24-11852314 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.6.1
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 10
Metal Rendering is ON
Registry:
  ide.instant.shutdown=false
  debugger.watches.in.variables=false
  android.gradle.project.startup.activity.disabled=true
  android.sdk.local.properties.update.disabled=true
Non-Bundled Plugins:
  idea.plugin.protoeditor (241.15989.49)

gradle_8_6_1_out.txt

3.4 KB

View

Download

MyApplication2.zip

4.5 MB

Download

Comments

sa...@google.com <sa...@google.com> Sep 18, 2024 05:58PM

Assigned to an...@google.com.

js...@google.com <js...@google.com> Sep 18, 2024 06:34PM

Reassigned to js...@google.com.

js...@google.com <js...@google.com> Sep 18, 2024 08:25PM

Accepted by js...@google.com.

js...@google.com <js...@google.com> #2Sep 19, 2024 05:31PM

Marked as fixed.

We don't support cross-process invalidations yet.

da...@gmail.com <da...@gmail.com> #3Sep 19, 2024 06:18PM

Comment has been deleted.

Message last modified on Sep 19, 2024 06:18PM

da...@gmail.com <da...@gmail.com> #4Sep 19, 2024 06:18PM

Okey, I made it and created a method to invalidate all observables below;

private void refreshAllLiveData() {
AppDataBase YOUR_DATABASE_WHICH_YOU_BUILD = .....
SupportSQLiteDatabase writableDatabase = YOUR_DATABASE_WHICH_YOU_BUILD.getOpenHelper().getWritableDatabase();
//get the database count;
Cursor cursor = writableDatabase.query("SELECT count(*) FROM sqlite_master WHERE type = 'table' AND name != 'android_metadata' AND name != 'room_master_table';");
int tableCount = 0;
while(cursor.moveToNext()) {
tableCount = cursor.getInt(0);
}

for (int i = 0; i < tableCount; i++) {
//update version table with the incremented count because room modification log stores tables with ids instead of names
writableDatabase.execSQL("INSERT OR REPLACE INTO room_table_modification_log VALUES(null, "+(i)+")");
}
YOUR_DATABASE_WHICH_YOU_BUILD.getInvalidationTracker().refreshVersionsAsync();
}

-----

This is a workaroud for refreshing all live datas, I still prefer to use a proper API you implemented.

Thanx

an...@google.com <an...@google.com> #5Sep 27, 2024 12:48AM

Cross process invalidation is now support in Room 2.1.0 with the enableMultiInstanceInvalidation() API.

an...@google.com <an...@google.com> #6Oct 14, 2024 05:58PM

The fixes for this issue are now also available in:

Android Studio Ladybug | 2024.2.1 Patch 1
Android Gradle Plugin 8.7.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

js...@google.com <js...@google.com> #7Oct 14, 2024 09:23PM

Sorry again for introducing a regression on "patch." Alas, there won't be the next patch for that patch, i.e., no AGP 8.6.2 apparently. However, as shown at comment#6, thanks(?) to repeated reports on AGP 8.7, necessary changes are patched to AGP 8.7.1 So... you can either stay at AGP 8.6.0 (not 8.6.1), or move on to AGP 8.7.1 (not 8.7.0). Sorry again for any inconvenience!