Fixed
Status Update
Comments
je...@google.com <je...@google.com>
mo...@google.com <mo...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
fr...@gmail.com <fr...@gmail.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
pr...@google.com <pr...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation-layout:1.8.0-alpha08
androidx.compose.foundation:foundation-layout-android:1.8.0-alpha08
androidx.compose.foundation:foundation-layout-jvmstubs:1.8.0-alpha08
androidx.compose.foundation:foundation-layout-linuxx64stubs:1.8.0-alpha08
Description
Jetpack Compose version: BOM 2024.05.00
Jetpack Compose component(s) used: Image
Android Studio Build: Jellyfish | 2023.3.1 Patch 2 #AI-233.14808.21.2331.11926650, built on June 4, 2024
Kotlin version: 1.9.23
My goal here is to have the colored box on the left match the height of the text, and for the image to be centered in the box.
However, I've discovered that applying a minWidth to the box causes it to gain height as if the image were being scaled to the box's minWidth. I'm not 100% sure, but it looks like the image's
requiredWidth
modifier isn't being accounted for in the intrinsic calculations when the image is a direct child of a Box. Wrapping the image in a Row fixes it, as does removing thedefaultMinSize
modifier on the Box. As you can see in the attached screenshot, it's the Box that has the extra height instead of the image, so that leads me to believe that the Image's intrinsics aren't working how I would expect. If I replace the Image with a Spacer, it also works correctly.I've attached a screenshot of the problem, as well as the image I used in my demo.
Component Summary:
Code: