[AGP] Lazy SdkComponents.ndkDirectory provider fails to produce value, but eager android.ndkDirectory API works [368816424]

Fixed

Bug

Status Update

No update yet.

Description

an...@gmail.com

created issue #1

Sep 23, 2024 02:00AM

DESCRIBE THE ISSUE IN DETAIL:

When using the older android.ndkDirectory API that eagerly evaluates the value, it evaluates to the proper directory path. However, when using the androidComponents.sdkProvider.ndkDirectory provider, gradle fails with Cannot query the value of this provider because it has no value available..

This seems to only affect ndkDirectory. Other things, like sdkDirectory work fine.

STEPS TO REPRODUCE:

Clone the minimal reproducer at: https://github.com/chenxiaolong/ndkdirectory-broken
Run ./gradlew printEager. It should successfully print the SDK and NDK paths.
Run ./gradlew printLazy. It should successfully print the SDK path, but crash when attempting to print the NDK path.

ATTACH LOG FILES

(Attached outputs of gradle commands)

Studio Build: n/a (AGP issue; not using Android Studio)
Version of Gradle Plugin: 8.6.1
Version of Gradle: 8.10
Version of Java: openjdk 21.0.4
OS: Fedora 40 x86_64 (Linux)

eager-working.txt

240 B

View

Download

lazy-broken.txt

554 B

View

Download

Comments

ac...@google.com <ac...@google.com> Sep 23, 2024 06:56PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Sep 24, 2024 05:28PM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #2Sep 25, 2024 05:58AM

Accepted by je...@google.com.

I don't think the average developer understands the distinction between method references and method definitions in this context (inside a DEX file). I know I don't.

@jvg, can you elaborate?

je...@google.com <je...@google.com> #3Sep 25, 2024 10:25PM

Marked as fixed.

people who are looking at the bytecode in the dex to optimize their app through shrinking hopefully will learn the difference as string tables for method references between various dex files can account for quite a bit of disk space. but more importantly a definition is something you can analyze its code for where a reference you can't so the UI can be confusing without seeing the difference

an...@gmail.com <an...@gmail.com> #4Sep 25, 2024 10:55PM

How about something like this?

I think having defined members be directly under the class node while references are nested in a group makes more sense.

Also note that the method refs have a slightly different icon. There is no existing equivalent for field refs that I could find.

https://screenshot.googleplex.com/4yXVM9Rzh4wnkjM.png

an...@google.com <an...@google.com> #5Sep 27, 2024 12:48AM

sounds reasonable to me, thanks

lu...@gmail.com <lu...@gmail.com> #6Sep 29, 2024 01:31PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 4
Android Gradle Plugin 8.8.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!