Unresolved reference '_connection'. when trying use PagingSource with @Relation in Pojo [369136627]

Fixed

Bug

Status Update

No update yet.

Description

el...@google.com

created issue #1

Sep 23, 2024 04:36PM

User reported error state that suggests there is a bug in CodeGen.

Comments

a....@gmail.com <a....@gmail.com> #2Sep 23, 2024 08:22PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

my...@gmail.com <my...@gmail.com> #3Sep 24, 2024 01:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

el...@google.com <el...@google.com> #4Sep 24, 2024 05:41PM

deleted

el...@google.com <el...@google.com> Oct 2, 2024 02:07AM

Accepted by el...@google.com.

sp...@gmail.com <sp...@gmail.com> #5Oct 2, 2024 03:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

da...@google.com <da...@google.com> #6Oct 2, 2024 03:31PM

A workaround might be to avoid @Relation and instead use a Map return type arg, but otherwise we are working on getting this fix for the next release.

sp...@gmail.com <sp...@gmail.com> #7Oct 7, 2024 03:14AM

Thanks for the advice. For my case I have multiple relations. Temporarily, I changed it to a Flow<List>. I'll wait for the next release to use PagingSource.

ap...@google.com <ap...@google.com> #8Oct 15, 2024 07:44PM

Project: platform/frameworks/support
Branch: androidx-main
Author: elifbilgin <elifbilgin@google.com>
Link: https://android-review.googlesource.com/3295162

Fix broken Relation support in Room Paging KMP.

Expand for full commit details

Fix broken Relation support in Room Paging KMP.

This CL fixes an issue in code generation in Room Paging which emerged when using @Relation with PagingSource. The solution resolves the issue by declaring a new suspend convertRows() method that can acquire a connection to perform the query.

Bug: 369136627
Test: BaseQueryTest.kt
Relnote: Revisit the newly added convertRows() method signature to be a suspend function that receives a RawRoomQuery for room-paging.
Change-Id: Ie57b558e217ce995a7d3dfe772c314aabbfcda8c

Files:

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/SampleDatabase.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MultiTypedPagingSourceQueryResultBinder.kt
M room/room-compiler/src/test/test-data/common/input/LimitOffsetPagingSource.kt
M room/room-compiler/src/test/test-data/daoWriter/output/javac/withLambda/ComplexDao.java
M room/room-compiler/src/test/test-data/daoWriter/output/javac/withoutLambda/ComplexDao.java
M room/room-compiler/src/test/test-data/daoWriter/output/ksp/ComplexDao.java
M room/room-compiler/src/test/test-data/kotlinCodeGen/multiTypedPagingSourceResultBinder.kt
M room/room-paging/bcv/native/current.txt
M room/room-paging/src/androidInstrumentedTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-paging/src/androidMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.android.kt
M room/room-paging/src/commonMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
M room/room-paging/src/commonMain/kotlin/androidx/room/paging/util/RoomPagingUtil.kt
M room/room-paging/src/jvmNativeMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.jvmNative.kt

Hash: 1abf563063f91b5459a43da0b533822c34ced782
Date: Mon Sep 23 17:29:24 2024

el...@google.com <el...@google.com> Oct 15, 2024 07:44PM

Marked as fixed.

ba...@gmail.com <ba...@gmail.com> #9Oct 17, 2024 02:26PM

Which version will include this fix??
Thanks!!!

el...@google.com <el...@google.com> #10Oct 17, 2024 06:06PM

Version 2.7.0-alpha11 should be the one to include this fix!

pr...@google.com <pr...@google.com> #11Oct 30, 2024 05:38PM