Odd wraparound in Android Studio Logcat [369321569]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

em...@google.com

created issue #1

Sep 24, 2024 11:46AM

See the video: https://screencast.googleplex.com/cast/NDY2NDcyOTkzMzk3MTQ1NnxlZDljZWQyNC0zNA

When wrapping is enabled, Logcat in Android Studio behaves weird, adds lots of empty lines. The logs (copy/pasted from adb logcat) are like this:

09-24 14:39:47.568  3272  3331 I Vulkan-Tutorial03: 	composite alpha flags: 1
09-24 14:39:47.570  3272  3331 E AppName : Validation ERROR: [VUID-VkDeviceQueueCreateInfo-pQueuePriorities-parameter] Code -690544442 : Validation Error: [ VUID-VkDeviceQueueCreateInfo-pQueuePriorities-parameter ] | MessageID = 0xd6d720c6 | vkCreateDevice(): pCreateInfo->pQueueCreateInfos[0].pQueuePriorities is NULL.
09-24 14:39:47.570  3272  3331 E AppName : The Vulkan spec states: pQueuePriorities must be a valid pointer to an array of queueCount float values (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkDeviceQueueCreateInfo-pQueuePriorities-parameter)
--------- beginning of crash
09-24 14:39:47.580  3272  3331 F libc    : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 3331 (tutorials.three), pid 3272 (tutorials.three)
09-24 14:39:47.653  1581  1763 W ziparchive: Unable to open '/data/app/~~XDeTBqneWx378GJ8EWOyBg==/com.android.example.vulkan.tutorials.three-dP2dya-p65ADzBD8CADguA==/base.dm': No such file or directory
09-24 14:39:47.656  1581  1763 I ActivityTaskManager: Displayed com.android.example.vulkan.tutorials.three/.MainActivity for user 0: +910ms

And the giant space happens at the 09-24 14:39:47.570 3272 3331 E AppName : The Vulkan spec states: line.

System information:

Build: AI-241.18034.62.2412.12266719, 202408230029
AS: Koala Feature Drop | 2024.1.2
AI-241.18034.62.2412.12266719, JRE 17.0.11+0-17.0.11b1207.24-11852314x64 JetBrains s.r.o., OS Mac OS X(aarch64) v14.6.1, screens 2992.0x1934.0; Retina
Android Gradle Plugin: 7.3.0
Gradle: 7.4
Gradle JDK: JetBrains Runtime 11.0.15 - aarch64
NDK: from module: 25.2.9519653, from module: 25.2.9519653, from local.properties: (not specified), latest from SDK: 27.0.12077973
CMake: from local.properties: (not specified), latest from SDK: 3.22.1-g37088a8, from PATH: 3.22.1-g37088a8

Comments

em...@google.com <em...@google.com> #2Sep 24, 2024 11:47AM

I don't think the average developer understands the distinction between method references and method definitions in this context (inside a DEX file). I know I don't.

@jvg, can you elaborate?

er...@google.com <er...@google.com> Sep 24, 2024 05:19PM

Assigned to an...@google.com.

aa...@google.com <aa...@google.com> #3Sep 30, 2024 06:14PM

Accepted by aa...@google.com.

people who are looking at the bytecode in the dex to optimize their app through shrinking hopefully will learn the difference as string tables for method references between various dex files can account for quite a bit of disk space. but more importantly a definition is something you can analyze its code for where a reference you can't so the UI can be confusing without seeing the difference

aa...@google.com <aa...@google.com> Oct 1, 2024 04:34PM

Marked as fixed.

an...@google.com <an...@google.com> #4Oct 3, 2024 07:49PM

How about something like this?

I think having defined members be directly under the class node while references are nested in a group makes more sense.

Also note that the method refs have a slightly different icon. There is no existing equivalent for field refs that I could find.

https://screenshot.googleplex.com/4yXVM9Rzh4wnkjM.png

Issue 369321569