Fixed
Status Update
No update yet.
Comments
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
mo...@interaso.com
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Add API to SQLiteStatement to get a column's data type
Expand for full commit details
Add API to SQLiteStatement to get a column's data type
Bug: 369636251
Relnote: "Add SQLiteStatement.getColumnType() along with the various SQLITE_DATA_* result constants to enable retrieving the data type of a column."
Test: ./sqlite/scripts/runConformanceTest.sh
Change-Id: I1985c7b267ba4d6342cb487cbe6e889bed3ff26d
Files:
- M
room/room-runtime/src/androidMain/kotlin/androidx/room/driver/SupportSQLiteStatement.android.kt - M
room/room-runtime/src/androidUnitTest/kotlin/androidx/room/InvalidationTrackerTest.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/RoomRawQuery.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/coroutines/ConnectionPoolImpl.kt - M
sqlite/integration-tests/driver-conformance-test/src/commonTest/kotlin/androidx/sqlite/driver/test/BaseConformanceTest.kt - M
sqlite/sqlite-bundled/src/jvmAndroidMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteStatement.jvmAndroid.kt - M
sqlite/sqlite-framework/bcv/native/current.txt - M
sqlite/sqlite-framework/src/androidMain/kotlin/androidx/sqlite/driver/AndroidSQLiteStatement.android.kt - M
sqlite/sqlite-framework/src/nativeMain/kotlin/androidx/sqlite/driver/NativeSQLiteStatement.kt - M
sqlite/sqlite/api/current.txt - M
sqlite/sqlite/api/restricted_current.txt - M
sqlite/sqlite/bcv/native/current.txt - M
sqlite/sqlite/src/commonMain/kotlin/androidx/sqlite/SQLite.kt - M
sqlite/sqlite/src/commonMain/kotlin/androidx/sqlite/SQLiteStatement.kt
Hash: 3001a3332b004f92b2df33ec16f312368e3b2570
Date: Thu Sep 26 21:29:43 2024
da...@google.com
mo...@interaso.com
Thank you very much :)
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-runtime:2.7.0-alpha10androidx.room:room-runtime-android:2.7.0-alpha10androidx.room:room-runtime-macosx64:2.7.0-alpha10androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha10androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha10androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha10androidx.sqlite:sqlite-framework:2.5.0-alpha10androidx.sqlite:sqlite-framework-android:2.5.0-alpha10androidx.sqlite:sqlite-framework-iosarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-iossimulatorarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-iosx64:2.5.0-alpha10androidx.sqlite:sqlite-framework-linuxarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-linuxx64:2.5.0-alpha10androidx.sqlite:sqlite-framework-macosarm64:2.5.0-alpha10androidx.sqlite:sqlite-framework-macosx64:2.5.0-alpha10androidx.sqlite:sqlite-iosarm64:2.5.0-alpha10androidx.sqlite:sqlite-iossimulatorarm64:2.5.0-alpha10androidx.sqlite:sqlite-iosx64:2.5.0-alpha10androidx.sqlite:sqlite-jvm:2.5.0-alpha10androidx.sqlite:sqlite-linuxarm64:2.5.0-alpha10androidx.sqlite:sqlite-linuxx64:2.5.0-alpha10androidx.sqlite:sqlite-macosarm64:2.5.0-alpha10androidx.sqlite:sqlite-macosx64:2.5.0-alpha10
Description
Version used: all
Devices/Android versions reproduced on: -
I am writing sqlite viewer app and need to know what function of get* (getText, getInt, etc) to call and display.