TapGestureDetector callbacks onPress and onTap can be called in wrong order [369648479]

Fixed

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Sep 25, 2024 07:01PM

When the down and the up event arrive in rapid succession, it is possible that the onPress callback is executed after the onTap callback.

It is currently not possible to reproduce this in a test, because we use an UnconfinedTestDispatcher. When we switch to a StandardTestDispatcher, the following test (when added to TapGestureDetectorTest.kt) will fail:

@Test
fun testOrderOfExecution() {
    val events = mutableListOf<String>()
    rule.setContent(
        layoutWithGestureDetector {
            detectTapGestures(
                onPress = { events.add("onPress") },
                onTap = { events.add("onTap") }
            )
        }
    )
    rule.onNodeWithTag(TargetTag).performTouchInput {
        down(center)
        up()
    }
    rule.waitForIdle()
    assert(events.size == 2) { "should have received 2 events, but received $events" }
    assert(events[0] == "onPress") { "first event should be onPress, but events were $events"}
    assert(events[1] == "onTap") { "second event should be onTap, but events were $events"}
}

While very difficult, I think you could reproduce it in a demo app with an incredibly short tap.

Comments

jo...@google.com <jo...@google.com> #2Sep 26, 2024 09:44AM

Reassigned to jo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

je...@google.com <je...@google.com> #3Sep 26, 2024 01:29PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Message last modified on Sep 26, 2024 01:31PM

ap...@google.com <ap...@google.com> #4Dec 6, 2024 07:50PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3376239

Enable DetectTapGesturesEnableNewDispatchingBehavior by default

Expand for full commit details

Enable DetectTapGesturesEnableNewDispatchingBehavior by default 
 
This flag was previously introduced when we did not have a reproduction case. We have since received positive user reports and are adding a test in this change. 
This change also feature-flags the jobs that call the `onPress` callback, which we previously missed. 
 
Relnote: Enabled `DetectTapGesturesEnableNewDispatchingBehavior` by default. `TapGestureDetector` APIs now use the new dispatching behavior (immediate dispatch) by default. 
Fixes: 369648479 
Test: Tested with test from b/369648479 using a StandardTestDispatcher; can't include test here as the testing changes aren't ready yet. Existing TapGestureDetector tests pass 
Change-Id: I9f2bc726cffd87500d10962c067541d8add69b63

Files:

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/TapGestureDetector.kt

Hash: 653681695bac933e67b31c1cd3b6e1d5ad192c33
Date: Tue Nov 26 16:36:05 2024

pr...@google.com <pr...@google.com> #5Jan 15, 2025 06:30PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha08
androidx.compose.foundation:foundation-android:1.8.0-alpha08
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha08
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha08

Issue 369648479

Description

Issue summary

Comments

jo...@google.com <jo...@google.com> #2Sep 26, 2024 09:44AM

je...@google.com <je...@google.com> #3Sep 26, 2024 01:29PM

ap...@google.com <ap...@google.com> #4Dec 6, 2024 07:50PM

pr...@google.com <pr...@google.com> #5Jan 15, 2025 06:30PM

Add comment

Issue metadata