Fixed
Status Update
No update yet.
Comments
al...@android.com
Thank you very much for reporting this issue, Jack. Looks like the issue is caused by somewhat unnecessary and contrived logic in apksigner.bat, which is special-casing -J* parameters. Unfortunately, this logic doesn't handle whitespace containing parameters, even those which aren't -J*.
I've uploaded a tentative fixhttps://android-review.googlesource.com/#/c/394238/ for review. The patched apksigner.bat is attached. This fixes the issue on my Windows 10 box.
Jack, please test the fix in your environment and let us know whether it works for you too.
I've uploaded a tentative fix
Jack, please test the fix in your environment and let us know whether it works for you too.
da...@nthcircle.com
Confirmed, that fix works. Thank you for the quick turn-around on this.
da...@nthcircle.com
ki...@gmail.com
Project: platform/tools/apksig
Branch: master
commit b293b2087837853e32a1cff008d58644dbbd4cc2
Author: Alex Klyubin <klyubin@google.com>
Date: Wed May 10 16:53:25 2017
Handle whitespace when removing -J* parameters in .bat
apksigner.bat contains special logic for -J* parameters. This logic
was not designed to handle parameters containing whitespace. This
commit fixes the issue. It is unclear whether this -J* logic is even
needed. So, if it keeps breaking stuff, we should probably simply
remove it.
Test: apksigner sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk
Fails with FileNotFoundException instead of "a was unexpected at this time"
Bug: 38132450
Change-Id: Ice3294e9993b075533c77d94eb870cfd35a65bbc
M etc/apksigner.bat
https://android-review.googlesource.com/394238
https://goto.google.com/android-sha1/b293b2087837853e32a1cff008d58644dbbd4cc2
Branch: master
commit b293b2087837853e32a1cff008d58644dbbd4cc2
Author: Alex Klyubin <klyubin@google.com>
Date: Wed May 10 16:53:25 2017
Handle whitespace when removing -J* parameters in .bat
apksigner.bat contains special logic for -J* parameters. This logic
was not designed to handle parameters containing whitespace. This
commit fixes the issue. It is unclear whether this -J* logic is even
needed. So, if it keeps breaking stuff, we should probably simply
remove it.
Test: apksigner sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk
Fails with FileNotFoundException instead of "a was unexpected at this time"
Bug: 38132450
Change-Id: Ice3294e9993b075533c77d94eb870cfd35a65bbc
M etc/apksigner.bat
qu...@google.com
ti...@google.com
Project: platform/tools/apksig
Branch: master
commit 0f88b97634034673f062a8ac6c3dab7d3d9befe3
Author: Alex Klyubin <klyubin@google.com>
Date: Thu Jun 22 09:43:22 2017
Bump apksigner version to 0.7
Changes since 0.6:
* Fixed a bug in whitespace handling in command-line parameters in
apksigner.bat.https://issuetracker.google.com/issues/38132450
* Fixed a bug in JAR signature verification when multiple digests
are present for the same named entry in MANIFEST.MF.
https://issuetracker.google.com/issues/38497270
* Honor android:targetSandboxVersion (introduced in Android O) when
verifying APKs. When android:targetSandboxVersion is set to 2 or
higher, the APK is required to be signed with APK Signature Scheme
v2.
* When signing, reject APKs with CR, LF or NUL in ZIP entry names.
Such names are not permitted by the JAR siging spec and are also
rejected by Android Package Manager.
Test: apksigner version
Bug: 38132450
Bug: 38497270
Bug: 36426653
Bug: 62211230
Change-Id: Ifa120b0e43b458c99c3da6fde1136e0cbb92caee
M src/apksigner/java/com/android/apksigner/ApkSignerTool.java
https://android-review.googlesource.com/420784
https://goto.google.com/android-sha1/0f88b97634034673f062a8ac6c3dab7d3d9befe3
Branch: master
commit 0f88b97634034673f062a8ac6c3dab7d3d9befe3
Author: Alex Klyubin <klyubin@google.com>
Date: Thu Jun 22 09:43:22 2017
Bump apksigner version to 0.7
Changes since 0.6:
* Fixed a bug in whitespace handling in command-line parameters in
apksigner.bat.
* Fixed a bug in JAR signature verification when multiple digests
are present for the same named entry in MANIFEST.MF.
* Honor android:targetSandboxVersion (introduced in Android O) when
verifying APKs. When android:targetSandboxVersion is set to 2 or
higher, the APK is required to be signed with APK Signature Scheme
v2.
* When signing, reject APKs with CR, LF or NUL in ZIP entry names.
Such names are not permitted by the JAR siging spec and are also
rejected by Android Package Manager.
Test: apksigner version
Bug: 38132450
Bug: 38497270
Bug: 36426653
Bug: 62211230
Change-Id: Ifa120b0e43b458c99c3da6fde1136e0cbb92caee
M src/apksigner/java/com/android/apksigner/ApkSignerTool.java
gr...@gmail.com
The fix has been released in apksigner 0.7, released as part of Android SDK Build Tools 26.0.1.
ha...@gmail.com
Running in to this in Android Studio 3.0.1 under SDK 27 (minSDK 21, target 27)
Unfortunate since it forces me to turn a simple layout XML resource into a full-blown fragment so I can put that View.setClipToOutline(true) call in.
Unfortunate since it forces me to turn a simple layout XML resource into a full-blown fragment so I can put that View.setClipToOutline(true) call in.
jo...@gmail.com
I'm also facing this issue on Android Studio 3.2 Canary 15 with SDK 27 (minSDK 21, target 27)
as...@google.com
Per team reorg, UI now belongs to jbax@ (with rrawles@ as secondary).
pa...@outlook.com
Three years later and this is still not resolved, what the fuck...
th...@gmail.com
Hi! It would be great to have this one resolved.
sh...@gmail.com
Please resolve this issue.
dx...@gmail.com
Can this get bloody fixed already?!...
pr...@gmail.com
Any hope of issue getting fixed????
ry...@gmail.com
Four years later and this tiny issue is still not fixed. Please resolve this issue.
je...@gmail.com
Please fix this issue
sz...@gmail.com
Please fix this issue
mi...@gmail.com
It's 55 stars now, maybe it's time? :)
sa...@gmail.com
Spam
sv...@gmail.com
( Í Â° ÍŸÊ– ͡°)
It's time to fix it
It's time to fix it
st...@gmail.com
*cry in 61 stars*
kh...@gmail.com
Running into same issue :(
ht...@gmail.com
over 4 years, really?
ke...@gmail.com
hey, it's 2019
and you can't fix a small bug for over 4 years?
and you can't fix a small bug for over 4 years?
sa...@gmail.com
most productive company over the world :)
[Deleted User] <[Deleted User]>
come on, just do it
fe...@parkside-interactive.com
I'm not even an Android developer anymore, I just keep this issue tracking to laugh about it
me...@yanghui.name
See you guys in 2020
as...@gmail.com
Finally, a decent issue to fix for that super-duper AI they keep bragging about.
mi...@gmail.com
This is my favorite issue in AOSP. I have a feeling that we'll be getting a real fix in 2020!
pa...@outlook.com
Don't mind me, I'm just punching my timecard.
Last one was in Oct 30, 2018 09:04AM. I wonder what will happen first, me showing up again in one year or this issue being finally fixed?
How ridiculous does this have to get before the team decides to fix it I wonder.
Last one was in Oct 30, 2018 09:04AM. I wonder what will happen first, me showing up again in one year or this issue being finally fixed?
How ridiculous does this have to get before the team decides to fix it I wonder.
ka...@gmail.com
2020 reporting in, and we're still waiting.
mb...@gmail.com
2021 is approaching fast guys :-)
ha...@flippar.com
You can reuse the same xml, but you can't do that easily with the java code.
I just had to re-edit java code to include this setting in four places instead of just adding a single line of xml.. What I needed was a simpler way to add curved edges to views. iOS does this much better.
I just had to re-edit java code to include this setting in four places instead of just adding a single line of xml.. What I needed was a simpler way to add curved edges to views. iOS does this much better.
ma...@gmail.com
and here i am daydreaming about how easy it would be if i were using literally anything other than native android to simply make a rounded corner :(
da...@gmail.com
checking back after a year. It's still the same
Je...@hotmail.com
Would also like to see this one fixed ¯\_(ツ)_/¯
mu...@gmail.com
In 2045 our AI god gives us the present of time travelling. I am from the future and can tell you: This bug is still not fixed.
as...@gmail.com
Frankly, I don't care about the bug at this point. The thread itself keeps on giving. Keep it up, boiis! Any movie recommendations?
da...@gmail.com
eXistenZ is a great movie.
si...@gmail.com
if we create new bug for it maybe they take a look?
sa...@gmail.com
I feel like a subreddit should be made to honor this bug
tr...@gmail.com
Still waiting for a fix...
mv...@gmail.com
Wow, how come google avoid such Critical bug for such long !
ma...@gmail.com
This thread is hilarious 😄
sm...@gmail.com
here guys some movie recommendations: gone girl, inception, knives out, gentlemen, jojo rabbit, ford v Ferrari, the irishman
here 's some shows to watch: umbrella academy, dark, la casa de papel but only two seasons
here 's some shows to watch: umbrella academy, dark, la casa de papel but only two seasons
[Deleted User] <[Deleted User]>
oh, thanks for the list. think i can finish that list before this thing get fixed.
ki...@gmail.com
I can make my own movie before this gets fixed xD
This is a great list! I would add 1917 to that. Also.. think we can hack the google server to fix this issue before they can change a sentence in their documentation html? Kinda like these guys but in the digital world?https://en.wikipedia.org/wiki/Les_UX
This is a great list! I would add 1917 to that. Also.. think we can hack the google server to fix this issue before they can change a sentence in their documentation html? Kinda like these guys but in the digital world?
pa...@outlook.com
Just punching my timecard.
Last one was in Dec 5, 2019 05:57AM
This issue is gaining some life of its own, even a pandemic came before this issue ever got solved.
I wonder if the world will still exist when I come by again
Last one was in Dec 5, 2019 05:57AM
This issue is gaining some life of its own, even a pandemic came before this issue ever got solved.
I wonder if the world will still exist when I come by again
es...@gmail.com
Haha not even available in AppCompatImageView with app: notation. Google don't care, just close it already and leave it as a hidden feature :D
[Deleted User] <[Deleted User]>
Adding this one to my list of eternal bugs I follow, thanks Google.
jb...@google.com
Hi friends. The Android time travel council of 2075 has finally approved the removal of the incorrect XML attribute reference. I was granted approval to travel back to 2015 to make the fix, but time machines are still super buggy in 2075, and I ended up in 2020 :(
The time machine is broken, so I'm stuck here ¯\_(ツ)_/¯. Regardless, I've removed the reference to the XML attribute that never existed.
The time machine is broken, so I'm stuck here ¯\_(ツ)_/¯. Regardless, I've removed the reference to the XML attribute that never existed.
cp...@gmail.com
Instead of implementing this attribute - approximately 1 line of code in the View constructor you are removed documentation to attribute. You always can call it from the code! Great, thanks a lot!
te...@gmail.com
The fix is the most unexpected thing of 2020, period.
to...@gmail.com
I'll miss you all 😥. I often think of how this simple bug has let so many
people connect over the years. Take care all!
On Thu, Dec 24, 2020 at 3:39 AM <buganizer-system@google.com> wrote:
people connect over the years. Take care all!
On Thu, Dec 24, 2020 at 3:39 AM <buganizer-system@google.com> wrote:
--
Todd DeLand
Todd DeLand
lb...@gmail.com
@52 Please fix the time machine. It could be very useful.
Also nice to see that Android still exists even on 2075 and wasn't replaced by something else
Also nice to see that Android still exists even on 2075 and wasn't replaced by something else
al...@trustedshops.de
Any updates?!
ki...@google.com
So...still haven't fixed the time machine fully, but Android time travel council of 2080 did give me permission to add the attribute, so as of API 31, there will be an android:clipToOutline attribute.
lb...@gmail.com
@58 I guess the council of 2080 is more permissive than the one of 2075, which said to remove stuff...
jj...@gmail.com
@58 Amen !
da...@gmail.com
@58 Whoa, I'm in disbelief. The mythical `android:clipToOutline` is actually coming? I'm beginning to tear up...
ka...@gmail.com
holy shit what in the world is going on why tf can i not have an image with one or two rounded corners kms
lb...@gmail.com
@58 This is added to Android S ? Or to android-x, so that everything could use it? I forgot even why I wanted it...
mc...@gmail.com
+1
da...@hotmail.com
This will be deprecated in favor of jetpack compose, mark my words.
te...@gmail.com
+1
et...@gmail.com
+1
an...@gmail.com
The original report from Apr 10, 2015 was:
android:clipToOutline cannot be found even if it's documented there:https://developer.android.com/training/material/shadows-clipping.html#Clip
Upon checking said link, I can confirm that android:clipToOutline has been removed from the documentation.
Therefore I think we can all agree, that after 6 years the bug has finally been resolved!
android:clipToOutline cannot be found even if it's documented there:
Upon checking said link, I can confirm that android:clipToOutline has been removed from the documentation.
Therefore I think we can all agree, that after 6 years the bug has finally been resolved!
ka...@gmail.com
Who knew that all along the real issue was the documentation, not the lack of functionality.
ki...@google.com
This is fixed in Android S. No plans right now to add it to androidx as there's no precedent for globally backporting attributes to non-AppCompat views.
pa...@outlook.com
Took a while for my final last punchcard, but finally something was done.
So the fix could not be backported meaning users have two options:
- manually set the attribute in code
or
- manually set the attribute in code for API 30 and below, and make a separate layout file for API 31 and above which does allow the attribute to be used in xml
in my case the second option is just extra work for no benefit (for now), so I will keep using the first one until I increase the min version to one that matches the compatibility of this fix.
Description
Gradle tools version: 1.1.3
Build tools version: 22.0.1
Compile SDK version: 22
Issue description:
android:clipToOutline cannot be found even if it's documented there:
When I try to use this xml attribute, I have an error at compile time:
Error:(9, -1) Gradle: No resource identifier found for attribute 'clipToOutline' in package 'android'
Steps to reproduce:
- Create a layout with a basic view and the attribute android:clipToOutline="false"
- Compile
Observed results:
The project will not compile and will fail with the above error.
Expected results:
The project would compile and apply the correct attribute.