We don't handle failures in @BeforeClass [37057596]

Fixed

Bug

[AOSP] assigned

Migrated-Tools-testing

Status Update

No update yet.

Description

be...@google.com

created issue #1

Aug 20, 2015 03:41PM

Version: TOT

When tests fail to start (for example because of an error in @BeforeClass), gradle gets confused, it only sees missing test results, no stack trace is captured or reported.

Tested with AndroidJUnitRunner.

Comments

ch...@google.com <ch...@google.com> Jan 11, 2016 10:52PM

Assigned to ch...@google.com.

be...@google.com <be...@google.com> Jan 28, 2016 11:52AM

Reassigned to to...@android.com.

zb...@gmail.com <zb...@gmail.com> #2Oct 7, 2016 04:10PM

There are a few more changes to DataStoreImpl's logic which makes a reevaluation necessary.

Now with Yigit's changes, datastore's cold flow always tries to do a dirty read by readState which calls readAndInitOrPropagateAndThrowFailure that invokes readDataOrHandleCorruption only in InitDataStore's first run. Any following read is triggered by IPC's listener which calls readDataAndUpdateCache which updates the cache to ReadException returned from attemptRead.

A ReadException is not automatically handled and stays in cache until a updateData call which revisits readAndInitOrPropagateAndThrowFailure, but it doesn't handle the corruption exception because it's already not the first run. In such case, the handleUpdate call proceeds to transformAndWrite which does not catch the exceptions thrown from readDataFromFileOrDefault.

zb...@gmail.com <zb...@gmail.com> #3Jun 9, 2017 02:25PM

can we create a test failure for this? I'm not fully sure what is going wrong here, it is a bit hard to track w/o a repro case.

be...@google.com <be...@google.com> #4Jun 22, 2017 03:31PM

Reassigned to nk...@google.com.

can we create a test failure for this?

Sure I'm working on the code changes.

In the meantime I think this bug might makes the errors e.g. in b/309382591 harder to recover because it doesn't try to handle the corruption until the app restarts so the DS can readAndInit again (with corruption handler logic).

xa...@google.com <xa...@google.com> #5Jul 28, 2017 04:39AM

Project: platform/frameworks/support
Branch: androidx-main

commit 383a67d0e5a9b35e394b212db35bdee892b167fb
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Wed Feb 21 17:04:40 2024

Add tests to verify that CorruptionException is not properly handled after DataStore's first disk read. If the internal state is [ReadException], it will not recover for the rest of the lifecycle.

Fix in the follow up change.

Bug: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Ie77900b5c2cb8fb8e55d4c40364491dea9250784

M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt

https://android-review.googlesource.com/2972402

nk...@google.com <nk...@google.com> #6Jul 28, 2017 05:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 70085fee2af278bb8c3e45e1acfcf3f4cbb05c5a
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Thu Feb 22 15:08:34 2024

DataStore handles CorruptionException for all reads and writes.

Before this change, DataStore didn't handle the CorruptionException for both the reads and writes after initialization.

Fixes: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Icb07b140017b62a905d3626f82aeb993f636c053

M datastore/datastore-core/src/commonMain/kotlin/androidx/datastore/core/DataStoreImpl.kt
M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt

https://android-review.googlesource.com/2974198

xa...@google.com <xa...@google.com> #7Jul 28, 2017 05:02PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.datastore:datastore-core:1.1.0-beta02
androidx.datastore:datastore-core-android:1.1.0-beta02
androidx.datastore:datastore-core-iosarm64:1.1.0-beta02
androidx.datastore:datastore-core-iossimulatorarm64:1.1.0-beta02
androidx.datastore:datastore-core-iosx64:1.1.0-beta02
androidx.datastore:datastore-core-jvm:1.1.0-beta02
androidx.datastore:datastore-core-linuxx64:1.1.0-beta02
androidx.datastore:datastore-core-macosarm64:1.1.0-beta02
androidx.datastore:datastore-core-macosx64:1.1.0-beta02

nk...@google.com <nk...@google.com> Aug 12, 2017 12:31AM

Reassigned to am...@google.com.

zb...@gmail.com <zb...@gmail.com> #8Feb 22, 2018 11:12AM

Any update on this?

be...@google.com <be...@google.com> #9Feb 22, 2018 11:17AM

Reassigned to sl...@google.com.

Stephan - can you assign as appropriate?

sl...@google.com <sl...@google.com> Mar 21, 2018 04:52PM

Status: New

br...@google.com <br...@google.com> #10Mar 27, 2018 10:47PM

Any update on this?

nk...@google.com <nk...@google.com> Apr 5, 2018 10:12PM

Assigned to nk...@google.com.

nk...@google.com <nk...@google.com> #11Apr 6, 2018 09:48PM

Marked as fixed.

The fix will be available in the next Runner release v1.0.2.