Lifecycle should not allow moving from DESTROYED [370577987]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 30, 2024 10:55PM

b/177924329 addressed an issue of moving the Lifecycle.State from INITIALIZED to DESTROYED needing to throw whether there was an observer or not.

But attempting to move the Lifecycle.State from DESTROYED to any other state should throw as well as DESTROYED is a terminal state for any component that has a Lifecycle.

Comments

ap...@google.com <ap...@google.com> #2Oct 16, 2024 09:32AM

Following CLs are added to AndroidX:
-

https://r.android.com/2193004
-

https://r.android.com/2186213
-

https://r.android.com/2232128

il...@google.com <il...@google.com> Oct 16, 2024 05:24PM

Assigned to mg...@google.com.

mg...@google.com <mg...@google.com> #3Oct 17, 2024 10:38AM

Chromium counterpart:

https://crbug.com/1355297

ap...@google.com <ap...@google.com> #4Oct 17, 2024 05:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit a0fc2a2e7b8c8c09e36202915d836e67c3312253
Author: Abhijith Nair <abhijithnair@google.com>
Date: Mon Oct 03 13:11:02 2022

Add test for ProcessGlobalConfigActivity

Test ensures that there exists a data directory present on the device
with the name specified using `setDataDirectorySuffix(String, Context)`.

Bug: 250553687
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: Ic1391ac6527fa78464ed4c9f685a067d6dcb3dc1

A webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
A webkit/integration-tests/testapp/src/main/res/layout/activity_process_global_config.xml
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2239836

mg...@google.com <mg...@google.com> Oct 24, 2024 03:36PM

Marked as fixed.

il...@google.com <il...@google.com> #5Oct 25, 2024 05:28AM

Project: platform/frameworks/support
Branch: androidx-main

commit e59d4c20268f10741b4bfb0d939884704659043c
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Oct 25 13:58:31 2022

Unhide ProcessGlobalConfig APIs

Along with unhiding the APIs, the API files are also updated.

Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687
Relnote: "Add ProcessGlobalConfig enabling users to set process global
config prior to loading WebView."

Change-Id: I7c0e0e42e91efe45f16e66afead7b9e52240bfe4

M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M webkit/webkit/api/current.txt
M webkit/webkit/api/public_plus_experimental_current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2268927

pr...@google.com <pr...@google.com> #6Oct 30, 2024 05:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit d1b0ecf7a695406a3a88da9a5f6c6b1859b784a9
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Nov 01 18:07:17 2022

Rename the WebView manifest key name

Rename SET_DATA_DIRECTORY_SUFFIX:DEV to
STARTUP_FEATURE_SET_DATA_DIRECTORY_SUFFIX

Change-Id: Id2a0a29a3cbc6972bbf285836cd13e8d2af7fd3d
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687

M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2280854