Lifecycle should not allow moving from DESTROYED [370577987]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 30, 2024 10:55PM

b/177924329 addressed an issue of moving the Lifecycle.State from INITIALIZED to DESTROYED needing to throw whether there was an observer or not.

But attempting to move the Lifecycle.State from DESTROYED to any other state should throw as well as DESTROYED is a terminal state for any component that has a Lifecycle.

Comments

ap...@google.com <ap...@google.com> #2Oct 16, 2024 09:32AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> Oct 16, 2024 05:24PM

Assigned to mg...@google.com.

mg...@google.com <mg...@google.com> #3Oct 17, 2024 10:38AM

Created b/374043130 to address the eventFlow never completed when Lifecycle reaches DESTROYED (terminal state).

ap...@google.com <ap...@google.com> #4Oct 17, 2024 05:13PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3300455

Disallow a DESTROYED Lifecycle to be moved to any state

Expand for full commit details

Disallow a `DESTROYED` Lifecycle to be moved to any state

* `DESTROYED` is a terminal state, and attempting to move from it to `Any` will now throw an `IllegalStateException`.

RelNote: "The `Lifecycle.DESTROYED` state is terminal, and any attempt to move a `Lifecycle` from it to any other state will now result in an `IllegalStateException`."
Test: LifecycleRegistryTest
Bug: 370577987
Change-Id: I116c40ccb6a7a4807072ecf85ed4cf5ceca07568

Files:

M lifecycle/lifecycle-runtime-testing/src/commonTest/kotlin/androidx/lifecycle/testing/LifecycleEventFlowTest.kt
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/androidx/lifecycle/LifecycleRegistryTest.java
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/LifecycleRegistry.kt
M lifecycle/lifecycle-runtime/src/commonTest/kotlin/androidx/lifecycle/CommonLifecycleRegistryTest.kt
M lifecycle/lifecycle-runtime/src/jvmCommonMain/kotlin/androidx/lifecycle/LifecycleRegistry.jvm.kt
M lifecycle/lifecycle-runtime/src/nonJvmCommonMain/kotlin/androidx/lifecycle/LifecycleRegistry.nonJvm.kt

Hash: e7cc3d4854287589d3ba96a5a5461b155852d83d
Date: Wed Oct 09 11:38:53 2024

mg...@google.com <mg...@google.com> Oct 24, 2024 03:36PM

Marked as fixed.

il...@google.com <il...@google.com> #5Oct 25, 2024 05:28AM

This has been fixed internally and will be available in Lifecycle 2.9.0-alpha06.

pr...@google.com <pr...@google.com> #6Oct 30, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-runtime:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-android:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-desktop:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-iosarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-iossimulatorarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-iosx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-linuxarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-linuxx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-macosarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-macosx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-android:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-desktop:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-iosarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-iossimulatorarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-iosx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-linuxarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-linuxx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-macosarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-runtime-testing-macosx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-android:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-desktop:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-iosarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-iossimulatorarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-iosx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxx64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-macosarm64:2.9.0-alpha06
androidx.lifecycle:lifecycle-viewmodel-savedstate-macosx64:2.9.0-alpha06