Espresso semi-parallel test execution fails on static objects [37082857]

Fixed

Bug

[AOSP] duplicate

[AOSP] assigned

Status Update

No update yet.

Description

v....@gmail.com

created issue #1

Feb 22, 2016 10:15AM

Library used: com.android.support.test.espresso:espresso-core:2.2.1
Version used: 2.2.1

What steps will reproduce the problem?
1. Have atleast 3 tests
2. Log messages in activity onCreate and onDestroy
3. Observe onCreate -> onDestroy messages not going in order (onCreate -> onDestroy, onCreate -> onDestroy, onCreate -> onDestroy)

How are you running your tests (via Android Studio, Gradle, adb, etc.)?
Android Studio 1.5.1

What is the expected output? What do you see instead?
Log messages going sequentially (onCreate -> onDestroy, onCreate -> onDestroy, onCreate -> onDestroy)

I am trying to use espresso and junit4. The problem seems to be that I have code that is statically initialized in activity.onCreate and deinitialized in activity.onDestroy to prevent leaks, etc.

Now when I run espresso, the tests seem to run in "parallel". I added log class to activity onCreate and onDestroy.

What I am seeing is

onCreate = example.package.MainActivity@ABC
onCreate = example.package.MainActivity@JKL
onDestroy = example.package.MainActivity@ABC
onCreate = example.package.MainActivity@XYZ
onDestroy = example.package.MainActivity@JKL
onDestroy = example.package.MainActivity@XYZ

**and ofcourse it fails on NPE in third test because the second test's onDestroy ran after third's onCreate (which null-ed out the static code)**

Is this behaviour normal? Can I force espresso to teardown activity instance first and only then start a new one? Thanks!

Comments

sl...@google.com <sl...@google.com> #2Feb 29, 2016 09:11PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

v....@gmail.com <v....@gmail.com> #3Feb 29, 2016 09:23PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

ai...@gmail.com <ai...@gmail.com> #4Apr 4, 2016 05:49AM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

nk...@google.com <nk...@google.com> Apr 4, 2016 06:23PM

Assigned to nk...@google.com.

ar...@gmail.com <ar...@gmail.com> #5Jul 4, 2016 02:46PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

nk...@google.com <nk...@google.com> #6Jul 6, 2016 08:51PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

be...@gmail.com <be...@gmail.com> #8Aug 10, 2016 02:21AM

Yes, this fix is planned to be included in a future 1.7.x release.

fr...@gmail.com <fr...@gmail.com> #9Feb 3, 2017 09:50AM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

xa...@gmail.com <xa...@gmail.com> #10Jun 19, 2017 01:10PM

Hi, is there any update on this bug?

vi...@gmail.com <vi...@gmail.com> #11Jun 20, 2017 11:35AM

Hi guys,
please give us an update about the fix for this :)

It's making making using Espresso extremely unpleasant

nk...@google.com <nk...@google.com> #12Jun 26, 2017 07:39PM

Marked as fixed.

Fixed in the next Runner/Rules v1.0 release.

to...@gmail.com <to...@gmail.com> #13Jul 20, 2017 09:27PM

It's been about a month. When will the v1.0 release of Rules/Runner be released?

su...@gmail.com <su...@gmail.com> #14Jul 26, 2017 05:01AM

1.0 is out. Anyone tests that out yet?

https://android-developers.googleblog.com/2017/07/android-testing-support-library-10-is.html?m=1

to...@gmail.com <to...@gmail.com> #15Jul 26, 2017 04:33PM

We just tried to update our runner/rules, but test suite crashed :) I guess we may need to update Espresso to 3.0 as well.

jc...@gmail.com <jc...@gmail.com> #16Apr 17, 2018 06:31AM

Any updates on this bug? Is this fixed?

nk...@google.com <nk...@google.com> #17Apr 17, 2018 07:28PM

Yes, this was fixed for a while now. Please give it a try with the latest version of our libraries.

nk...@google.com <nk...@google.com> #18Apr 17, 2018 07:28PM

Also we just made another public release, see release notes here:

https://developer.android.com/topic/libraries/testing-support-library/release-notes.html

da...@gmail.com <da...@gmail.com> #19May 23, 2018 10:22AM

Any other updates about this bug? I'm still issuing it with:
- androidTestImplementation 'com.android.support.test:runner:1.0.2'
- androidTestImplementation 'com.android.support.test:rules:1.0.2'
- androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
Tests always passes individually.
Running the suite instead, they have an unpredictable behavior: sometimes they passes, sometimes do not.

gu...@gmail.com <gu...@gmail.com> #20Jul 9, 2018 05:31PM

For some reason with databinding and static class I cannot debug code in ViewModel at every 2 test. Individually everything is just fine. espresso 3.0.2

gu...@gmail.com <gu...@gmail.com> #21Jul 10, 2018 11:35AM

This is works like this (everything is without package). In my View which is Activity I call onStart() and onPause() of ViewModel. In xml I have button with enabled set to MutableLiveData<Boolean> property in ViewModel. I write in Kotlin

//This is button enabled field update, each time when this MutableLiveData<Boolean> is called it prints this.toString()
PersonalViewModel@52cb180
PersonalViewModel@52cb180
PersonalViewModel@52cb180
PersonalViewModel@52cb180
PersonalViewModel@52cb180
PersonalViewModel@52cb180

//Second test start onStart() of ViewModel
START: PersonalViewModel@43321e0

PersonalViewModel@43321e0 //Calls button MutableLiveData<Boolean> for enabled property only ONCE

//Second test onPause() of ViewModel
PAUSE: PersonalViewModel@43321e0

//Third test start onStart() of ViewModel
START: PersonalViewModel@dc72c50
PersonalViewModel@dc72c50 //Calls button MutableLiveData<Boolean> for enabled property only ONCE
PAUSE: PersonalViewModel@dc72c50

When the second test starts it seems like it calls MutableLiveData<Boolean> property only once for button and then it fails to bind or something, because button is not updating anymore. Individually all tests work.