Assigned
Status Update
No update yet.
Comments
ja...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Suppress deprecate warning in AbstractSavedStateViewModelFactory tests
Expand for full commit details
Suppress deprecate warning in AbstractSavedStateViewModelFactory tests
Test: N/A
Bug: 388590327
Change-Id: Ibe2f04f4cb46f7d19d7fcab22ba2cecb4c82c68c
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/SavedStateFactoryTest.kt - M
lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt
Hash: c944a864317d80aeae8c5ee5812eb20eb1e3d0a8
Date: Mon Jan 13 17:39:17 2025
mi...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Deprecate AbstractSavedStateViewModelFactory in favor of CreationExtras API
Expand for full commit details
Deprecate AbstractSavedStateViewModelFactory in favor of CreationExtras API
`AbstractSavedStateViewModelFactory` is deprecated as it creates a `SavedStateHandle` for every `ViewModel`, causing unnecessary overhead. Use `ViewModelProvider.Factory` with `CreationExtras.createSavedStateHandle` instead for more efficient `ViewModel` creation.
- Updated KDoc with deprecation details and alternatives.
- Added `@Deprecated` annotation.
RelNote: "`AbstractSavedStateViewModelFactory` is deprecated as it creates a `SavedStateHandle` for every `ViewModel`, causing unnecessary overhead. Use `ViewModelProvider.Factory` with `CreationExtras.createSavedStateHandle` instead for more efficient `ViewModel` creation."
Test: N/A
Bug: 388590327
Change-Id: Ia920b66ccabde85a105cf4e6f80aa980270098ee
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/api/current.txt - M
lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt - M
lifecycle/lifecycle-viewmodel-savedstate/src/androidMain/kotlin/androidx/lifecycle/AbstractSavedStateViewModelFactory.android.kt
Hash: a3dcd46d7c08fa2d407aa9f8f91fb181aa342cc8
Date: Mon Jan 13 14:45:34 2025
pa...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-android:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-desktop:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-iosarm64:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-iossimulatorarm64:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-iosx64:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxarm64:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-linuxx64:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-macosarm64:2.9.0-alpha09androidx.lifecycle:lifecycle-viewmodel-savedstate-macosx64:2.9.0-alpha09
br...@gmail.com
It is in the essence of a "custom" UI component to have a custom color. Please add this feature!
ja...@gmail.com
I have noted that the status bar automatically generated from the toolbar color is a bit darker than needed. The status bar color of the chrome activity is different to the one of the rest of my app. It doesn't strictly follow Material guidelines.
ra...@gmail.com
The same issue I met. And is there a way to customize the title? using my own title rather than the url's. Thanks
al...@android.com
ma...@gmail.com
Would very appreciate this enhancement!
[Deleted User] <[Deleted User]>
I'd love to have the possibility to change title text color, I'll be a very important graphic consistency inside my app
mi...@gmail.com
Voting +1 for this feature.
[Deleted User] <[Deleted User]>
It has been more than a year. Please add this!
[Deleted User] <[Deleted User]>
[Comment deleted]
[Deleted User] <[Deleted User]>
It will certainly be a nice feature and have a nice title for the chrome tab. Please fix this.
bo...@gmail.com
Customize the status bar color is a real need. Voting +1
[Deleted User] <[Deleted User]>
Yes, it's needed definitely. Please!! Voting+1.
ma...@gmail.com
Any date to the release of this feature? Working with VectorDrawables is awesome and let us have an IconKit but this little impediment make it not perfect
ja...@gmail.com
Voting +1 for this feature.
mo...@gmail.com
Voting +1 for this feature.
m....@gmail.com
voting +1 for this feature
de...@gmail.com
Voting +1 for this feature.
me...@gmail.com
Voting +1 for this feature.
kr...@gmail.com
+1 from me. I really need this feature.
su...@gmail.com
+1 from me. I've to fallback my implementation to webview because of this graphic inconsistency.
ar...@connectmedica.com
Voting +1 for this feature.
ia...@gmail.com
Voting +1 for this feature.
ke...@pinxterapp.com
Voting +1 for this feature.
ni...@google.com
[Deleted User] <[Deleted User]>
Not being able to set a proper dark or light statusbar/toolbar icon color is breaking our app color design very bad.
+1 for this feature.
+1 for this feature.
ja...@gmail.com
Voting +1 for this feature.
[Deleted User] <[Deleted User]>
Estoy de acuerdo con este comentario, es molesto cuando el diseñador te levanta la mano porque no le convence el contraste de los colores y te es imposible responder con fundamento y suplir los criterios. Sería genial poder personalizar más esta sección.
ru...@gmail.com
This has been an issue for 6 years now. Why isn't Google dealing with it? If I'm to use Custom Tabs, I need to be able to change the toolbar text and color at will.
sa...@gmail.com
ช่วยแก้ไข browser ให้ผมหน่อยครับ
Description
However, for my app, the derived colors for both are noticeably different than the rest of my application. While the functionality of custom tabs is winning over the designer, they are not happy with the visual result.
Therefore, I'd like to be able to specify the status bar color to use with the custom tab (ie the primaryColorDark from my application). Seems reasonable if the developer doesn't specify a status bar color it uses the derived color as it does today.
As well I'd like to control the icon tint in the tool bar for the default "close" and "overflow" icons. While, specifying my own bitmap works around the "close" icon, the overflow icon tint is still controlled by the custom tab and may not match the overall theme.