IssueTracker

AndroidX currently sets AbstractTestTask.ignoreFailures when androidx.ignoreTestFailures=true is set. This is used when we run host tests via busytown/androidx_host_tests.sh. This is needed so that our build phase passes and then ATP host test forwarder runs, if we didn't set it, then the build would fail and ATP host test forwarder would never run. This set up also means that other failures (e.g. compilation failures) will fail the build and show these to the user, skipping the ATP test forwarding.

The downside of this set up is that it causes Gradle to store failed test tasks to remote cache because we tell it to ignore the test output.

This bug is a move away from AbstractTestTask.ignoreFailures.

From discussion with Gradle we could achieve this with the following:

• run our host test build with --continue
• set up a build work result listener and write to a file when the build failure is due to a failing test, then we know we can ignore ./gradlew exit code

Here is a rough draft of what the new settings plugin would look like

abstract class MyFlowParameters : FlowParameters {
    @get:Input
    abstract val failure: Property<Throwable?>
}

class MyFlowAction : FlowAction<MyFlowParameters> {
    override fun execute(parameters: MyFlowParameters) {
        val exception = parameters.failure.orNull ?: return
        if (exception is LocationAwareException &&
            exception.cause is TaskExecutionException &&
            (exception.cause as TaskExecutionException).task is AbstractTestTask
            ) {
            // write a file
        }
    }
}

abstract class MySettingsPlugin() : Plugin<Settings> {
    @get:Inject
    abstract val flowScope: FlowScope
    @get:Inject
    abstract val flowProviders: FlowProviders

    override fun apply(target: Settings) {
        flowScope.always(MyFlowAction::class.java) { spec ->
            spec.parameters.failure.set(flowProviders.buildWorkResult.map { it.failure.get() })
        }
    }
}