Status Update
Comments
nk...@google.com <nk...@google.com> #2
As a general note, what you're checking makes little sense - onAttachFragment
is called as fragments move through their lifecycle methods (specifically, right after onAttach()
is called on the fragment) and is therefore likely to be called while FragmentTransactions are being processed - if you have multiple commit()
s in flight, the state you get back in onAttachFragment
will certainly not be the final state the FragmentManager will be when all of the FragmentTransactions are executed, making this a bit of a meaningless check.
That being said, this is caused by the mechanism used to kick off transitions when reordering is not allowed, which is being reworked in
As a workaround, you can use setReorderingAllowed(true)
on your transaction, which will allow your example project to work correctly.
nk...@google.com <nk...@google.com> #3
This has been fixed internally and will be avilable in Fragment 1.3.0-alpha08.
Note: this fix relies on using the
Description
Version used: 0.5
* What steps will reproduce the problem?
1.Specify `size` argument for AndroidJUnitRunner by writing meta-data tag on AndroidManifest.xml of android test app (app/src/androidTest/AndroidManifest.xml file).
<instrumentation
android:name="android.support.test.runner.AndroidJUnitRunner"
android:targetPackage="...">
<meta-data android:name="size"
android:value="small"/>
</instrumentation>
2. Write test methods with @SmallSize annotation and @LargeTest annotation.
@RunWith(AndroidJUnit4.class)
public class TestActivityTest {
@Test
@LargeTest
public void largeTest() {
Assert.assertTrue(true);
}
@Test
@SmallTest
public void smallTest() {
Assert.assertTrue(true);
}
}
3. Run instrumented tests by `./gradlew connectedAndroidTest` command
* How are you running your tests (via Android Studio, Gradle, adb, etc.)?
Gradle (see above)
* What is the expected output? What do you see instead?
Expected : Run only method with @SmallTest annotation
(Javadoc says “All arguments can also be specified in the in the AndroidManifest via a meta-data tag”;
Actual : Run both methods with @SmallTest annotation and @LargeTest annotation
* Reason of this bug
1. AndroidJUnitRunner parses the manifest-provided args and then parses command line args ( See:
2. In RunnerArgs.Builder#fromBundle method, some arguments (for example test size, annotation, debug, etc.) are overridden with `null` EVEN IF they are not specified. ( See:
* How to fix
I think RunnerArgs.Builder#fromBundle method should read value only when the argument is specified.
- Before : this.testSize = bundle.getString(ARGUMENT_TEST_SIZE);
- After : if (bundle.containsKey(ARGUMENT_TEST_SIZE)) this.testSize = bundle.getString(ARGUMENT_TEST_SIZE);
Thanks.