Status Update
No update yet.
Comments
nk...@google.com
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
nk...@google.com
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
Description
Version used: 0.5
* What steps will reproduce the problem?
1.Specify `size` argument for AndroidJUnitRunner by writing meta-data tag on AndroidManifest.xml of android test app (app/src/androidTest/AndroidManifest.xml file).
<instrumentation
android:name="android.support.test.runner.AndroidJUnitRunner"
android:targetPackage="...">
<meta-data android:name="size"
android:value="small"/>
</instrumentation>
2. Write test methods with @SmallSize annotation and @LargeTest annotation.
@RunWith(AndroidJUnit4.class)
public class TestActivityTest {
@Test
@LargeTest
public void largeTest() {
Assert.assertTrue(true);
}
@Test
@SmallTest
public void smallTest() {
Assert.assertTrue(true);
}
}
3. Run instrumented tests by `./gradlew connectedAndroidTest` command
* How are you running your tests (via Android Studio, Gradle, adb, etc.)?
Gradle (see above)
* What is the expected output? What do you see instead?
Expected : Run only method with @SmallTest annotation
(Javadoc says “All arguments can also be specified in the in the AndroidManifest via a meta-data tag”;
Actual : Run both methods with @SmallTest annotation and @LargeTest annotation
* Reason of this bug
1. AndroidJUnitRunner parses the manifest-provided args and then parses command line args ( See:
2. In RunnerArgs.Builder#fromBundle method, some arguments (for example test size, annotation, debug, etc.) are overridden with `null` EVEN IF they are not specified. ( See:
* How to fix
I think RunnerArgs.Builder#fromBundle method should read value only when the argument is specified.
- Before : this.testSize = bundle.getString(ARGUMENT_TEST_SIZE);
- After : if (bundle.containsKey(ARGUMENT_TEST_SIZE)) this.testSize = bundle.getString(ARGUMENT_TEST_SIZE);
Thanks.