Compose 1.8.0 alpha 3 broke fling [371168883]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Oct 3, 2024 02:55PM

Jetpack Compose version: Compose 1.8.0 alpha 3

Jetpack Compose component(s) used: Many

I'm not sure yet how to reproduce yet but see attached video.

The first screen is a Horizontal Lazy in a vertical one with snapfling.
On first display the fling works in both directions.
Scroll away then scrollback to redraw the Horizontal lazy then the fling does not work to right as you can see the overscroll effect runs all the time.

The second screen is an VerticalLazy on first display it can fling down but have the same issue when fling up.
Moving away then drawing away fixed this.

I can sometimes rarely, break the fling in the opposite direction on the first screen with the Horizontal one.

I'm a little puzzled by the difference between the screens when one works then don't work on redisplay, but the other is the opposite it first don't work then works.

Screen_recording_20241003_164949.mp4

24 MB

Download

Comments

to...@gmail.com <to...@gmail.com> #2Oct 3, 2024 02:58PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

le...@google.com <le...@google.com> #3Oct 3, 2024 03:04PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

to...@gmail.com <to...@gmail.com> #4Oct 3, 2024 03:07PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

le...@google.com <le...@google.com> #5Oct 3, 2024 03:11PM

Reassigned to le...@google.com.

deleted

to...@gmail.com <to...@gmail.com> #6Oct 3, 2024 03:18PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Oct 7, 2024 06:28PM

Marked as fixed.

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

to...@gmail.com <to...@gmail.com> #8Oct 8, 2024 10:22AM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

le...@google.com <le...@google.com> #9Oct 8, 2024 10:23AM

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭

to...@gmail.com <to...@gmail.com> #10Oct 8, 2024 10:27AM

Works perfectly fine on the latest stable and alpha versions. Did you check in my second comment if you enabled everything?

na...@google.com <na...@google.com> #11Oct 16, 2024 05:48PM

I believe so?

I copied the modifier and then used

modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    )

on my text field.