Links from Android SDK Upgrade Assistant point to internal Google documentation [371219677]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Oct 4, 2024 10:00AM

Issue summary:
When clicking on some links from the Android SDK Upgrade Assistant (Android 14 -> Android 15) I get redirected to the Google internal Single Sign On.

Example of such link:

https://login.corp.google.com/request?s=android.devsite.corp.google.com:443/uberproxy/&d=https://android.devsite.corp.google.com/reference/java/lang/String%3Fupxsrf%3DAFJ1ERMYy3sGxkSe70exyKUg3Cl-q06hu_AW3u5nVS3CQS494g:1728035664298&maxAge=1200&authLevel=2000000&keyIds=DU5,2O9,Ju3,A_Z&3pd=1&c=1#format(java.lang.String,%20java.lang.Object%5B%5D)
when clicking on String.format(String, Object[]).

Wjen clicking on Locale:

https://login.corp.google.com/request?s=android.devsite.corp.google.com:443/uberproxy/&d=https://android.devsite.corp.google.com/reference/java/util/Locale%3Fupxsrf%3DAFJ1ERM1E62QFA1Jm0tw6Cu8OtGRTNIcDy1Gy78cHd_GzpKO1w:1728035741276&maxAge=1200&authLevel=2000000&keyIds=DU5,2O9,Ju3,A_Z&3pd=1&c=1

All of the links that should link to the OpenJDK seem to be wrongly linked.

Included are screenshots thatilustrate links that are redirecting to the internal documentation.

Build: AI-242.21829.142.2421.12409432, 202409242130
AS: Ladybug | 2024.2.1
AI-242.21829.142.2421.12409432, JRE 21.0.3+-12282718-b509.11x64 JetBrains s.r.o., OS Windows 11(amd64) v10.0 , screens 1920x1080 (100%), 1920x1200 (100%), 1920x1200 (100%)
Android Gradle Plugin: 8.4.1
Gradle: 8.6
Gradle JDK: JetBrains Runtime 17.0.11
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
```

Comments

hs...@google.com <hs...@google.com> Oct 4, 2024 04:50PM

Assigned to an...@google.com.

er...@google.com <er...@google.com> Oct 9, 2024 08:22PM

Reassigned to er...@google.com.

er...@google.com <er...@google.com> #2Oct 10, 2024 12:03AM

Marked as fixed.

I don't think the average developer understands the distinction between method references and method definitions in this context (inside a DEX file). I know I don't.

@jvg, can you elaborate?

an...@google.com <an...@google.com> #3Oct 14, 2024 05:58PM

people who are looking at the bytecode in the dex to optimize their app through shrinking hopefully will learn the difference as string tables for method references between various dex files can account for quite a bit of disk space. but more importantly a definition is something you can analyze its code for where a reference you can't so the UI can be confusing without seeing the difference

an...@google.com <an...@google.com> #4Oct 14, 2024 09:08PM

How about something like this?

I think having defined members be directly under the class node while references are nested in a group makes more sense.

Also note that the method refs have a slightly different icon. There is no existing equivalent for field refs that I could find.

https://screenshot.googleplex.com/4yXVM9Rzh4wnkjM.png

pu...@gmail.com <pu...@gmail.com> #5Oct 29, 2024 02:47PM

sounds reasonable to me, thanks

cr...@gmail.com <cr...@gmail.com> #6Nov 22, 2024 08:10AM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 4
Android Gradle Plugin 8.8.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

pe...@gmail.com <pe...@gmail.com> #7Dec 13, 2024 10:27AM

sh...@gmail.com <sh...@gmail.com> #8
Restricted
Dec 26, 2024 09:44AM

Comment has been deleted.