DayNight theme is changed when WebView is inflated [37124582]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Oct 25, 2016 02:49PM

Library used: appcompat-v7
Version used: 25.0.0
Theme used: Theme.AppCompat.DayNight
Devices/Android versions reproduced on: Nexus 5x, Nexus 6 - Android 7.0

The activity containing a WebView is recreated (from onStart() method) because uiMode is changed when WebView is being created (inside its constructor). This only happens on the first WebView inflation.

Steps to reproduce this bug:

1º - Set the default night mode to AppCompatDelegate.MODE_NIGHT_YES on application class.
2º - Add a WebView to layout file (in the attached example a CustomWebView has been created only for logs purposes, common WebView has the same effect).
3º - Launch the app and the activity is recreated.

In appcompat-v7 versions previous to 24.2.0 the activity is not recreated but the uiMode is changed too.

Here some logs from:

Main: Before onCreate super() - Mode night active: false
Main: After onCreate super() - Mode night active: true
CustomWebView: Before constructor super() - Mode night active: true
CustomWebView: After constructor super() - Mode night active: false
Main: Before onCreate super() - Mode night active: false
Main: After onCreate super() - Mode night active: true
CustomWebView: Before constructor super() - Mode night active: true
CustomWebView: After constructor super() - Mode night active: true

DayNightTheme.zip

482 KB

Download

Comments

mi...@gmail.com <mi...@gmail.com> #2Oct 25, 2016 02:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

ch...@google.com <ch...@google.com> #3Jan 11, 2017 12:43AM

Assigned to ch...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

mn...@gmail.com <mn...@gmail.com> #4Jan 11, 2017 03:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

ch...@google.com <ch...@google.com> #5Jan 11, 2017 03:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

mn...@gmail.com <mn...@gmail.com> #6Jan 11, 2017 03:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

jo...@nuzzel.com <jo...@nuzzel.com> #7May 23, 2017 06:12AM

Project: platform/frameworks/support
Branch: androidx-main

commit 324a9ebeb0c23ca0113a925c83a4b90a74c7dc54
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:57:01 2022

Rename OnBackPressedCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I3645ebd21c0ea9c243fad3007bdd3d2472806dcc

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288078

ch...@google.com <ch...@google.com> May 23, 2017 08:16AM

Reassigned to ki...@google.com.

mn...@gmail.com <mn...@gmail.com> #8May 23, 2017 05:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit a6ec8cc8df1fd6e8a4407ad15569d77914e9adb3
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 25 00:05:20 2023

Move OnBackPressedDispatcher extension to main artifact

As the main activity artifact is automatically included
whenever a developer depends on activity-ktx and these are
in an atomic library group, we can move the Kotlin
extension from activity-ktx to activity itself now that
the class itself has been moved to Kotlin.

Relnote: n/a
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I13482de2e25bd6e084f4b299dddd43b2bcf7a4c7

A activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
A activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
D activity/activity-ktx/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401943

ki...@google.com <ki...@google.com> #9May 23, 2017 07:09PM

Reassigned to al...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit d54d4417476c5ddc37251a910bdf37e9d278357e
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:57:45 2023

Replace usages of Consumer with a lambda

Now that OnBackPressedCallback and
OnBackPressedDispatcher are both written in Kotlin,
we can convert the callback between the two to be a
lambda method, rather than using a Consumer<Boolean>.

Test: tests still pass
BUG: 257291701
Change-Id: I0e2e4a3e7e9d6a3aeab1b8d2283fff321d45f44f

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401942

al...@google.com <al...@google.com> #10May 23, 2017 07:32PM

Reassigned to ch...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 453e6f7acd7b7a1310487fc912f78c0fd2e72dd3
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:43:12 2023

Convert OnBackPressedDispatcher to Kotlin

Relnote: "`OnBackPressedDispatcher` is now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I18ac79d3cd20fc29159542b729935d3b8d2e4506

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401941

al...@google.com <al...@google.com> #11May 23, 2017 07:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57dd231f03ef3f5d107f7c9be9b0f5dd200d7ec4
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:01:48 2023

Rename OnBackPressedDispatcher.java to .kt

Test: n/a
BUG: 257291701
Change-Id: Id490de8b28b7d2a680c76c822f564fdadd5eb5f1

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401940

ki...@google.com <ki...@google.com> #12May 23, 2017 08:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 76fcc8653339d275c9bfad10e4c68cd9c8ef0dfd
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 27 00:45:07 2023

Update wear module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iaf4f466f38a23c5522de019d38080b04c9f7b7ff

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt

https://android-review.googlesource.com/2405513

nightmodeTabsNotStyled.png

143 KB

View

Download

mn...@gmail.com <mn...@gmail.com> #13May 23, 2017 08:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit a63f1351aab5e387a829711f14de221274119bcd
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 22:51:46 2023

Update navigation module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iad795301ff2e6a16b42be6b85e6370ac399e43fd

M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt

https://android-review.googlesource.com/2404345

ki...@google.com <ki...@google.com> #14May 23, 2017 08:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit fa9a4dd728bc575c6e3536f2d5f9564f50b8eeee
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 19:33:26 2023

Update compose module with OnBackPressedDispatcherOwner

With the move to OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: If45fa4c4624a0a71745f4f11f133a3eddcf4dddf

M compose/ui/ui-tooling/build.gradle
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt

https://android-review.googlesource.com/2404338

mn...@gmail.com <mn...@gmail.com> #15May 23, 2017 08:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit 322bd9508ff202efcdb765778d76baa5fe98795b
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 19:05:37 2023

Convert OnBackPressedDispatcherOwner to Kotlin

Relnote: "`OnBackPressedDispatcherOwner` is now written
in Kotlin. This is a **source incompatible change** for those
classes written in Kotlin - you must now override the
`onBackPressedDispatcher` property rather than implementing
the previous `getOnBackPressedDispatcher` function."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: Ia277dc57731597b869c4e86d3f8c13896a6ce56f

M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackHandlerTest.kt
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackPressedDispatcherOwnerTest.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ViewTreeOnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcherOwner.kt

https://android-review.googlesource.com/2404337

ki...@google.com <ki...@google.com> #16May 23, 2017 08:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit c0ae191b22d3b679c0282ebfad7cc35670afc3b4
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 18:24:49 2023

Rename OnBackPressedDispatcherOwner.java to .kt

Part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: Ic0b969a9f98d461ec48195309989f740891ebb9f

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcherOwner.kt

https://android-review.googlesource.com/2404336

mn...@gmail.com <mn...@gmail.com> #17May 23, 2017 08:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit c83511c81d5fd0c87577180301ca1b1231d24c13
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 18:44:32 2023

Update compose module with ActivityResultRegistryOwner

With the move of ActivityResultRegistryOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: I490b9b69d5bd4d9c608ca8d3c9a196d3e70fe801

M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt

https://android-review.googlesource.com/2407774

ch...@google.com <ch...@google.com> #18May 25, 2017 09:47AM

Project: platform/frameworks/support
Branch: androidx-main

commit 74e5a4b559f319808f1addeb4d1bc46d4267ccdb
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 18:38:17 2023

Convert ActivityResultRegistryOwner to Kotlin

Relnote: "`ActivityResultRegistryOwner` is now written
in Kotlin. This is a **source incompatible change**
for those classes written in Kotlin - you must now
override the `activityResultRegistry` property rather
than implementing the previous
`getActivityResultRegistry()` function."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: I0b00efc873c16e5b6d26e9ebad889f00a8ddb6b3

M activity/activity-compose/src/androidTest/java/androidx/activity/compose/ActivityResultRegistryTest.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistryOwner.kt

https://android-review.googlesource.com/2407773

mn...@gmail.com <mn...@gmail.com> #19May 25, 2017 09:48AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7f1a7dcb8a6eb73cc3a54ab161a2c8bfebea48ca
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 18:34:24 2023

Rename ActivityResultRegistryOwner.java to .kt

Part of the Kotlin conversion process

Test: n/a
BUG: 257291701
Change-Id: I2e786c6192e2747bf91105f4a1c18703baa0dda7

M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistryOwner.kt

https://android-review.googlesource.com/2407772

ch...@google.com <ch...@google.com> Aug 29, 2017 07:17AM

Reassigned to ki...@google.com.

ki...@google.com <ki...@google.com> Sep 7, 2018 06:50PM

Reassigned to ch...@google.com.

[Deleted User] <[Deleted User]> #20Sep 11, 2018 04:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit c2189c5497529ac8cb8d7e01ac1605c72e029ef2
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 31 00:21:00 2023

Convert IntentSenderRequest to Kotlin

Relnote: "`IntentSenderRequest` is now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: Ib7e74b794dc11ca4ad53bb6145c79f0f63d9c69d

A activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
A activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/result/IntentSenderRequest.kt

https://android-review.googlesource.com/2410754

da...@gmail.com <da...@gmail.com> #21Sep 12, 2018 06:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8acdae64bc8e603c57a9d50422592b48a063d6d0
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 23:55:36 2023

Rename IntentSenderRequest.java to .kt

Part of the Kotlin conversion process

Test: n/a
BUG: 257291701
Change-Id: I296f10e0a69e68e618a72aa447d08ab7f6daf518

M activity/activity/src/main/java/androidx/activity/result/IntentSenderRequest.kt

https://android-review.googlesource.com/2410752

ch...@google.com <ch...@google.com> #22Jan 30, 2019 04:50AM

Project: platform/frameworks/support
Branch: androidx-main

commit e4a7c287c679487bb576d4865be865b4364dc0c6
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 23:37:12 2023

Move ContextAware Kotlin extension to activity artifact

Migrate the ContextAware.withContextAvailable extension
to the main activity artifact to ensure there is only one
ContextAware.kt class.

Relnote: "The `ContextAware.withContextAvailable` Kotlin
extension has been moved from `activity-ktx` to `activity`."
Test: moved tests still work
BUG: 257291701

Change-Id: Iada9260aa0d006aeea976d08713e171285848d7f

M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/contextaware/ContextAwareTest.kt
D activity/activity-ktx/src/main/java/androidx/activity/contextaware/ContextAware.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.kt

https://android-review.googlesource.com/2407784

ch...@google.com <ch...@google.com> #23Feb 10, 2019 10:57PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 221a1adae23c6ead5b14d5764770a6770deabe14
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 23:22:14 2023

Convert androidx.activity.contextaware to Kotlin

Relnote: "The `ContextAware`, `OnContextAvailableListener`, and
`ContextAwareHelper` are now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: I1a73e84b3742edf18db69c18722f61b8bc49548b

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.kt
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.kt
M activity/activity/src/main/java/androidx/activity/contextaware/OnContextAvailableListener.kt

https://android-review.googlesource.com/2407783

xw...@gmail.com <xw...@gmail.com> #24Feb 13, 2019 09:52AM

Project: platform/frameworks/support
Branch: androidx-main

commit e1b5ac1d24a726aec0e8a76f6dd2bd604a91cc83
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 23:14:43 2023

Rename androidx.activity.contextaware classes to .kt

Part of the Kotlin conversion process

Test: n/a
BUG: 257291701
Change-Id: I3876d8a04ba08e8ee13eb18966ef2a858ace69f3

M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.kt
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.kt
M activity/activity/src/main/java/androidx/activity/contextaware/OnContextAvailableListener.kt

https://android-review.googlesource.com/2407782

ja...@gmail.com <ja...@gmail.com> #25Feb 25, 2019 08:08PM

Does this issue allow submitting patches from external contributors, i.e., from people not working in the team? If so, then I would like to contribute!

ch...@google.com <ch...@google.com> #26Feb 25, 2019 08:34PM

Yes we do accept external contributions through our github repo. Please checkout out our contribution guide for how to set up your env and submit PRs.

https://github.com/androidx/androidx#contribution-guide

Looking forward your PR!

ja...@gmail.com <ja...@gmail.com> #27Feb 25, 2019 09:11PM

Thanks! But I'm having trouble on setting up the activity project. I'm getting the following error:

Could not compile build file '...\playground-build.gradle': 17: unable to resolve class androidx.build.AndroidXPlaygroundRootPlugin

I know this isn't the right place to ask but I don't know where else to ask for solution. So could you please help me fix this?

ja...@gmail.com <ja...@gmail.com> #28Mar 14, 2019 05:37PM

Can you file a bug to https://issuetracker.google.com/issues/new?component=923725&template=1480355? Thanks.

ch...@google.com <ch...@google.com> #29Mar 14, 2019 08:33PM

No entiendo

El lun, 27 de mar de 2023, 1:51 p. m., <buganizer-system@google.com>
escribió:

- Show quoted text -

mi...@dailymotion.com <mi...@dailymotion.com> #30Nov 26, 2019 02:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0c09a4261521a13ec74c8bc3f018aa71bd1aeecc
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 11 21:23:39 2023

Convert *Info classes passed to Providers to Kotlin

Along with the actual On*Provider interfaces, the
*Info classes that those Providers sent to their
respective Consumers should also be converted to Kotlin.

Relnote: "The `MultiWindowModeChangedInfo` and
`PictureInPictureModeChangedInfo` classes that are sent
to the `Consumer` added to their respective Provider
interfaces are now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: Ie08e292c77dc66634a0b474a63df0ac31f34f87e

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/MultiWindowModeChangedInfo.kt
M core/core/src/main/java/androidx/core/app/PictureInPictureModeChangedInfo.kt

https://android-review.googlesource.com/2783740

ro...@gmail.com <ro...@gmail.com> #31Jan 19, 2020 02:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit cf02af882cbb41d0e39b0068fed7945d19792241
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 11 21:04:44 2023

Rename *Info classes passed to Provider to .kt

In preparation for their conversion to Kotlin,
the Info classes that are passed to the On*Provider
Consumers should be renamed to .kt.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Ibc3e77d18ec6e29f39d3632852e100a78674aa04

M core/core/src/main/java/androidx/core/app/MultiWindowModeChangedInfo.kt
M core/core/src/main/java/androidx/core/app/PictureInPictureModeChangedInfo.kt

https://android-review.googlesource.com/2782306

ga...@gmail.com <ga...@gmail.com> #32Apr 10, 2020 03:37AM

Project: platform/frameworks/support
Branch: androidx-main

commit cfb6baf849d42492bf39aaa521aded8000258ef6
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 11 20:44:39 2023

Rename On*Provider interfaces from .java to .kt

In preparation for their conversion to Kotlin.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: I22f7206360e68208a872b49d696abf30fff214cd

M core/core/src/main/java/androidx/core/app/OnMultiWindowModeChangedProvider.kt
M core/core/src/main/java/androidx/core/app/OnNewIntentProvider.kt
M core/core/src/main/java/androidx/core/app/OnPictureInPictureModeChangedProvider.kt
M core/core/src/main/java/androidx/core/content/OnConfigurationChangedProvider.kt
M core/core/src/main/java/androidx/core/content/OnTrimMemoryProvider.kt

https://android-review.googlesource.com/2782304

xj...@gmail.com <xj...@gmail.com> #33May 24, 2020 10:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8b143a2d354ea97ac6457d9654357b891db90ba1
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 11 20:53:22 2023

Convert On*Provider interfaces to Kotlin

Ensure that the Consumer passed to each
Provider's add*Listener and remove*Listener
has the appropriate nullability.

Relnote: "The `OnMultiWindowModeChangedProvider`,
`OnNewIntentProvider`,
`OnPictureInPictureModeChangedProvider`,
`OnConfigurationChangedProvider`,
and `OnTrimMemoryProvider` interfaces have been
converted to Kotlin to ensure that the generic
parameters on the `Consumer` that their listener
methods take have the correct nullability (they
are all non-null)."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: Ib62377a0f6002806074a05126cf6a9ca8c78dcbf

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/OnMultiWindowModeChangedProvider.kt
M core/core/src/main/java/androidx/core/app/OnNewIntentProvider.kt
M core/core/src/main/java/androidx/core/app/OnPictureInPictureModeChangedProvider.kt
M core/core/src/main/java/androidx/core/content/OnConfigurationChangedProvider.kt
M core/core/src/main/java/androidx/core/content/OnTrimMemoryProvider.kt

https://android-review.googlesource.com/2782305

[Deleted User] <[Deleted User]> #34Aug 6, 2020 03:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit e4b914d4f0ce94d49d6a1fa1d19ba8864c415750
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 17 20:09:07 2023

Upgrade Core to use Lifecycle 2.6.2

As Lifecycle 2.6 has source breaking changes
for classes written in Kotlin, moving classes
(such as Core's ComponentActivity) to Kotlin
causes issues when run with maxDepVersions.

By updating Core to depend on Lifecycle 2.6.2,
we ensure that maxDepVersions won't cause
issues in subsequent upgrades.

Relnote: "Core now depends on
[Lifecycle `2.6.2`](/jetpack/androidx/releases/lifecycle#2.6.2)."
Test: ./gradlew core:core:build
BUG: 257291701

Change-Id: I2d94c8b7fc3fb3bb59547d56a5d2f06584f1b5a4

M core/core/build.gradle

https://android-review.googlesource.com/2796599

[Deleted User] <[Deleted User]> #35Aug 18, 2020 03:34AM

Project: platform/frameworks/support
Branch: androidx-main

commit 6a74b4839f791578491d0007f440e395274e89ae
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 17 21:22:13 2023

Convert Core ComponentActivity to Kotlin

Switch to the new lifecycle property from
Lifecycle 2.6 as part of the Kotlin conversion
of Core's ComponentActivity.

As Kotlin warns if parameter names are different
from their super class names, we update other
classes to use savedInstanceState as the parameter
to onCreate().

Relnote: n/a
Test: ./gradlew core:core:checkApi
BUG: 257291701
Change-Id: Ib395e5da26427aa0d2831da2b7a5d1bdcb8ad22e

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/ComponentActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentFinishEarlyTest.kt
M glance/glance-wear-tiles/integration-tests/demos/src/main/java/androidx/glance/wear/tiles/demos/TilePreviewActivity.kt
M glance/glance-wear-tiles/integration-tests/template-demos/src/main/java/androidx/glance/wear/tiles/template/demos/TilePreviewActivity.kt

https://android-review.googlesource.com/2797916

[Deleted User] <[Deleted User]> #36Aug 28, 2020 10:48AM

Project: platform/frameworks/support
Branch: androidx-main

commit 9ab92ca29baf2fab19bc2468e77a965890d1188a
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 17 20:41:42 2023

Rename Core ComponentActivity.java to .kt

In preparation for its conversion to Kotlin.

Test: ./gradlew core:core:build
BUG: 257291701
Change-Id: I273bb3d972cb1020b2a1c187a51770be33919d0d

M core/core/src/main/java/androidx/core/app/ComponentActivity.kt

https://android-review.googlesource.com/2797915

kr...@gmail.com <kr...@gmail.com> #37Oct 8, 2020 09:12AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4e57779ea244552e66b28f29a24b4a7604e80fe1
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 10 23:26:58 2023

Convert ComponentActivity to Kotlin

Rewrite ComponentActivity in Kotlin.

Test: ./gradlew activity:activity:checkApi
BUG: 257291701
Relnote: "`ComponentActivity` has been rewritten in
Kotlin."
Relnote: "Activity now depends on
[Core `1.13.0-alpha01`](/jetpack/androidx/releases/core#1.13.0-alpha01)."

Change-Id: I14f312d6879ce6c91496112fb6b171f81cdbddf2

M activity/activity/api/api_lint.ignore
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/build.gradle
M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/CameraValidationResultActivity.kt
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/ExtensionValidationResultActivity.kt
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/ImageValidationActivity.kt
M camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/viewpager/ViewPager2Activity.kt
M camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/viewpager/ViewPagerActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/FragmentTestActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/NewIntentActivity.kt
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/HelpActivity.kt

https://android-review.googlesource.com/2797917

ca...@seadowg.com <ca...@seadowg.com> #38Aug 30, 2021 03:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit fff2ee271b53d0ca453696ba4025ba0f4fffc9b5
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 10 21:15:08 2023

Rename ComponentActivity.java to ComponentActivity.kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I72433e8a00676fa5173b6a7ee273afe7db187b4f

M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt

https://android-review.googlesource.com/2797835

sl...@pentacomp.pl <sl...@pentacomp.pl> #39Apr 26, 2022 08:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit 86cc08969d868fd7508c15db6f518cce9bcc28ef
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 25 20:08:59 2023

Convert ActivityResultLauncher to Kotlin

Rewrite ActivityResultLauncher in Kotlin.

The getContract() method is now an abtract Kotlin
property.

This also moves the `ActivityResultLauncher` Kotlin
extensions from `activity-ktx` back to `activity` since
we can't have two Kotlin files with the same name.

Relnote: "`ActivityResultLauncher` has been rewritten in
Kotlin. As part of that conversion, the `getContract` method
is now an abstract Kotlin property. This is a binary compatible
change, but source breaking if your implementation of
`ActivityResultLauncher` is written in Kotlin."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: Id4615d19b383b2438be6a8f68da7584394d13515

M activity/activity-compose/api/current.ignore
M activity/activity-compose/api/current.txt
M activity/activity-compose/api/restricted_current.ignore
M activity/activity-compose/api/restricted_current.txt
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/ActivityResultRegistryTest.kt
M activity/activity-compose/src/main/java/androidx/activity/compose/ActivityResultRegistry.kt
M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/result/ActivityResultLauncherTest.kt
M activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultCaller.kt
D activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultLauncher.kt
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityResultTest.kt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultLauncherTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultLauncher.kt

https://android-review.googlesource.com/2804284

ta...@gmail.com <ta...@gmail.com> #40Sep 22, 2022 05:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit e91ba67bdd4ef797487b8d757a2ac771a1cfc60a
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 25 20:00:49 2023

Rename ActivityResultLauncher.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I19348e67afb8fe2f1ca9f5483e31fe8edfa29e8a

M activity/activity/src/main/java/androidx/activity/result/ActivityResultLauncher.kt

https://android-review.googlesource.com/2804283

ki...@google.com <ki...@google.com> Sep 22, 2022 05:48PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> Sep 22, 2022 06:41PM

Reassigned to an...@google.com.

dm...@gmail.com <dm...@gmail.com> #41Feb 1, 2023 08:17AM

Project: platform/frameworks/support
Branch: androidx-main

commit d949529d18ac83c6775c7824138b52eb544cdf1c
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 27 17:34:57 2023

Make ComponentActivity.onNewIntent take a non-null Intent

This Intent is always non-null so we should mark
it as such until the framework is updated to also
make it non-null.

Test: ./gradlew activity:activity:checkApi
BUG: 257291701
Change-Id: Ia694837203011f1c6aa611aea6c20f1b7473af1b

M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityCallbacksTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/NewIntentActivity.kt
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitActivityDetail.kt

https://android-review.googlesource.com/2808359

da...@grupoasesores.com.mx <da...@grupoasesores.com.mx> #42Mar 28, 2023 03:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit dc886d9a2f535799cbf4bc6ae4ed5f98b3a8c2fb
Author: Ian Lake <ilake@google.com>
Date: Thu Oct 26 22:47:00 2023

Rename ActivityResultCaller.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I39957d5e2e01d634d6f2ff2f4b440dc8af19bb37

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCaller.kt

https://android-review.googlesource.com/2806974

pu...@gmail.com <pu...@gmail.com> #43Sep 21, 2023 11:18AM

Project: platform/frameworks/support
Branch: androidx-main

commit 1ac2124d0e27761bc7f09d122d99254c69411631
Author: Ian Lake <ilake@google.com>
Date: Thu Oct 26 23:03:00 2023

Convert ActivityResultCaller to Kotlin

Rewrite ActivityResultCaller to Kotlin.

This also moves the `ActivityResultCaller` Kotlin
extensions from `activity-ktx` back to `activity` since
we can't have two Kotlin files with the same name+package.

Relnote: "`ActivityResultCaller` has been rewritten in
Kotlin."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: Ib02e49c49dbed2ce0d25ac71c8caf0325ffb8142

M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
M activity/activity-ktx/src/androidTest/AndroidManifest.xml
D activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultCaller.kt
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/AndroidManifest.xml
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultCallerTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCaller.kt

https://android-review.googlesource.com/2805770

Message last modified on Sep 21, 2023 11:27AM

ab...@gmail.com <ab...@gmail.com> #44Dec 16, 2024 01:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2b9627fa602319fc8f0da026da1d6a2eb69c8fb5
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 14 00:51:20 2023

Convert ActivityResult to Kotlin

Rewrite ActivityResult in Kotlin.

This makes the resultCode and data getters into
public properties.

This also moves the ActivityResult Kotlin extensions
from activity-ktx back to activity since we can't
have two Kotlin files with the same name.

Relnote: "`ActivityResult` has been rewritten in Kotlin. The
`ActivityResult` Kotlin extensions that support destructuring
into the `resultCode` and `data` fields have been moved from
`activity-ktx` to `activity`."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: I0565a95aa4470a4cd23dcddf75df3f9dd8dca19e

M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResult.kt
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResult.kt

https://android-review.googlesource.com/2875054

Issue 37124582

Description

Issue summary

Comments

mi...@gmail.com <mi...@gmail.com> #2Oct 25, 2016 02:56PM

ch...@google.com <ch...@google.com> #3Jan 11, 2017 12:43AM

mn...@gmail.com <mn...@gmail.com> #4Jan 11, 2017 03:01PM

ch...@google.com <ch...@google.com> #5Jan 11, 2017 03:10PM

mn...@gmail.com <mn...@gmail.com> #6Jan 11, 2017 03:12PM

jo...@nuzzel.com <jo...@nuzzel.com> #7May 23, 2017 06:12AM

ch...@google.com <ch...@google.com> May 23, 2017 08:16AM

mn...@gmail.com <mn...@gmail.com> #8May 23, 2017 05:04PM

ki...@google.com <ki...@google.com> #9May 23, 2017 07:09PM

al...@google.com <al...@google.com> #10May 23, 2017 07:32PM

al...@google.com <al...@google.com> #11May 23, 2017 07:56PM

ki...@google.com <ki...@google.com> #12May 23, 2017 08:02PM

mn...@gmail.com <mn...@gmail.com> #13May 23, 2017 08:14PM

ki...@google.com <ki...@google.com> #14May 23, 2017 08:16PM

mn...@gmail.com <mn...@gmail.com> #15May 23, 2017 08:19PM

ki...@google.com <ki...@google.com> #16May 23, 2017 08:24PM

mn...@gmail.com <mn...@gmail.com> #17May 23, 2017 08:26PM

ch...@google.com <ch...@google.com> #18May 25, 2017 09:47AM

mn...@gmail.com <mn...@gmail.com> #19May 25, 2017 09:48AM

ch...@google.com <ch...@google.com> Aug 29, 2017 07:17AM

ki...@google.com <ki...@google.com> Sep 7, 2018 06:50PM

[Deleted User] <[Deleted User]> #20Sep 11, 2018 04:19PM

da...@gmail.com <da...@gmail.com> #21Sep 12, 2018 06:10AM

ch...@google.com <ch...@google.com> #22Jan 30, 2019 04:50AM

ch...@google.com <ch...@google.com> #23Feb 10, 2019 10:57PM

xw...@gmail.com <xw...@gmail.com> #24Feb 13, 2019 09:52AM

ja...@gmail.com <ja...@gmail.com> #25Feb 25, 2019 08:08PM

ch...@google.com <ch...@google.com> #26Feb 25, 2019 08:34PM

ja...@gmail.com <ja...@gmail.com> #27Feb 25, 2019 09:11PM

ja...@gmail.com <ja...@gmail.com> #28Mar 14, 2019 05:37PM

ch...@google.com <ch...@google.com> #29Mar 14, 2019 08:33PM

mi...@dailymotion.com <mi...@dailymotion.com> #30Nov 26, 2019 02:11PM

ro...@gmail.com <ro...@gmail.com> #31Jan 19, 2020 02:30PM

ga...@gmail.com <ga...@gmail.com> #32Apr 10, 2020 03:37AM

xj...@gmail.com <xj...@gmail.com> #33May 24, 2020 10:48PM

[Deleted User] <[Deleted User]> #34Aug 6, 2020 03:10AM

[Deleted User] <[Deleted User]> #35Aug 18, 2020 03:34AM

[Deleted User] <[Deleted User]> #36Aug 28, 2020 10:48AM

kr...@gmail.com <kr...@gmail.com> #37Oct 8, 2020 09:12AM

ca...@seadowg.com <ca...@seadowg.com> #38Aug 30, 2021 03:32PM

sl...@pentacomp.pl <sl...@pentacomp.pl> #39Apr 26, 2022 08:44AM

ta...@gmail.com <ta...@gmail.com> #40Sep 22, 2022 05:39PM

ki...@google.com <ki...@google.com> Sep 22, 2022 05:48PM

al...@google.com <al...@google.com> Sep 22, 2022 06:41PM

dm...@gmail.com <dm...@gmail.com> #41Feb 1, 2023 08:17AM

da...@grupoasesores.com.mx <da...@grupoasesores.com.mx> #42Mar 28, 2023 03:31AM

pu...@gmail.com <pu...@gmail.com> #43Sep 21, 2023 11:18AM

ab...@gmail.com <ab...@gmail.com> #44Dec 16, 2024 01:35PM

Add comment

Issue metadata