FusedLocationApi leaks when requestLocationUpdates is called [37126862]

Fixed

Bug

Status Update

No update yet.

Description

fe...@gmail.com

created issue #1

Nov 16, 2016 08:42PM

- Steps to reproduce the problem:
Call LocationServices.FusedLocationApi.requestLocationUpdates(mGoogleApiClient, mLocationRequest, this); will result in a leak. Even though I'm calling removeLocationUpdates, disconnect, unregisterConnectionCallbacks and unregisterConnectionFailedListener inside onPause/onStop.
See attached project file.

- What happened:
LeakCanary reports a leak in an internal class from the package com.google.android.gms.location.
See attached log.

- What you think the correct behavior should be:
There shouldn't be any leaks.

Android version 6.0
Google Play Services 9.8.0
Related issue:

https://github.com/googlesamples/android-play-location/issues/26

deleted

Restricted

0 B

deleted

Restricted

0 B

Comments

fe...@gmail.com <fe...@gmail.com> #2Nov 17, 2016 07:41PM

A link to another sample project demonstrating that the leak only happens when using: LocationServices.FusedLocationApi.requestLocationUpdates but does not happen using a deprecated method: googleMap.setOnMyLocationChangeListener.

https://github.com/fernandospr/android-maps-userlocation

in...@gmail.com <in...@gmail.com> #3Dec 11, 2016 12:25AM

Hello, I'm also experiencing the memory leak in my activity responsible for the location service.

The implementation of my project is not different from the example project attached by fernando.

[Deleted User] <[Deleted User]> #4Jul 12, 2017 03:30PM

FYI this memory leak also seems to exist when using the new FusedLocationProviderClient. I took Fernano's sample from

comment #2

and hacked it up to use the FusedLocationProviderClient and was still able to observe the leak upon exiting the activity.

ub...@gmail.com <ub...@gmail.com> #5Mar 12, 2019 01:36PM

Leak still present in 2019 on latest play-services-location 16.0.0. 3+ years since first reported via linked Github issue, no fix or hint of acknowledgment. Clown college grade software engineering.

fi...@gmail.com <fi...@gmail.com> #6Aug 4, 2019 01:19AM

I am also still experiencing this!

de...@gmail.com <de...@gmail.com> #7Dec 11, 2019 03:49PM

Still present in 'com.google.android.gms:play-services-location:17.0.0'

As an alternative I am using FusedLocationProviderClient with PendingIntent:

IntentFilter intentFilter = new IntentFilter(ACTION_LOCATION);
registerReceiver(locationReceiver, intentFilter);
mFusedLocationClient.requestLocationUpdates(mLocationRequest, locationPendingIntent);
and
unregisterReceiver(locationReceiver);
mFusedLocationClient.removeLocationUpdates(locationPendingIntent)

Here is forked LocationUpdates repo with LeakCanary installed and an option to switch between LocationCallback and PendingIntent. LeakCanary not reporting anything when using PendingIntent.

https://github.com/dejandobnikar/location-samples/tree/master/LocationUpdates

sa...@google.com <sa...@google.com> #8Aug 18, 2020 03:24PM

Status: Won't Fix (Obsolete)

Thank you for your feedback. We assure you that we are doing our best to address all issues reported. For now, we will be closing the issue as won't fix obsolete. If this issue currently still exists, we request that you log a new issue along with the bug report here

https://goo.gl/TbMiIO and reference this bug for context.

ub...@gmail.com <ub...@gmail.com> #9Aug 21, 2020 08:04PM

Comment #8

, the one thing that would matter to address is how to *actually* get this issue fixed. It appears pointless to file a new issue, and unclear where to do so, as this issue has not received attention from Google's side throughout the years despite quite a few people starring it and bug reports in different places. The continued existence of the bug was confirmed not long ago in prior comments by different people. I've just confirmed it again myself on R Beta 3.

di...@gmail.com <di...@gmail.com> #10Mar 12, 2021 04:02PM

According to some Google DevRel it might soon be fixed, see the answer (from 8 days ago) here:

https://github.com/googlecodelabs/while-in-use-location/issues/7

je...@google.com <je...@google.com> #11Feb 8, 2022 05:37PM

Status: New (reopened)

This issue still exists, how can this be prioritized?

ub...@gmail.com <ub...@gmail.com> #12Feb 8, 2022 05:57PM

There is an issuetracker Component available these days for Play Services Location: https://issuetracker.google.com/components/1065160

Maybe move this issue to that Component to track it better?

je...@google.com <je...@google.com> #13Feb 9, 2022 12:18AM

I can't move it right now, but I think it's ok to stay here.

As I wrote in the code lab issue, I misunderstood when the rewrite went out (which should fix the issue).

It goes live in version 20 (current version location 19.0.1). The engineer who wrote the rewrite checked and wasn't seeing the same issue, i.e., it should be resolved.

However, that does mean we have to wait until 20 is released. I can check in again here when it's live for you to double check.

br...@gmail.com <br...@gmail.com> #14Jun 13, 2022 11:55AM

8 ram

je...@google.com <je...@google.com> #15Jul 18, 2022 05:32PM

I haven't been on location in awhile, but I wanted to follow up on this.

The issue should be resolved with the play-services-location:20.0.0 release from my understanding.

so...@google.com <so...@google.com> Aug 8, 2022 09:05PM

Marked as fixed, reassigned to so...@google.com.