Crash using TransitionManager to collapse/expand item in RecyclerView [37129527]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ox...@gmail.com

created issue #1

Dec 11, 2016 01:02AM

Library used: recyclerview-v7
Version used: 25.0.0 and 25.0.1. Haven't tried earlier versions.
Devices/Android versions reproduced on: N6p 7.1.1, 6.0 emulator

Here's a video showing the issue occurring in plaid:

https://youtu.be/sVawQ3g9PI4

Using a TransitionManager to expand/collapse an item in RecyclerView causes the following exception when clicking the same item multiple times without letting the animation complete. The problem occurs in our app and can be reproduced in plaid as well and the below exception is from plaid.

To reproduce on plaid go to the page with comments and position the RecyclerView so that an expansion will cause the bottom item to go off the bottom of the screen. Now keep clicking the item without letting the expansion animation complete and it will crash after a few seconds.

12-11 11:30:27.508 31668-31668/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: io.plaidapp, PID: 31668
java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
at android.view.ViewGroup.addViewInner(ViewGroup.java:4417)
at android.view.ViewGroup.addView(ViewGroup.java:4258)
at android.view.ViewGroup.addView(ViewGroup.java:4198)
at android.support.v7.widget.RecyclerView$5.addView(RecyclerView.java:676)
at android.support.v7.widget.ChildHelper.addView(ChildHelper.java:107)
at android.support.v7.widget.RecyclerView$LayoutManager.addViewInt(RecyclerView.java:7399)
at android.support.v7.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:7357)
at android.support.v7.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:7345)
at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1459)
at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1408)
at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:580)
at android.support.v7.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:3325)
at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3181)
at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3627)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1741)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1585)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1494)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at com.android.internal.policy.DecorView.onLayout(DecorView.java:726)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2346)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2068)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6337)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
at android.view.Choreographer.doCallbacks(Choreographer.java:686)
at android.view.Choreographer.doFrame(Choreographer.java:621)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Comments

dn...@google.com <dn...@google.com> Dec 12, 2016 10:22AM

Assigned to dn...@google.com.

dn...@google.com <dn...@google.com> #2Dec 13, 2016 09:29AM

Status: New

Update: I was able to downgrade to 32.1.10 and I can confirm it's smooth again. The issue is indeed in emulator version 33.1.1

ox...@gmail.com <ox...@gmail.com> #3Dec 14, 2016 12:41AM

It's happening to me too and I also confirm that reverting to 32.1.10 fixes the issue.

We should have an easier way of reverting versions. AS should allow picking the version similarly to how we already do for the other tools in SDK manager.

dn...@google.com <dn...@google.com> #4Dec 14, 2016 10:06AM

Assigned to dn...@google.com.

Hi,

would you try to turn on hardware GPU rendering (instead of auto GPU) and see if it fixes this issue?

we...@gmail.com <we...@gmail.com> #5Mar 14, 2017 01:03PM

Hi,

I'm currently not able to change this option, it is greyed out.

pa...@raizlabs.com <pa...@raizlabs.com> #6Mar 15, 2017 08:13PM

Hi,

there are 2 ways to set it:

1. use a google_apis image (instead of google_apis_playstore). it will re-enable the option.
2. go to your avd folder (usually located in ~/.android/avd/your_avd_name.avd/), open config.ini and hardware-qemu.ini, then modify those lines:

hw.gpu.enabled=yes
hw.gpu.mode=host

pa...@raizlabs.com <pa...@raizlabs.com> #7Mar 23, 2017 10:38PM

Hi,

Yes, option 2 fixes the issue (which also persists on 33.1.2 btw). Even though I get a warning when I start the emulator (see attachments).

Will this option be enabled "out of the box" in a future version?

pa...@raizlabs.com <pa...@raizlabs.com> #8Mar 23, 2017 10:40PM

Hi,

we suspect a bug in gpu detection logic on Mac M1, and will try to address it in upcoming releases.

pa...@raizlabs.com <pa...@raizlabs.com> #9Mar 23, 2017 10:43PM

Hi Devki,

would you help to cp aosp/2451107 to next stable and canary releases? Thank you!

pa...@raizlabs.com <pa...@raizlabs.com> #10Mar 23, 2017 10:46PM

Hi Devki,

Could we cherry-pick it to canary release as well? Thanks!

so...@gmail.com <so...@gmail.com> #11Oct 10, 2017 05:00PM

@yahan it will be picked up in the next canary since we are doing snaps!

so...@gmail.com <so...@gmail.com> #12Oct 10, 2017 05:05PM

Thanks!

so...@gmail.com <so...@gmail.com> #13Oct 10, 2017 05:45PM

Was able to force the emulator to use the host GPU by opening it via the terminal with

./emulator -avd Resizable_API_33 -gpu host

so...@gmail.com <so...@gmail.com> #14Oct 13, 2017 10:37AM

I believe this is still happening in 33.1.10

ma...@gmail.com <ma...@gmail.com> #15Oct 15, 2017 12:06PM

Chris, would you help to send us the verbose log?

ma...@gmail.com <ma...@gmail.com> #16Feb 4, 2018 07:22PM

User on #comment13 should provide it. User was the one who reported this still happening with Play Store images, via Slack communities. I can also try to repro myself.

is...@google.com <is...@google.com> Nov 1, 2018 07:16AM