Crash using TransitionManager to collapse/expand item in RecyclerView [37129527]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ox...@gmail.com

created issue #1

Dec 11, 2016 01:02AM

Library used: recyclerview-v7
Version used: 25.0.0 and 25.0.1. Haven't tried earlier versions.
Devices/Android versions reproduced on: N6p 7.1.1, 6.0 emulator

Here's a video showing the issue occurring in plaid:

https://youtu.be/sVawQ3g9PI4

Using a TransitionManager to expand/collapse an item in RecyclerView causes the following exception when clicking the same item multiple times without letting the animation complete. The problem occurs in our app and can be reproduced in plaid as well and the below exception is from plaid.

To reproduce on plaid go to the page with comments and position the RecyclerView so that an expansion will cause the bottom item to go off the bottom of the screen. Now keep clicking the item without letting the expansion animation complete and it will crash after a few seconds.

12-11 11:30:27.508 31668-31668/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: io.plaidapp, PID: 31668
java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
at android.view.ViewGroup.addViewInner(ViewGroup.java:4417)
at android.view.ViewGroup.addView(ViewGroup.java:4258)
at android.view.ViewGroup.addView(ViewGroup.java:4198)
at android.support.v7.widget.RecyclerView$5.addView(RecyclerView.java:676)
at android.support.v7.widget.ChildHelper.addView(ChildHelper.java:107)
at android.support.v7.widget.RecyclerView$LayoutManager.addViewInt(RecyclerView.java:7399)
at android.support.v7.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:7357)
at android.support.v7.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:7345)
at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1459)
at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1408)
at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:580)
at android.support.v7.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:3325)
at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3181)
at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3627)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1741)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1585)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1494)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at com.android.internal.policy.DecorView.onLayout(DecorView.java:726)
at android.view.View.layout(View.java:17637)
at android.view.ViewGroup.layout(ViewGroup.java:5575)
at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2346)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2068)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6337)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
at android.view.Choreographer.doCallbacks(Choreographer.java:686)
at android.view.Choreographer.doFrame(Choreographer.java:621)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Comments

dn...@google.com <dn...@google.com> Dec 12, 2016 10:22AM

Assigned to dn...@google.com.

dn...@google.com <dn...@google.com> #2Dec 13, 2016 09:29AM

Status: New

[Comment deleted]

ox...@gmail.com <ox...@gmail.com> #3Dec 14, 2016 12:41AM

Second app is called "YouTube for Google TV" (

https://play.google.com/store/apps/details?id=com.google.android.youtube.googletv). It's strange that you can't find it on Google Play, maybe it has some regional/device restrictions or something.

dn...@google.com <dn...@google.com> #4Dec 14, 2016 10:06AM

Assigned to dn...@google.com.

Thank you very much for your quick reply.

I can find the "YouTube for Google TV" app on the Google Play Store when searching through the browser on my PC. But on my phone, if I search for it on the Google Play Store it does not come up. I see the "YouTube" app suitable for my phone, which shows as "installed", and I see "Google Play Movies and TV". Same on my tablet.

On my Android TV Nexus Player, I find "YouTube for Android TV" and "Google Play Movies and TV", but not "YouTube for Google TV".

This article

http://www.makeuseof.com/tag/android-tv-google-tv-killed/
would seem to explain what is going on, as well as the bitterly negative reviews for the March 2015 upgrade of the "YouTube for Google TV" app, here:

https://play.google.com/store/apps/details?id=com.google.android.youtube.googletv

The fact that I can't install "YouTube for Google TV" on my Android TV is not surprising -- It seems clear that Google doesn't want Android TV owners to have access to it.

So, back to the original problem: It seems then that the YouTubeAPI for Android is not supported on Android TV (at least currently). So, your original question is still a good one: will Google make the YouTube API library work with the default "YouTube for Android TV" application? Maybe they really don't want the YouTube viewing experience on the living room TV to be customized in third-party apps.

we...@gmail.com <we...@gmail.com> #5Mar 14, 2017 01:03PM

[ replacing my earlier comment with my email address removed ]

Thank you for this post. I am having the same problem with the default pre-installed version of YouTube on my Android TV Nexus Player. When I attempt to "UPDATE YOUTUBE APP" it doesn't actually update it. If I uninstall and re-install YouTube, it simply re-installs the same version (version 1.0.5.4, updated on Mar 26, 2015, 8.62 MB). If I uninstall that, and search on Google Play Store for the com.google.android.youtube.googletv app recommended above, it doesn't find it - it only finds the first app.

You say "But installing of second app is very inconvenient for users." - I agree - it's so inconvenient, I can't figure out even how to do it.
Would you mind telling me how you did it?

Thank you,
Lloyd

pa...@raizlabs.com <pa...@raizlabs.com> #6Mar 15, 2017 08:13PM

Any recommendations on how to implement youtube player on Android TV? I tried with a WebView and I got a white screen and my application just crashed after focusing the WebView

pa...@raizlabs.com <pa...@raizlabs.com> #7Mar 23, 2017 10:38PM

No one have any information about this ? At least, know if is an error or other ?

pa...@raizlabs.com <pa...@raizlabs.com> #8Mar 23, 2017 10:40PM

I have the same issue;

Nexus Player with android 5.1.1;
com.google.android.youtube.googletv is not installed (and can't be installed) and the youtube player api gives an error and suggests to update the youtube app.

Waiting for updates...

pa...@raizlabs.com <pa...@raizlabs.com> #9Mar 23, 2017 10:43PM

Same problem here... Would be great to have a response from Google.

pa...@raizlabs.com <pa...@raizlabs.com> #10Mar 23, 2017 10:46PM

See this post on SO:

http://stackoverflow.com/questions/30716694/android-tv-embedded-youtube-1080p/31038253#31038253

so...@gmail.com <so...@gmail.com> #11Oct 10, 2017 05:00PM

Thanks shawns. But does it mean it's a bug and it will be fixed (The init error with Update Youtube App make me think that) or google don't want to allow Youtube Player API on Android TV ?

so...@gmail.com <so...@gmail.com> #12Oct 10, 2017 05:05PM

any more word from y/t on the fix for this or timelines?

so...@gmail.com <so...@gmail.com> #13Oct 10, 2017 05:45PM

Additionally, this problem is affecting end-users as well as developers.

I'm using the API for YouTube thumbnails, and am using the onInitializationFailure callback to detect failure. When a user recoverable error happens, the YouTube app linked to from the Dialog is "not available on this device". Very confusing for users, as they can clearly see that it is there.

@Override
public void onInitializationFailure(YouTubeThumbnailView view, YouTubeInitializationResult loader) {
if (loader.isUserRecoverableError()) {
loader.getErrorDialog(activity, code).show();
}
}

so...@gmail.com <so...@gmail.com> #14Oct 13, 2017 10:37AM

Youtube for google tv was replaced by youtube for android tv. so, I try to use YouTube Player API Reference for iframe Embeds and achieved most of all functions basically. But it seems working with a long delay and the style of the layer is not good.

So, do you have the new api for android tv?

and there the address for iframe api:

https://developers.google.com/youtube/iframe_api_reference

ma...@gmail.com <ma...@gmail.com> #15Oct 15, 2017 12:06PM

Hi everyone, thanks for the reports on this. The YouTubeAPI class is not supported on the Android TV platform, and there are no plans to add support for it at this time.

ma...@gmail.com <ma...@gmail.com> #16Feb 4, 2018 07:22PM

For your information, I've created YoutubeTV library (

https://github.com/bertrandmartel/youtubetv), a wrapper library for YouTube Player API Reference for iframe Embeds

It provides a YoutubeTvView that embeds a Webview with Youtube iframe with all Javascript API available from this view.

Also, YoutubeTvFragment holds a YoutubeTvView with a media control bar (PlaybackOverlayFragment)

is...@google.com <is...@google.com> Nov 1, 2018 07:16AM

Status: New

an...@google.com <an...@google.com> #17Nov 6, 2018 06:20PM

Marked as fixed, reassigned to an...@google.com.

So ma....@google, tell me please. I'm an end user, and I want to utilize My Amazon Echo thusly: "Alexa, turn on fireplace" and have it launch a YouTube fireplace video. You seem to be saying this cannot be done and will not be accommodated.

Are you folks aware of what's actually occurring out here in the world? This is the future, and can't be difficult to do. Please enable it.

be...@gmail.com <be...@gmail.com> #18Dec 5, 2018 05:27PM

Thank you for your help.

2017년 2월 26일 (일) 오후 8:31, <buganizer-system@google.com>님이 작성:

- Show quoted text -