apksigner fails to sign when keystore and key passwords differ and apksigner isn't explicitly told how to obtain the passwords [37134986]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Feb 3, 2017 09:24PM

When apksigner is invoked without explicitly specifying how to obtain the keystore and key password, apksigner prompts for keystore password and uses that as the key password as well, making it impossible to use keystores where the keystore password differs from key password. A workaround is to explicitly tell apksigner how to obtain these two passwords. For example, --ks-pass=stdin --key-pass=stdin will force apksigner to prompt for keystore password and then prompt for key password.

STEPS TO REPRODUCE
1. Create a keystore where the keystore password is different from key password.
2. apksigner sign --ks keystore.jks some.apk

EXPECTED RESULTS
apksigner prompts for keystore password, then prompts for key password

ACTUAL RESULTS
apksigner prompts for keystore password, then fails claiming that it can't obtain the key because "Wrong password?"

Comments

kl...@google.com <kl...@google.com> #2Feb 15, 2017 08:36PM

I have the same issue. There should be a built in method for setting title dynamically.

kl...@google.com <kl...@google.com> #3Mar 7, 2017 05:28AM

I would expect a simple API inside the navigation architecture as this is quite a common design requirement

kl...@google.com <kl...@google.com> #4Apr 24, 2017 06:23PM

To me, it is perfectly reasonable to remove the `android:label` attribute from the nav_graph.xml and set the title manually based on the arguments bundle.

cb...@google.com <cb...@google.com> Apr 24, 2017 06:24PM

Marked as fixed.

ba...@gmail.com <ba...@gmail.com> #5May 7, 2017 02:23AM

I'm currently working around this limitation by adding an "onNavigatedListener" to my root Activity and using the "

destination.id" property against a lookup mapping to a desired title:

private val onNavigatedListener: (NavController, NavDestination) -> Unit = { _, destination ->
this.title = titleLookup[

destination.id]
}

pr...@gmail.com <pr...@gmail.com> #6May 24, 2017 04:12PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a958e3d36aeca8767d1c3cb53caa55ba3dd1c65d
Author: Ian Lake <ilake@google.com>
Date: Wed Nov 28 16:06:01 2018

Allow {argName} parameterized labels

Support parameterized labels similarly
to how ActivityNavigator uses dataPattern by
using {argName} blocks in the label.

Test: testapp works
BUG: 80267266
Change-Id: I923f3a6e11662c4364d4b3f0757361edea016cec

M navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M navigation/integration-tests/testapp/src/main/res/values/strings.xml
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnNavigatedListener.java

https://android-review.googlesource.com/837143

https://goto.google.com/android-sha1/a958e3d36aeca8767d1c3cb53caa55ba3dd1c65d

82...@gmail.com <82...@gmail.com> #7Jan 4, 2019 06:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5e475aa0a00390755a9d4a9260c827b72ec81eb2
Author: Ian Lake <ilake@google.com>
Date: Wed Nov 28 15:48:29 2018

Pass Bundle of arguments to OnNavigatedListeners

Instead of just passing the NavDestination,
pass both the NavDestination and the (optional)
Bundle of arguments. This allows listeners to
dynamically update their content rather than only
relying on the fixed data from the NavDestination.

Test: testapp still works
BUG: 80267266
Change-Id: I80f0e65526711a2ba11b7a12fc907a1b9dbe83e9

A navigation/common/src/main/java/androidx/navigation/NavBackStackEntry.java
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/NavigationActivity.kt
M navigation/runtime/api/1.0.0-alpha08.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnNavigatedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnNavigatedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/ui/src/main/java/androidx/navigation/ui/ToolbarOnNavigatedListener.java

https://android-review.googlesource.com/837142

https://goto.google.com/android-sha1/5e475aa0a00390755a9d4a9260c827b72ec81eb2