apksigner fails to sign when keystore and key passwords differ and apksigner isn't explicitly told how to obtain the passwords [37134986]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Feb 3, 2017 09:24PM

When apksigner is invoked without explicitly specifying how to obtain the keystore and key password, apksigner prompts for keystore password and uses that as the key password as well, making it impossible to use keystores where the keystore password differs from key password. A workaround is to explicitly tell apksigner how to obtain these two passwords. For example, --ks-pass=stdin --key-pass=stdin will force apksigner to prompt for keystore password and then prompt for key password.

STEPS TO REPRODUCE
1. Create a keystore where the keystore password is different from key password.
2. apksigner sign --ks keystore.jks some.apk

EXPECTED RESULTS
apksigner prompts for keystore password, then prompts for key password

ACTUAL RESULTS
apksigner prompts for keystore password, then fails claiming that it can't obtain the key because "Wrong password?"

Comments

kl...@google.com <kl...@google.com> #2Feb 15, 2017 08:36PM

Thank you for this feedback. The team may reach out for more information on triaging or reproducing this issue.

kl...@google.com <kl...@google.com> #3Mar 7, 2017 05:28AM

I have tried the example project you've provided, it does not reproduce.

Could you please try running with -Pandroid.useDexArchive=false? This disables the new dexing pipeline, and fallbacks to the old one.

kl...@google.com <kl...@google.com> #4Apr 24, 2017 06:23PM

@Mario Did you get a chance to try the build with -Pandroid.useDexArchive=false flag?

cb...@google.com <cb...@google.com> Apr 24, 2017 06:24PM

Marked as fixed.

ba...@gmail.com <ba...@gmail.com> #5May 7, 2017 02:23AM

I'm the college of @Mario and I make it work without issues and without using -Pandroid.useDexArchive=false by using alpha6 and removing retrolambda

pr...@gmail.com <pr...@gmail.com> #6May 24, 2017 04:12PM

Sorry my comment from Apr 21, 2017 12:41PM was wrong.
With -Pandroid.useDexArchive=false it looks like this

:app:transformClassesWithDesugarForNonpayItalyCompatDebugAndroidTest
:app:transformClassesWithPreDexForNonpayItalyCompatDebugAndroidTest
Dex: warning: Ignoring InnerClasses attribute for an anonymous inner class
(org.ccil.cowan.tagsoup.Parser$1) that doesn't come with an
associated EnclosingMethod attribute. This class was probably produced by a
compiler that did not target the modern .class file format. The recommended
solution is to recompile the class from source, using an up-to-date compiler
and without specifying any "-target" type options. The consequence of ignoring
this warning is that reflective operations on this class will incorrectly
indicate that it is *not* an inner class.

:app:transformDexWithDexForNonpayItalyCompatDebugAndroidTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:transformDexWithDexForNonpayItalyCompatDebugAndroidTest'.
> com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexIndexOverflowException: method ID not in [0, 0xffff]: 65536

82...@gmail.com <82...@gmail.com> #7Jan 4, 2019 06:15PM

We updated our example repo

https://github.com/originx/Gradle_troubles_android_enteprise where you can see the issue.
Just run

./gradlew spoonGermanyDebugAndroidTest
or
./gradlew spoonGermanyDebugAndroidTest -Pandroid.useDexArchive=false

and you will see the issue